From: rob.lee@linaro.org (Robert Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 9/9] ARM: at91: Consolidate cpuidle functionality
Date: Sun, 26 Feb 2012 22:47:43 -0600 [thread overview]
Message-ID: <1330318063-25460-10-git-send-email-rob.lee@linaro.org> (raw)
In-Reply-To: <1330318063-25460-1-git-send-email-rob.lee@linaro.org>
Use newly added core cpuidle functionality and remove this duplicated
code from the platform cpuidle.
Signed-off-by: Robert Lee <rob.lee@linaro.org>
---
arch/arm/mach-at91/cpuidle.c | 64 ++++++++++++++---------------------------
1 files changed, 22 insertions(+), 42 deletions(-)
diff --git a/arch/arm/mach-at91/cpuidle.c b/arch/arm/mach-at91/cpuidle.c
index a851e6c..10c1564 100644
--- a/arch/arm/mach-at91/cpuidle.c
+++ b/arch/arm/mach-at91/cpuidle.c
@@ -27,66 +27,46 @@
static DEFINE_PER_CPU(struct cpuidle_device, at91_cpuidle_device);
-static struct cpuidle_driver at91_idle_driver = {
- .name = "at91_idle",
- .owner = THIS_MODULE,
-};
-
/* Actual code that puts the SoC in different idle states */
static int at91_enter_idle(struct cpuidle_device *dev,
struct cpuidle_driver *drv,
int index)
{
- struct timeval before, after;
- int idle_time;
u32 saved_lpr;
- local_irq_disable();
- do_gettimeofday(&before);
- if (index == 0)
- /* Wait for interrupt state */
- cpu_do_idle();
- else if (index == 1) {
- asm("b 1f; .align 5; 1:");
- asm("mcr p15, 0, r0, c7, c10, 4"); /* drain write buffer */
- saved_lpr = sdram_selfrefresh_enable();
- cpu_do_idle();
- sdram_selfrefresh_disable(saved_lpr);
- }
- do_gettimeofday(&after);
- local_irq_enable();
- idle_time = (after.tv_sec - before.tv_sec) * USEC_PER_SEC +
- (after.tv_usec - before.tv_usec);
+ __asm__("b 1f; .align 5; 1:\n"
+ " mcr p15, 0, r0, c7, c10, 4"); /* drain write buffer */
+
+ saved_lpr = sdram_selfrefresh_enable();
+ cpu_do_idle();
+ sdram_selfrefresh_disable(saved_lpr);
- dev->last_residency = idle_time;
return index;
}
+static struct cpuidle_driver at91_idle_driver = {
+ .name = "at91_idle",
+ .owner = THIS_MODULE,
+ .en_core_tk_irqen = 1,
+ .states[0] = CPUIDLE_ARM_WFI_STATE,
+ .states[1] = {
+ .enter = at91_enter_idle,
+ .exit_latency = 10,
+ .target_residency = 100000,
+ .flags = CPUIDLE_FLAG_TIME_VALID,
+ .name = "RAM_SR",
+ .desc = "WFI and DDR Self Refresh",
+ },
+ .state_count = AT91_MAX_STATES,
+};
+
/* Initialize CPU idle by registering the idle states */
static int at91_init_cpuidle(void)
{
struct cpuidle_device *device;
- struct cpuidle_driver *driver = &at91_idle_driver;
device = &per_cpu(at91_cpuidle_device, smp_processor_id());
device->state_count = AT91_MAX_STATES;
- driver->state_count = AT91_MAX_STATES;
-
- /* Wait for interrupt state */
- driver->states[0].enter = at91_enter_idle;
- driver->states[0].exit_latency = 1;
- driver->states[0].target_residency = 10000;
- driver->states[0].flags = CPUIDLE_FLAG_TIME_VALID;
- strcpy(driver->states[0].name, "WFI");
- strcpy(driver->states[0].desc, "Wait for interrupt");
-
- /* Wait for interrupt and RAM self refresh state */
- driver->states[1].enter = at91_enter_idle;
- driver->states[1].exit_latency = 10;
- driver->states[1].target_residency = 10000;
- driver->states[1].flags = CPUIDLE_FLAG_TIME_VALID;
- strcpy(driver->states[1].name, "RAM_SR");
- strcpy(driver->states[1].desc, "WFI and RAM Self Refresh");
cpuidle_register_driver(&at91_idle_driver);
--
1.7.1
next prev parent reply other threads:[~2012-02-27 4:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 4:47 [PATCH v5 0/9] Consolidate cpuidle functionality Robert Lee
2012-02-27 4:47 ` [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation Robert Lee
2012-02-27 16:19 ` Jean Pihet
2012-02-27 19:23 ` Rob Lee
2012-02-28 0:06 ` Turquette, Mike
2012-02-28 15:45 ` Rob Lee
2012-02-28 15:58 ` Rob Herring
2012-02-28 20:49 ` Rob Lee
2012-02-28 0:49 ` Turquette, Mike
2012-02-28 15:50 ` Rob Lee
2012-02-28 21:42 ` Turquette, Mike
2012-02-28 23:33 ` Rob Lee
2012-02-28 23:47 ` Turquette, Mike
2012-02-29 0:04 ` Rob Lee
2012-02-27 4:47 ` [PATCH v5 2/9] SH: shmobile: cpuidle consolidation Robert Lee
2012-02-27 15:13 ` Rob Lee
2012-02-27 4:47 ` [PATCH v5 3/9] ARM: omap: Consolidate OMAP3 cpuidle time keeping and irq enable Robert Lee
2012-02-27 16:26 ` Jean Pihet
2012-02-27 19:27 ` Rob Lee
2012-02-27 4:47 ` [PATCH v5 4/9] ARM: omap: Consolidate OMAP4 " Robert Lee
2012-02-27 4:47 ` [PATCH v5 5/9] ARM: shmobile: Consolidate cpuidle functionality Robert Lee
2012-02-27 4:47 ` [PATCH v5 6/9] ARM: davinci: " Robert Lee
2012-02-27 4:47 ` [PATCH v5 7/9] ARM: exynos: " Robert Lee
2012-02-27 4:47 ` [PATCH v5 8/9] ARM: kirkwood: " Robert Lee
2012-02-27 4:47 ` Robert Lee [this message]
2012-02-27 16:32 ` [PATCH v5 0/9] " Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330318063-25460-10-git-send-email-rob.lee@linaro.org \
--to=rob.lee@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).