linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rob.lee@linaro.org (Robert Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 7/9] ARM: omap: Consolidate OMAP4 time keeping and irq enable
Date: Tue, 28 Feb 2012 21:11:47 -0600	[thread overview]
Message-ID: <1330485109-7327-8-git-send-email-rob.lee@linaro.org> (raw)
In-Reply-To: <1330485109-7327-1-git-send-email-rob.lee@linaro.org>

Enable core cpuidle timekeeping and irq enabling and remove that
handling from this code.

Signed-off-by: Robert Lee <rob.lee@linaro.org>
---
 arch/arm/mach-omap2/cpuidle44xx.c |   21 +++------------------
 1 files changed, 3 insertions(+), 18 deletions(-)

diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c
index cfdbb86..9729d2e 100644
--- a/arch/arm/mach-omap2/cpuidle44xx.c
+++ b/arch/arm/mach-omap2/cpuidle44xx.c
@@ -62,16 +62,10 @@ static int omap4_enter_idle(struct cpuidle_device *dev,
 {
 	struct omap4_idle_statedata *cx =
 			cpuidle_get_statedata(&dev->states_usage[index]);
-	struct timespec ts_preidle, ts_postidle, ts_idle;
 	u32 cpu1_state;
-	int idle_time;
 	int new_state_idx;
 	int cpu_id = smp_processor_id();
 
-	/* Used to keep track of the total time in idle */
-	getnstimeofday(&ts_preidle);
-
-	local_irq_disable();
 	local_fiq_disable();
 
 	/*
@@ -129,26 +123,17 @@ static int omap4_enter_idle(struct cpuidle_device *dev,
 	if (index > 0)
 		clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu_id);
 
-	getnstimeofday(&ts_postidle);
-	ts_idle = timespec_sub(ts_postidle, ts_preidle);
-
-	local_irq_enable();
 	local_fiq_enable();
 
-	idle_time = ts_idle.tv_nsec / NSEC_PER_USEC + ts_idle.tv_sec * \
-								USEC_PER_SEC;
-
-	/* Update cpuidle counters */
-	dev->last_residency = idle_time;
-
 	return index;
 }
 
 DEFINE_PER_CPU(struct cpuidle_device, omap4_idle_dev);
 
 struct cpuidle_driver omap4_idle_driver = {
-	.name =		"omap4_idle",
-	.owner =	THIS_MODULE,
+	.name				= "omap4_idle",
+	.owner				= THIS_MODULE,
+	.en_core_tk_irqen	= 1,
 };
 
 static inline void _fill_cstate(struct cpuidle_driver *drv,
-- 
1.7.1

  parent reply	other threads:[~2012-02-29  3:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29  3:11 [PATCH v6 0/9] Consolidate cpuidle functionality Robert Lee
2012-02-29  3:11 ` [PATCH v6 1/9] cpuidle: Add common time keeping and irq enabling Robert Lee
2012-02-29  8:30   ` Jean Pihet
2012-02-29 13:30     ` Rob Lee
2012-02-29 11:13   ` Deepthi Dharwar
2012-02-29 13:33     ` Rob Lee
2012-02-29 18:43   ` Kevin Hilman
2012-02-29 21:17     ` Rob Lee
2012-02-29  3:11 ` [PATCH v6 2/9] ARM: at91: Consolidate time keeping and irq enable Robert Lee
2012-02-29  3:11 ` [PATCH v6 3/9] ARM: exynos: " Robert Lee
2012-02-29  6:41   ` Amit Kachhap
2012-02-29  3:11 ` [PATCH v6 4/9] ARM: kirkwood: " Robert Lee
2012-02-29  3:11 ` [PATCH v6 5/9] ARM: davinci: " Robert Lee
2012-02-29  8:36   ` Jean Pihet
2012-02-29 13:36     ` Rob Lee
2012-02-29  3:11 ` [PATCH v6 6/9] ARM: omap: Consolidate OMAP3 " Robert Lee
2012-02-29  3:11 ` Robert Lee [this message]
2012-02-29  3:11 ` [PATCH v6 8/9] ARM: shmobile: Consolidate " Robert Lee
2012-02-29  3:11 ` [PATCH v6 9/9] SH: " Robert Lee
2012-02-29  9:40 ` [PATCH v6 0/9] Consolidate cpuidle functionality Jean Pihet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330485109-7327-8-git-send-email-rob.lee@linaro.org \
    --to=rob.lee@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).