linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rob.lee@linaro.org (Robert Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 8/9] ARM: shmobile: Consolidate time keeping and irq enable
Date: Tue, 28 Feb 2012 21:11:48 -0600	[thread overview]
Message-ID: <1330485109-7327-9-git-send-email-rob.lee@linaro.org> (raw)
In-Reply-To: <1330485109-7327-1-git-send-email-rob.lee@linaro.org>

Enable core cpuidle timekeeping and irq enabling and remove that
handling from this code.

Signed-off-by: Robert Lee <rob.lee@linaro.org>
---
 arch/arm/mach-shmobile/cpuidle.c |   23 +++--------------------
 1 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/arch/arm/mach-shmobile/cpuidle.c b/arch/arm/mach-shmobile/cpuidle.c
index 1b23342..47b56a9 100644
--- a/arch/arm/mach-shmobile/cpuidle.c
+++ b/arch/arm/mach-shmobile/cpuidle.c
@@ -14,6 +14,7 @@
 #include <linux/module.h>
 #include <linux/err.h>
 #include <asm/system.h>
+#include <asm/cpuidle.h>
 #include <asm/io.h>
 
 static void shmobile_enter_wfi(void)
@@ -29,21 +30,8 @@ static int shmobile_cpuidle_enter(struct cpuidle_device *dev,
 				  struct cpuidle_driver *drv,
 				  int index)
 {
-	ktime_t before, after;
-
-	before = ktime_get();
-
-	local_irq_disable();
-	local_fiq_disable();
-
 	shmobile_cpuidle_modes[index]();
 
-	local_irq_enable();
-	local_fiq_enable();
-
-	after = ktime_get();
-	dev->last_residency = ktime_to_ns(ktime_sub(after, before)) >> 10;
-
 	return index;
 }
 
@@ -51,13 +39,8 @@ static struct cpuidle_device shmobile_cpuidle_dev;
 static struct cpuidle_driver shmobile_cpuidle_driver = {
 	.name =		"shmobile_cpuidle",
 	.owner =	THIS_MODULE,
-	.states[0] = {
-		.name = "C1",
-		.desc = "WFI",
-		.exit_latency = 1,
-		.target_residency = 1 * 2,
-		.flags = CPUIDLE_FLAG_TIME_VALID,
-	},
+	.en_core_tk_irqen = 1,
+	.states[0] = CPUIDLE_ARM_WFI_STATE,
 	.safe_state_index = 0, /* C1 */
 	.state_count = 1,
 };
-- 
1.7.1

  parent reply	other threads:[~2012-02-29  3:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29  3:11 [PATCH v6 0/9] Consolidate cpuidle functionality Robert Lee
2012-02-29  3:11 ` [PATCH v6 1/9] cpuidle: Add common time keeping and irq enabling Robert Lee
2012-02-29  8:30   ` Jean Pihet
2012-02-29 13:30     ` Rob Lee
2012-02-29 11:13   ` Deepthi Dharwar
2012-02-29 13:33     ` Rob Lee
2012-02-29 18:43   ` Kevin Hilman
2012-02-29 21:17     ` Rob Lee
2012-02-29  3:11 ` [PATCH v6 2/9] ARM: at91: Consolidate time keeping and irq enable Robert Lee
2012-02-29  3:11 ` [PATCH v6 3/9] ARM: exynos: " Robert Lee
2012-02-29  6:41   ` Amit Kachhap
2012-02-29  3:11 ` [PATCH v6 4/9] ARM: kirkwood: " Robert Lee
2012-02-29  3:11 ` [PATCH v6 5/9] ARM: davinci: " Robert Lee
2012-02-29  8:36   ` Jean Pihet
2012-02-29 13:36     ` Rob Lee
2012-02-29  3:11 ` [PATCH v6 6/9] ARM: omap: Consolidate OMAP3 " Robert Lee
2012-02-29  3:11 ` [PATCH v6 7/9] ARM: omap: Consolidate OMAP4 " Robert Lee
2012-02-29  3:11 ` Robert Lee [this message]
2012-02-29  3:11 ` [PATCH v6 9/9] SH: shmobile: Consolidate " Robert Lee
2012-02-29  9:40 ` [PATCH v6 0/9] Consolidate cpuidle functionality Jean Pihet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330485109-7327-9-git-send-email-rob.lee@linaro.org \
    --to=rob.lee@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).