* [PATCH] regulator mc13783: bail out without platform data
@ 2012-02-29 8:01 Sascha Hauer
2012-02-29 23:19 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2012-02-29 8:01 UTC (permalink / raw)
To: linux-arm-kernel
the platform data pointer is used without checking it. Bail out
in the driver instead of crashing the kernel.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/regulator/mc13783-regulator.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c
index 8e9b90a..6c0face 100644
--- a/drivers/regulator/mc13783-regulator.c
+++ b/drivers/regulator/mc13783-regulator.c
@@ -344,6 +344,9 @@ static int __devinit mc13783_regulator_probe(struct platform_device *pdev)
dev_dbg(&pdev->dev, "%s id %d\n", __func__, pdev->id);
+ if (!pdata)
+ return -EINVAL;
+
priv = devm_kzalloc(&pdev->dev, sizeof(*priv) +
pdata->num_regulators * sizeof(priv->regulators[0]),
GFP_KERNEL);
--
1.7.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] regulator mc13783: bail out without platform data
2012-02-29 8:01 [PATCH] regulator mc13783: bail out without platform data Sascha Hauer
@ 2012-02-29 23:19 ` Mark Brown
2012-03-01 9:58 ` Sascha Hauer
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2012-02-29 23:19 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Feb 29, 2012 at 09:01:40AM +0100, Sascha Hauer wrote:
> the platform data pointer is used without checking it. Bail out
> in the driver instead of crashing the kernel.
Applied, thanks. Ideally the platform data would just specify the
constraints and the driver would still be able to register the
regulators even without constriants being provided to allow diagnostics.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120229/42496cfb/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] regulator mc13783: bail out without platform data
2012-02-29 23:19 ` Mark Brown
@ 2012-03-01 9:58 ` Sascha Hauer
0 siblings, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2012-03-01 9:58 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Feb 29, 2012 at 11:19:51PM +0000, Mark Brown wrote:
> On Wed, Feb 29, 2012 at 09:01:40AM +0100, Sascha Hauer wrote:
> > the platform data pointer is used without checking it. Bail out
> > in the driver instead of crashing the kernel.
>
> Applied, thanks. Ideally the platform data would just specify the
> constraints and the driver would still be able to register the
> regulators even without constriants being provided to allow diagnostics.
Indeed. I can follow up on this when I find the time. For now I'm happy
with the kernel not crashing.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-01 9:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-29 8:01 [PATCH] regulator mc13783: bail out without platform data Sascha Hauer
2012-02-29 23:19 ` Mark Brown
2012-03-01 9:58 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).