linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tarun.kanti@ti.com (Tarun Kanti DebBarma)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/9] gpio/omap: get rid of retrigger variable in gpio_irq_handler
Date: Thu, 1 Mar 2012 04:14:25 +0530	[thread overview]
Message-ID: <1330555469-21260-6-git-send-email-tarun.kanti@ti.com> (raw)
In-Reply-To: <1330555469-21260-1-git-send-email-tarun.kanti@ti.com>

This local variable is just assigned zero and then OR'ed
with isr. It does not appear to serve any purpose and so
removing it.

Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
---
 drivers/gpio/gpio-omap.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 3765654..de5fe8f 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -626,7 +626,6 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
 	u32 isr;
 	unsigned int gpio_irq, gpio_index;
 	struct gpio_bank *bank;
-	u32 retrigger = 0;
 	int unmasked = 0;
 	struct irq_chip *chip = irq_desc_get_chip(desc);
 
@@ -663,8 +662,6 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
 			chained_irq_exit(chip, desc);
 		}
 
-		isr |= retrigger;
-		retrigger = 0;
 		if (!isr)
 			break;
 
-- 
1.7.0.4

  parent reply	other threads:[~2012-02-29 22:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 22:44 [PATCH v2 0/9] gpio/omap: Some more driver cleanup and fixes Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 1/9] gpio/omap: remove saved_fallingdetect, saved_risingdetect fields Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 2/9] gpio/omap: fix wakeup_en register update in _set_gpio_wakeup() Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 3/9] gpio/omap: remove suspend_wakeup field from struct gpio_bank Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 4/9] gpio/omap: remove saved_wakeup " Tarun Kanti DebBarma
2012-02-29 22:44 ` Tarun Kanti DebBarma [this message]
2012-02-29 22:44 ` [PATCH v2 6/9] gpio/omap: fix trigger type to unsigned Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 7/9] gpio/omap: fix _set_gpio_irqenable implementation Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 8/9] gpio/omap: remove redundant decoding of gpio offset Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 9/9] gpio/omap: remove suspend/resume callbacks Tarun Kanti DebBarma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330555469-21260-6-git-send-email-tarun.kanti@ti.com \
    --to=tarun.kanti@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).