From: tarun.kanti@ti.com (Tarun Kanti DebBarma)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/9] gpio/omap: fix _set_gpio_irqenable implementation
Date: Thu, 1 Mar 2012 04:14:27 +0530 [thread overview]
Message-ID: <1330555469-21260-8-git-send-email-tarun.kanti@ti.com> (raw)
In-Reply-To: <1330555469-21260-1-git-send-email-tarun.kanti@ti.com>
This function should be capable of both enabling and disabling interrupts
based upon the *enable* parameter. Right now the function only enables
the interrupt and *enable* is not used at all. So add the interrupt
disable capability also using the parameter.
Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
---
drivers/gpio/gpio-omap.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index bb994db..19f8f44 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -475,7 +475,10 @@ static void _disable_gpio_irqbank(struct gpio_bank *bank, int gpio_mask)
static inline void _set_gpio_irqenable(struct gpio_bank *bank, int gpio, int enable)
{
- _enable_gpio_irqbank(bank, GPIO_BIT(bank, gpio));
+ if (enable)
+ _enable_gpio_irqbank(bank, GPIO_BIT(bank, gpio));
+ else
+ _disable_gpio_irqbank(bank, GPIO_BIT(bank, gpio));
}
/*
--
1.7.0.4
next prev parent reply other threads:[~2012-02-29 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 22:44 [PATCH v2 0/9] gpio/omap: Some more driver cleanup and fixes Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 1/9] gpio/omap: remove saved_fallingdetect, saved_risingdetect fields Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 2/9] gpio/omap: fix wakeup_en register update in _set_gpio_wakeup() Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 3/9] gpio/omap: remove suspend_wakeup field from struct gpio_bank Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 4/9] gpio/omap: remove saved_wakeup " Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 5/9] gpio/omap: get rid of retrigger variable in gpio_irq_handler Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 6/9] gpio/omap: fix trigger type to unsigned Tarun Kanti DebBarma
2012-02-29 22:44 ` Tarun Kanti DebBarma [this message]
2012-02-29 22:44 ` [PATCH v2 8/9] gpio/omap: remove redundant decoding of gpio offset Tarun Kanti DebBarma
2012-02-29 22:44 ` [PATCH v2 9/9] gpio/omap: remove suspend/resume callbacks Tarun Kanti DebBarma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330555469-21260-8-git-send-email-tarun.kanti@ti.com \
--to=tarun.kanti@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).