[PATCH 0/4] ARM: SAMSUNG: Add __init attribute to functions calling s3c_set_platdata

[PATCH 0/4] ARM: SAMSUNG: Add __init attribute to functions calling s3c_set_platdata

[Tushar Behera]

The function s3c_set_platdata is defined with __init attribute, hence the
functions calling s3c_set_platdata should also be defined with __init
attribute.

Even though all the modified functions are called from xxx_machine_init()
functions, it is still better to define each of them with __init attribute.

Tushar Behera (4):
  ARM: EXYNOS: Add __init attribute to nuri_camera_init()
  ARM: EXYNOS: Add __init attribute to universal_camera_init()
  ARM: SAMSUNG: Add __init attribute to samsung_bl_set()
  ARM: SAMSUNG: Add __init attribute to xxx_set_platdata() wrappers

 arch/arm/mach-exynos/mach-nuri.c           |    2 +-
 arch/arm/mach-exynos/mach-universal_c210.c |    2 +-
 arch/arm/plat-samsung/dev-backlight.c      |    2 +-
 arch/arm/plat-samsung/devs.c               |    4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

-- 
1.7.4.1

[PATCH 1/4] ARM: EXYNOS: Add __init attribute to nuri_camera_init()

[Tushar Behera]

s3c_set_platdata() is defined with __init attribute, hence all functions
referencing this function should also be defined with __init attribute.

nuri_camera_init() is referenced only in '__init nuri_machine_init()', thus
this change won't put any additional constraint on the usage of
nuri_camera_init().

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 arch/arm/mach-exynos/mach-nuri.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c
index a6b9162..7dc5c99 100644
--- a/arch/arm/mach-exynos/mach-nuri.c
+++ b/arch/arm/mach-exynos/mach-nuri.c
@@ -1255,7 +1255,7 @@ static struct gpio nuri_camera_gpios[] = {
 	{ GPIO_CAM_MEGA_RST,	GPIOF_OUT_INIT_LOW, "CAM_8M_NRST" },
 };
 
-static void nuri_camera_init(void)
+static void __init nuri_camera_init(void)
 {
 	s3c_set_platdata(&mipi_csis_platdata, sizeof(mipi_csis_platdata),
 			 &s5p_device_mipi_csis0);
-- 
1.7.4.1

[PATCH 2/4] ARM: EXYNOS: Add __init attribute to universal_camera_init()

[Tushar Behera]

s3c_set_platdata() is defined with __init attribute, hence all functions
referencing this function should also be defined with __init attribute.

universal_camera_init() is referenced only in '__init universal_machine_init()',
thus this change won't put any additional constraint on the usage of
universal_camera_init().

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 arch/arm/mach-exynos/mach-universal_c210.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-exynos/mach-universal_c210.c b/arch/arm/mach-exynos/mach-universal_c210.c
index 6017a21..be50e5e 100644
--- a/arch/arm/mach-exynos/mach-universal_c210.c
+++ b/arch/arm/mach-exynos/mach-universal_c210.c
@@ -990,7 +990,7 @@ static struct gpio universal_camera_gpios[] = {
 	{ GPIO_CAM_VGA_NSTBY,	GPIOF_OUT_INIT_LOW,  "CAM_VGA_NSTBY" },
 };
 
-static void universal_camera_init(void)
+static void __init universal_camera_init(void)
 {
 	s3c_set_platdata(&mipi_csis_platdata, sizeof(mipi_csis_platdata),
 			 &s5p_device_mipi_csis0);
-- 
1.7.4.1

[PATCH 3/4] ARM: SAMSUNG: Add __init attribute to samsung_bl_set()

[Tushar Behera]

s3c_set_platdata() is defined with __init attribute, hence all functions
referencing this function should also be defined with __init attribute.

samsung_bl_set() is referenced only in '__init xxx_machine_init()' functions,
thus this change won't put any additional constraint on the usage of
samsung_bl_set().

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 arch/arm/plat-samsung/dev-backlight.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-samsung/dev-backlight.c b/arch/arm/plat-samsung/dev-backlight.c
index 2254920..5f197dc 100644
--- a/arch/arm/plat-samsung/dev-backlight.c
+++ b/arch/arm/plat-samsung/dev-backlight.c
@@ -77,7 +77,7 @@ static struct platform_device samsung_dfl_bl_device __initdata = {
  * @gpio_info:	structure containing GPIO info for PWM timer
  * @bl_data:	structure containing Backlight control data
  */
-void samsung_bl_set(struct samsung_bl_gpio_info *gpio_info,
+void __init samsung_bl_set(struct samsung_bl_gpio_info *gpio_info,
 	struct platform_pwm_backlight_data *bl_data)
 {
 	int ret = 0;
-- 
1.7.4.1

[PATCH 4/4] ARM: SAMSUNG: Add __init attribute to xxx_set_platdata() wrappers

[Tushar Behera]

s3c_set_platdata() is defined with __init attribute, hence all functions
referencing this function should also be defined with __init attribute.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 arch/arm/plat-samsung/devs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
index 75ff3b0..b7d4cdc 100644
--- a/arch/arm/plat-samsung/devs.c
+++ b/arch/arm/plat-samsung/devs.c
@@ -782,7 +782,7 @@ struct platform_device s3c_device_cfcon = {
 	.resource	= s3c_cfcon_resource,
 };
 
-void s3c_ide_set_platdata(struct s3c_ide_platdata *pdata)
+void __init s3c_ide_set_platdata(struct s3c_ide_platdata *pdata)
 {
 	s3c_set_platdata(pdata, sizeof(struct s3c_ide_platdata),
 			 &s3c_device_cfcon);
@@ -1062,7 +1062,7 @@ struct platform_device s3c64xx_device_onenand1 = {
 	.resource	= s3c64xx_onenand1_resources,
 };
 
-void s3c64xx_onenand1_set_platdata(struct onenand_platform_data *pdata)
+void __init s3c64xx_onenand1_set_platdata(struct onenand_platform_data *pdata)
 {
 	s3c_set_platdata(pdata, sizeof(struct onenand_platform_data),
 			 &s3c64xx_device_onenand1);
-- 
1.7.4.1

[PATCH 1/4] ARM: EXYNOS: Add __init attribute to nuri_camera_init()

[Sylwester Nawrocki]

On 03/01/2012 10:17 AM, Tushar Behera wrote:
> s3c_set_platdata() is defined with __init attribute, hence all functions
> referencing this function should also be defined with __init attribute.
> 
> nuri_camera_init() is referenced only in '__init nuri_machine_init()', thus
> this change won't put any additional constraint on the usage of
> nuri_camera_init().
> 
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>

Thanks.

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

[PATCH 2/4] ARM: EXYNOS: Add __init attribute to universal_camera_init()

[Sylwester Nawrocki]

On 03/01/2012 10:17 AM, Tushar Behera wrote:
> s3c_set_platdata() is defined with __init attribute, hence all functions
> referencing this function should also be defined with __init attribute.
> 
> universal_camera_init() is referenced only in '__init universal_machine_init()',
> thus this change won't put any additional constraint on the usage of
> universal_camera_init().
> 
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>

Thanks.

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

[PATCH 0/4] ARM: SAMSUNG: Add __init attribute to functions calling s3c_set_platdata

[Kukjin Kim]

On 03/01/12 01:17, Tushar Behera wrote:
> The function s3c_set_platdata is defined with __init attribute, hence the
> functions calling s3c_set_platdata should also be defined with __init
> attribute.
>
> Even though all the modified functions are called from xxx_machine_init()
> functions, it is still better to define each of them with __init attribute.
>
> Tushar Behera (4):
>    ARM: EXYNOS: Add __init attribute to nuri_camera_init()
>    ARM: EXYNOS: Add __init attribute to universal_camera_init()
>    ARM: SAMSUNG: Add __init attribute to samsung_bl_set()
>    ARM: SAMSUNG: Add __init attribute to xxx_set_platdata() wrappers
>
>   arch/arm/mach-exynos/mach-nuri.c           |    2 +-
>   arch/arm/mach-exynos/mach-universal_c210.c |    2 +-
>   arch/arm/plat-samsung/dev-backlight.c      |    2 +-
>   arch/arm/plat-samsung/devs.c               |    4 ++--
>   4 files changed, 5 insertions(+), 5 deletions(-)
>
Looks good to me, applied.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.