linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 4/4] ARM: OMAP3+: add prcm chain interrupts to the interrupt list
Date: Thu, 1 Mar 2012 12:03:55 +0200	[thread overview]
Message-ID: <1330596235.2116.81.camel@sokoban> (raw)
In-Reply-To: <20120301094653.GA7413@n2100.arm.linux.org.uk>

On Thu, 2012-03-01 at 09:46 +0000, Russell King - ARM Linux wrote:
> On Wed, Feb 29, 2012 at 05:25:06PM +0200, Tero Kristo wrote:
> > Currently PRCM chain handler for OMAP4 requires SPARSE_IRQ to be enabled
> > from kernel config, however enabling this option breaks the OMAP kernel
> > completely and it can't be used.
> 
> No it does not.  Look:
> 
> 	irq_alloc_descs(start, from, num, -1)
> 
> will allocate num interrupt descriptors from within from..NR_IRQS if
> sparse IRQ is disabled.  So, provided there is sufficient space within
> the available NR_IRQS, irq_alloc_descs() works for non-sparse IRQ.
> There is no need to get rid of it at all.
> 
> If start is -1, then it will allocate from where-ever it can in the
> range from..NR_IRQS.  Otherwise, it will fail if it can't get an
> allocation starting at 'start'.
> 
> If sparse IRQ is enabled, then it will start allocating from whatever
> the last figure output from the:
> 
> 	NR_IRQS:%d nr_irqs:%d %d
> 
> line.

With the patch from Benoit
(http://marc.info/?l=linux-arm-kernel&m=133043468329275&w=2) this patch
is no longer needed. Previously the NR_IRQS definition was too small for
omap4 and the alloc_descs was failing because of that. It seems I
overshoot with this patch of mine and dropped also the irq_alloc_desc
implementation while fixing the problem.

-Tero

  reply	other threads:[~2012-03-01 10:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 15:25 [PATCHv3 0/4] ARM: OMAP4: core retention support Tero Kristo
2012-02-29 15:25 ` [PATCHv3 1/4] ARM: OMAP4: suspend: Program all domains to retention Tero Kristo
2012-03-06  0:33   ` Kevin Hilman
2012-03-06  8:31     ` Tero Kristo
2012-03-06  8:43       ` Rajendra Nayak
2012-03-06  8:54         ` Tero Kristo
2012-03-06  8:59           ` Rajendra Nayak
2012-03-06  9:23             ` Tero Kristo
2012-02-29 15:25 ` [PATCHv3 2/4] ARM: OMAP4: prm: fix interrupt register offsets Tero Kristo
2012-02-29 16:51   ` Paul Walmsley
2012-02-29 15:25 ` [PATCHv3 3/4] TEMP: ARM: OMAP4: hwmod_data: Do not get DSP out of reset at boot time Tero Kristo
2012-02-29 15:25 ` [PATCHv3 4/4] ARM: OMAP3+: add prcm chain interrupts to the interrupt list Tero Kristo
2012-03-01  7:01   ` Rajendra Nayak
2012-03-01  8:23     ` Tero Kristo
2012-03-01  9:46   ` Russell King - ARM Linux
2012-03-01 10:03     ` Tero Kristo [this message]
2012-02-29 15:34 ` [PATCHv3 0/4] ARM: OMAP4: core retention support Shilimkar, Santosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330596235.2116.81.camel@sokoban \
    --to=t-kristo@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).