linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: versatile-pb/ab fix MMC IRQs
@ 2012-03-02 10:07 Linus Walleij
  2012-03-18 23:57 ` Linus Walleij
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2012-03-02 10:07 UTC (permalink / raw)
  To: linux-arm-kernel

The MMCI driver will not work without two IRQs since this is not
flagged as a single-irq variant. Looking through the complex IRQ
definition for the MMCI on the versatile (including an #if 1
statement forcing MMCI IRQ0 to the VIC) this appears to the the
correct IRQ number for both models.

Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Niklas Hernaeus <niklas.hernaeus@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/boot/dts/versatile-ab.dts |    2 +-
 arch/arm/boot/dts/versatile-pb.dts |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/versatile-ab.dts b/arch/arm/boot/dts/versatile-ab.dts
index 0b32925..e2fe319 100644
--- a/arch/arm/boot/dts/versatile-ab.dts
+++ b/arch/arm/boot/dts/versatile-ab.dts
@@ -173,7 +173,7 @@
 			mmc at 5000 {
 				compatible = "arm,primecell";
 				reg = < 0x5000 0x1000>;
-				interrupts = <22>;
+				interrupts = <22 34>;
 			};
 			kmi at 6000 {
 				compatible = "arm,pl050", "arm,primecell";
diff --git a/arch/arm/boot/dts/versatile-pb.dts b/arch/arm/boot/dts/versatile-pb.dts
index 1664610..7e81752 100644
--- a/arch/arm/boot/dts/versatile-pb.dts
+++ b/arch/arm/boot/dts/versatile-pb.dts
@@ -41,7 +41,7 @@
 			mmc at b000 {
 				compatible = "arm,primecell";
 				reg = <0xb000 0x1000>;
-				interrupts = <23>;
+				interrupts = <23 34>;
 			};
 		};
 	};
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 1/2] ARM: dts: versatile-pb/ab fix MMC IRQs
  2012-03-02 10:07 [PATCH 1/2] ARM: dts: versatile-pb/ab fix MMC IRQs Linus Walleij
@ 2012-03-18 23:57 ` Linus Walleij
  2012-04-18 12:23   ` Linus Walleij
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2012-03-18 23:57 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Mar 2, 2012 at 11:07 AM, Linus Walleij <linus.walleij@linaro.org> wrote:

> The MMCI driver will not work without two IRQs since this is not
> flagged as a single-irq variant. Looking through the complex IRQ
> definition for the MMCI on the versatile (including an #if 1
> statement forcing MMCI IRQ0 to the VIC) this appears to the the
> correct IRQ number for both models.
>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Niklas Hernaeus <niklas.hernaeus@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Ping on this and 2/2, could go in as fixes as well.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] ARM: dts: versatile-pb/ab fix MMC IRQs
  2012-03-18 23:57 ` Linus Walleij
@ 2012-04-18 12:23   ` Linus Walleij
  0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2012-04-18 12:23 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Mar 19, 2012 at 12:57 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Fri, Mar 2, 2012 at 11:07 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>
>> The MMCI driver will not work without two IRQs since this is not
>> flagged as a single-irq variant. Looking through the complex IRQ
>> definition for the MMCI on the versatile (including an #if 1
>> statement forcing MMCI IRQ0 to the VIC) this appears to the the
>> correct IRQ number for both models.
>>
>> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
>> Cc: Niklas Hernaeus <niklas.hernaeus@linaro.org>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Ping on this and 2/2, could go in as fixes as well.

Ping on these two, I'll happily put them in Russell's patch tracker if
not suitable for DT git.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-18 12:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-02 10:07 [PATCH 1/2] ARM: dts: versatile-pb/ab fix MMC IRQs Linus Walleij
2012-03-18 23:57 ` Linus Walleij
2012-04-18 12:23   ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).