From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 15/20] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX
Date: Sat, 3 Mar 2012 23:19:56 +0800 [thread overview]
Message-ID: <1330788001-10158-16-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <1330788001-10158-1-git-send-email-shawn.guo@linaro.org>
Provide different pair of accessors for accessing SSI registers on
PowerPC and ARM/IMX, so that fsl_ssi driver can be built on both
architectures.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
sound/soc/fsl/fsl_ssi.c | 83 ++++++++++++++++++++++++++++++----------------
1 files changed, 54 insertions(+), 29 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 2eb407f..0b53682 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -11,11 +11,14 @@
*/
#include <linux/init.h>
+#include <linux/io.h>
#include <linux/module.h>
#include <linux/interrupt.h>
#include <linux/device.h>
#include <linux/delay.h>
#include <linux/slab.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <sound/core.h>
@@ -26,6 +29,14 @@
#include "fsl_ssi.h"
+#ifdef PPC
+#define read_ssi(addr) in_be32(addr)
+#define write_ssi(val, addr) out_be32(addr, val)
+#elif defined ARM
+#define read_ssi(addr) readl(addr)
+#define write_ssi(val, addr) writel(val, addr)
+#endif
+
/**
* FSLSSI_I2S_RATES: sample rates supported by the I2S
*
@@ -145,7 +156,7 @@ static irqreturn_t fsl_ssi_isr(int irq, void *dev_id)
were interrupted for. We mask it with the Interrupt Enable register
so that we only check for events that we're interested in.
*/
- sisr = in_be32(&ssi->sisr) & SIER_FLAGS;
+ sisr = read_ssi(&ssi->sisr) & SIER_FLAGS;
if (sisr & CCSR_SSI_SISR_RFRC) {
ssi_private->stats.rfrc++;
@@ -260,7 +271,7 @@ static irqreturn_t fsl_ssi_isr(int irq, void *dev_id)
/* Clear the bits that we set */
if (sisr2)
- out_be32(&ssi->sisr, sisr2);
+ write_ssi(sisr2, &ssi->sisr);
return ret;
}
@@ -280,6 +291,7 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream,
struct fsl_ssi_private *ssi_private =
snd_soc_dai_get_drvdata(rtd->cpu_dai);
int synchronous = ssi_private->cpu_dai_drv.symmetric_rates;
+ u32 val;
/*
* If this is the first stream opened, then request the IRQ
@@ -295,7 +307,9 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream,
* SSI needs to be disabled before updating the registers we set
* here.
*/
- clrbits32(&ssi->scr, CCSR_SSI_SCR_SSIEN);
+ val = read_ssi(&ssi->scr);
+ val &= ~CCSR_SSI_SCR_SSIEN;
+ write_ssi(val, &ssi->scr);
/*
* Program the SSI into I2S Slave Non-Network Synchronous mode.
@@ -303,20 +317,19 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream,
*
* FIXME: Little-endian samples require a different shift dir
*/
- clrsetbits_be32(&ssi->scr,
- CCSR_SSI_SCR_I2S_MODE_MASK | CCSR_SSI_SCR_SYN,
- CCSR_SSI_SCR_TFR_CLK_DIS | CCSR_SSI_SCR_I2S_MODE_SLAVE
- | (synchronous ? CCSR_SSI_SCR_SYN : 0));
+ val = read_ssi(&ssi->scr);
+ val &= ~(CCSR_SSI_SCR_I2S_MODE_MASK | CCSR_SSI_SCR_SYN);
+ val |= CCSR_SSI_SCR_TFR_CLK_DIS | CCSR_SSI_SCR_I2S_MODE_SLAVE |
+ (synchronous ? CCSR_SSI_SCR_SYN : 0);
+ write_ssi(val, &ssi->scr);
- out_be32(&ssi->stcr,
- CCSR_SSI_STCR_TXBIT0 | CCSR_SSI_STCR_TFEN0 |
+ write_ssi(CCSR_SSI_STCR_TXBIT0 | CCSR_SSI_STCR_TFEN0 |
CCSR_SSI_STCR_TFSI | CCSR_SSI_STCR_TEFS |
- CCSR_SSI_STCR_TSCKP);
+ CCSR_SSI_STCR_TSCKP, &ssi->stcr);
- out_be32(&ssi->srcr,
- CCSR_SSI_SRCR_RXBIT0 | CCSR_SSI_SRCR_RFEN0 |
+ write_ssi(CCSR_SSI_SRCR_RXBIT0 | CCSR_SSI_SRCR_RFEN0 |
CCSR_SSI_SRCR_RFSI | CCSR_SSI_SRCR_REFS |
- CCSR_SSI_SRCR_RSCKP);
+ CCSR_SSI_SRCR_RSCKP, &ssi->srcr);
/*
* The DC and PM bits are only used if the SSI is the clock
@@ -324,7 +337,7 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream,
*/
/* Enable the interrupts and DMA requests */
- out_be32(&ssi->sier, SIER_FLAGS);
+ write_ssi(SIER_FLAGS, &ssi->sier);
/*
* Set the watermark for transmit FIFI 0 and receive FIFO 0. We
@@ -339,9 +352,9 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream,
* make this value larger (and maybe we should), but this way
* data will be written to memory as soon as it's available.
*/
- out_be32(&ssi->sfcsr,
- CCSR_SSI_SFCSR_TFWM0(ssi_private->fifo_depth - 2) |
- CCSR_SSI_SFCSR_RFWM0(ssi_private->fifo_depth - 2));
+ write_ssi(CCSR_SSI_SFCSR_TFWM0(ssi_private->fifo_depth - 2) |
+ CCSR_SSI_SFCSR_RFWM0(ssi_private->fifo_depth - 2),
+ &ssi->sfcsr);
/*
* We keep the SSI disabled because if we enable it, then the
@@ -417,7 +430,8 @@ static int fsl_ssi_hw_params(struct snd_pcm_substream *substream,
unsigned int sample_size =
snd_pcm_format_width(params_format(hw_params));
u32 wl = CCSR_SSI_SxCCR_WL(sample_size);
- int enabled = in_be32(&ssi->scr) & CCSR_SSI_SCR_SSIEN;
+ int enabled = read_ssi(&ssi->scr) & CCSR_SSI_SCR_SSIEN;
+ u32 val;
/*
* If we're in synchronous mode, and the SSI is already enabled,
@@ -438,10 +452,17 @@ static int fsl_ssi_hw_params(struct snd_pcm_substream *substream,
/* In synchronous mode, the SSI uses STCCR for capture */
if ((substream->stream == SNDRV_PCM_STREAM_PLAYBACK) ||
- ssi_private->cpu_dai_drv.symmetric_rates)
- clrsetbits_be32(&ssi->stccr, CCSR_SSI_SxCCR_WL_MASK, wl);
- else
- clrsetbits_be32(&ssi->srccr, CCSR_SSI_SxCCR_WL_MASK, wl);
+ ssi_private->cpu_dai_drv.symmetric_rates) {
+ val = read_ssi(&ssi->stccr);
+ val &= CCSR_SSI_SxCCR_WL_MASK;
+ val |= wl;
+ write_ssi(val, &ssi->stccr);
+ } else {
+ val = read_ssi(&ssi->srccr);
+ val &= CCSR_SSI_SxCCR_WL_MASK;
+ val |= wl;
+ write_ssi(val, &ssi->srccr);
+ }
return 0;
}
@@ -461,29 +482,30 @@ static int fsl_ssi_trigger(struct snd_pcm_substream *substream, int cmd,
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct fsl_ssi_private *ssi_private = snd_soc_dai_get_drvdata(rtd->cpu_dai);
struct ccsr_ssi __iomem *ssi = ssi_private->ssi;
+ u32 val;
+ val = read_ssi(&ssi->scr);
switch (cmd) {
case SNDRV_PCM_TRIGGER_START:
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
- setbits32(&ssi->scr,
- CCSR_SSI_SCR_SSIEN | CCSR_SSI_SCR_TE);
+ val |= CCSR_SSI_SCR_SSIEN | CCSR_SSI_SCR_TE;
else
- setbits32(&ssi->scr,
- CCSR_SSI_SCR_SSIEN | CCSR_SSI_SCR_RE);
+ val |= CCSR_SSI_SCR_SSIEN | CCSR_SSI_SCR_RE;
break;
case SNDRV_PCM_TRIGGER_STOP:
case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
- clrbits32(&ssi->scr, CCSR_SSI_SCR_TE);
+ val &= ~CCSR_SSI_SCR_TE;
else
- clrbits32(&ssi->scr, CCSR_SSI_SCR_RE);
+ val &= ~CCSR_SSI_SCR_RE;
break;
default:
return -EINVAL;
}
+ write_ssi(val, &ssi->scr);
return 0;
}
@@ -498,6 +520,7 @@ static void fsl_ssi_shutdown(struct snd_pcm_substream *substream,
{
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct fsl_ssi_private *ssi_private = snd_soc_dai_get_drvdata(rtd->cpu_dai);
+ u32 val;
if (ssi_private->first_stream == substream)
ssi_private->first_stream = ssi_private->second_stream;
@@ -510,7 +533,9 @@ static void fsl_ssi_shutdown(struct snd_pcm_substream *substream,
if (!ssi_private->first_stream) {
struct ccsr_ssi __iomem *ssi = ssi_private->ssi;
- clrbits32(&ssi->scr, CCSR_SSI_SCR_SSIEN);
+ val = read_ssi(&ssi->scr);
+ val &= ~CCSR_SSI_SCR_SSIEN;
+ write_ssi(val, &ssi->scr);
}
}
--
1.7.5.4
next prev parent reply other threads:[~2012-03-03 15:19 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 15:19 [PATCH 00/20] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Shawn Guo
2012-03-03 15:19 ` [PATCH 01/20] ASoC: imx: move eukrea audmux call into ASoC machine driver Shawn Guo
2012-03-03 15:19 ` [PATCH 02/20] ASoC: imx: move phycore " Shawn Guo
2012-03-03 15:19 ` [PATCH 03/20] ARM: imx: merge audmux-v1 and audmux-v2 Shawn Guo
2012-03-05 0:22 ` Tabi Timur-B04825
2012-03-05 7:33 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 04/20] ARM: imx: convert audmux to a platform driver Shawn Guo
2012-03-04 19:00 ` Sascha Hauer
2012-03-05 7:35 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 05/20] ASoC: imx: move audmux driver into sound/soc/imx Shawn Guo
2012-03-03 15:19 ` [PATCH 06/20] ASoC: imx: rename audmux prefix mxc to imx Shawn Guo
2012-03-03 15:19 ` [PATCH 07/20] ASoC: imx: move SND_SOC_AC97_BUS selection down to machine driver Shawn Guo
2012-03-04 13:34 ` Mark Brown
2012-03-03 15:19 ` [PATCH 08/20] ASoC: imx: initialize dma_params burstsize just in imx-ssi Shawn Guo
2012-03-04 13:26 ` Mark Brown
2012-03-03 15:19 ` [PATCH 09/20] ASoC: imx: separate imx-pcm bits from imx-ssi driver Shawn Guo
2012-03-04 13:41 ` Mark Brown
2012-03-03 15:19 ` [PATCH 10/20] ASoC: imx: add an explicit Kconfig option for " Shawn Guo
2012-03-03 15:19 ` [PATCH 11/20] ASoC: fsl: separate SSI and DMA Kconfig options Shawn Guo
2012-03-03 15:19 ` [PATCH 12/20] ASoC: imx: merge sound/soc/imx into sound/soc/fsl Shawn Guo
2012-03-03 15:19 ` [PATCH 13/20] ASoC: fsl: create fsl_utils to accommodate the common functions Shawn Guo
2012-03-03 15:19 ` [PATCH 14/20] ASoC: fsl: check property 'compatible' for the machine name Shawn Guo
2012-03-03 15:19 ` Shawn Guo [this message]
2012-03-04 23:13 ` [PATCH 15/20] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX Tabi Timur-B04825
2012-03-04 23:28 ` Russell King - ARM Linux
2012-03-04 23:32 ` Tabi Timur-B04825
2012-03-05 0:04 ` Russell King - ARM Linux
2012-03-05 0:13 ` Tabi Timur-B04825
2012-03-05 0:26 ` Mark Brown
2012-03-06 10:40 ` Russell King - ARM Linux
2012-03-06 12:06 ` Mark Brown
2012-03-06 12:25 ` Russell King - ARM Linux
2012-03-06 12:33 ` Mark Brown
2012-03-06 13:02 ` Tabi Timur-B04825
2012-03-06 13:03 ` Mark Brown
2012-03-06 13:26 ` [alsa-devel] " Takashi Iwai
2012-03-06 13:38 ` Mark Brown
2012-03-06 13:46 ` Takashi Iwai
2012-03-06 13:52 ` Russell King - ARM Linux
2012-03-06 16:54 ` Mark Brown
2012-03-06 13:46 ` Russell King - ARM Linux
2012-03-06 10:39 ` Russell King - ARM Linux
2012-03-05 7:39 ` Shawn Guo
2012-03-05 12:28 ` Tabi Timur-B04825
2012-03-05 13:40 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 16/20] ASoC: fsl: remove the fatal error checking on codec-handle Shawn Guo
2012-03-03 15:19 ` [PATCH 17/20] ASoC: fsl: let fsl_ssi work with imx pcm and machine drivers Shawn Guo
2012-03-03 15:19 ` [PATCH 18/20] ASoC: fsl: add dt support for imx-audmux Shawn Guo
2012-03-03 15:20 ` [PATCH 19/20] ASoC: rename sgtl5000 device tree binding document Shawn Guo
2012-03-04 13:39 ` Mark Brown
2012-03-03 15:20 ` [PATCH 20/20] ASoC: fsl: add imx-sgtl5000 machine driver Shawn Guo
2012-03-04 13:38 ` Mark Brown
2012-03-05 8:06 ` Shawn Guo
2012-03-05 11:56 ` Mark Brown
2012-03-05 13:07 ` Shawn Guo
2012-03-05 13:13 ` Mark Brown
2012-03-05 16:55 ` [alsa-devel] " Stephen Warren
2012-03-05 17:03 ` Mark Brown
2012-03-06 18:19 ` Stephen Warren
2012-03-06 20:11 ` Mark Brown
2012-03-05 16:58 ` Timur Tabi
2012-03-05 17:32 ` Mark Brown
2012-03-04 23:34 ` Tabi Timur-B04825
2012-03-05 8:07 ` Shawn Guo
2012-03-04 13:32 ` [PATCH 00/20] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330788001-10158-16-git-send-email-shawn.guo@linaro.org \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).