From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 10/11] ASoC: fsl: let fsl_ssi work with imx pcm and machine drivers
Date: Fri, 9 Mar 2012 00:59:49 +0800 [thread overview]
Message-ID: <1331225990-27308-11-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <1331225990-27308-1-git-send-email-shawn.guo@linaro.org>
Makes necessary changes on fsl_ssi to let it work with imx pcm and
machine drivers.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
sound/soc/fsl/fsl_ssi.c | 67 +++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 67 insertions(+), 0 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index e5903cb..c251ee9 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -29,6 +29,7 @@
#include <sound/soc.h>
#include "fsl_ssi.h"
+#include "imx-pcm.h"
#ifdef PPC
#define read_ssi(addr) in_be32(addr)
@@ -119,6 +120,11 @@ struct fsl_ssi_private {
struct device_attribute dev_attr;
struct platform_device *pdev;
+ int ssi_on_imx;
+ struct platform_device *imx_pcm_pdev;
+ struct imx_pcm_dma_params dma_params_tx;
+ struct imx_pcm_dma_params dma_params_rx;
+
struct {
unsigned int rfrc;
unsigned int tfrc;
@@ -416,6 +422,12 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream,
ssi_private->second_stream = substream;
}
+ if (ssi_private->ssi_on_imx)
+ snd_soc_dai_set_dma_data(dai, substream,
+ (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) ?
+ &ssi_private->dma_params_tx :
+ &ssi_private->dma_params_rx);
+
return 0;
}
@@ -709,6 +721,38 @@ static int __devinit fsl_ssi_probe(struct platform_device *pdev)
/* Older 8610 DTs didn't have the fifo-depth property */
ssi_private->fifo_depth = 8;
+ if (of_device_is_compatible(pdev->dev.of_node, "fsl,imx1-ssi")) {
+ u32 dma_events[2];
+ ssi_private->ssi_on_imx = 1;
+ /*
+ * FIXME: The dma burst size must equal to ssi watermark
+ * setting on imx. We have burstsize be "fifo_depth - 2"
+ * here because "fifo_depth - 2" rather than fifo_depth is
+ * being written into watermark register in fsl_ssi_startup().
+ * Is this something needs to be fixed for PowerPC?
+ */
+ ssi_private->dma_params_tx.burstsize =
+ ssi_private->fifo_depth - 2;
+ ssi_private->dma_params_rx.burstsize =
+ ssi_private->fifo_depth - 2;
+ ssi_private->dma_params_tx.dma_addr =
+ ssi_private->ssi_phys + offsetof(struct ccsr_ssi, stx0);
+ ssi_private->dma_params_rx.dma_addr =
+ ssi_private->ssi_phys + offsetof(struct ccsr_ssi, srx0);
+ /*
+ * TODO: This is a temporary solution and should be changed
+ * to use generic DMA binding later when the helplers get in.
+ */
+ ret = of_property_read_u32_array(pdev->dev.of_node,
+ "fsl,ssi-dma-events", dma_events, 2);
+ if (ret) {
+ dev_err(&pdev->dev, "could not get dma events\n");
+ goto error_irq;
+ }
+ ssi_private->dma_params_tx.dma = dma_events[0];
+ ssi_private->dma_params_rx.dma = dma_events[1];
+ }
+
/* Initialize the the device_attribute structure */
dev_attr = &ssi_private->dev_attr;
sysfs_attr_init(&dev_attr->attr);
@@ -732,6 +776,24 @@ static int __devinit fsl_ssi_probe(struct platform_device *pdev)
goto error_dev;
}
+ /*
+ * In case of imx, the machine driver uses new binding which does
+ * not require SSI driver to trigger machine driver's probe, but
+ * the pcm device needs to be registered here.
+ */
+ if (ssi_private->ssi_on_imx) {
+ ssi_private->imx_pcm_pdev =
+ platform_device_register_simple("imx-pcm-audio",
+ -1, NULL, 0);
+ if (IS_ERR(ssi_private->imx_pcm_pdev)) {
+ ret = PTR_ERR(ssi_private->imx_pcm_pdev);
+ goto error_dev;
+ } else {
+ /* success for imx */
+ return 0;
+ }
+ }
+
/* Trigger the machine driver's probe function. The platform driver
* name of the machine driver is taken from /compatible property of the
* device tree. We also pass the address of the CPU DAI driver
@@ -757,6 +819,8 @@ static int __devinit fsl_ssi_probe(struct platform_device *pdev)
error_dai:
snd_soc_unregister_dai(&pdev->dev);
+ if (ssi_private->ssi_on_imx)
+ platform_device_unregister(ssi_private->imx_pcm_pdev);
error_dev:
dev_set_drvdata(&pdev->dev, NULL);
@@ -783,6 +847,8 @@ static int fsl_ssi_remove(struct platform_device *pdev)
platform_device_unregister(ssi_private->pdev);
snd_soc_unregister_dai(&pdev->dev);
+ if (ssi_private->ssi_on_imx)
+ platform_device_unregister(ssi_private->imx_pcm_pdev);
device_remove_file(&pdev->dev, &ssi_private->dev_attr);
free_irq(ssi_private->irq, ssi_private);
@@ -796,6 +862,7 @@ static int fsl_ssi_remove(struct platform_device *pdev)
static const struct of_device_id fsl_ssi_ids[] = {
{ .compatible = "fsl,mpc8610-ssi", },
+ { .compatible = "fsl,imx1-ssi", },
{}
};
MODULE_DEVICE_TABLE(of, fsl_ssi_ids);
--
1.7.5.4
next prev parent reply other threads:[~2012-03-08 16:59 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 16:59 [PATCH v3 00/11] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Shawn Guo
2012-03-08 16:59 ` [PATCH v3 01/11] ASoC: core: missing set_fmt should not be complaint Shawn Guo
2012-03-08 18:24 ` Mark Brown
2012-03-08 16:59 ` [PATCH v3 02/11] ASoC: fsl: separate SSI and DMA Kconfig options Shawn Guo
2012-03-08 16:59 ` [PATCH v3 03/11] ASoC: imx: merge sound/soc/imx into sound/soc/fsl Shawn Guo
2012-03-08 16:59 ` [PATCH v3 04/11] ASoC: fsl: rename imx-pcm Kconfig options and filename Shawn Guo
2012-03-08 16:59 ` [PATCH v3 05/11] ASoC: fsl: create fsl_utils to accommodate the common functions Shawn Guo
2012-03-08 16:59 ` [PATCH v3 06/11] ASoC: fsl: remove helper fsl_asoc_get_codec_dev_name Shawn Guo
2012-03-08 16:59 ` [PATCH v3 07/11] ASoC: fsl: check property 'compatible' for the machine name Shawn Guo
2012-03-08 20:50 ` Timur Tabi
2012-03-09 11:51 ` Mark Brown
2012-03-08 16:59 ` [PATCH v3 08/11] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX Shawn Guo
2012-03-08 20:13 ` Timur Tabi
2012-03-09 1:26 ` Shawn Guo
2012-03-09 2:09 ` Tabi Timur-B04825
2012-03-09 3:21 ` Shawn Guo
2012-03-09 4:03 ` Tabi Timur-B04825
2012-03-09 11:53 ` Mark Brown
2012-03-08 16:59 ` [PATCH v3 09/11] ASoC: fsl: remove the fatal error checking on codec-handle Shawn Guo
2012-03-08 20:50 ` Timur Tabi
2012-03-09 1:32 ` Shawn Guo
2012-03-13 23:23 ` Timur Tabi
2012-03-13 23:46 ` Mark Brown
2012-03-14 2:57 ` Tabi Timur-B04825
2012-03-14 12:27 ` Mark Brown
2012-03-14 23:00 ` Timur Tabi
2012-03-15 13:02 ` Shawn Guo
2012-03-15 13:37 ` Tabi Timur-B04825
2012-03-15 14:21 ` Shawn Guo
2012-03-15 15:39 ` [alsa-devel] " Trent Piepho
2012-03-15 15:57 ` Trent Piepho
2012-03-15 16:24 ` Mark Brown
2012-03-15 16:47 ` Timur Tabi
2012-03-16 1:27 ` Shawn Guo
2012-03-16 1:55 ` Tabi Timur-B04825
2012-03-17 21:42 ` Mark Brown
2012-03-15 14:27 ` Mark Brown
2012-03-15 14:34 ` Shawn Guo
2012-03-15 16:44 ` Timur Tabi
2012-03-15 17:11 ` Mark Brown
2012-03-16 2:01 ` Shawn Guo
2012-03-16 2:07 ` Tabi Timur-B04825
2012-03-16 2:23 ` Shawn Guo
2012-03-16 3:44 ` Tabi Timur-B04825
2012-03-16 3:53 ` Shawn Guo
2012-03-16 4:08 ` Tabi Timur-B04825
2012-03-16 4:14 ` Shawn Guo
2012-03-16 4:17 ` Tabi Timur-B04825
2012-03-16 2:52 ` Shawn Guo
2012-03-16 3:53 ` Tabi Timur-B04825
2012-03-16 4:05 ` Shawn Guo
2012-03-16 19:18 ` Mark Brown
2012-03-09 11:55 ` Mark Brown
2012-03-08 16:59 ` Shawn Guo [this message]
2012-03-08 19:15 ` [PATCH v3 10/11] ASoC: fsl: let fsl_ssi work with imx pcm and machine drivers Sascha Hauer
2012-03-09 1:51 ` Shawn Guo
2012-03-08 20:45 ` Timur Tabi
2012-03-09 3:19 ` Shawn Guo
2012-03-09 4:02 ` Tabi Timur-B04825
2012-03-09 5:00 ` Shawn Guo
2012-03-08 16:59 ` [PATCH v3 11/11] ASoC: fsl: add imx-sgtl5000 machine driver Shawn Guo
2012-03-08 20:05 ` [PATCH v3 00/11] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Timur Tabi
2012-03-09 1:19 ` Shawn Guo
2012-03-09 2:11 ` Tabi Timur-B04825
2012-03-09 7:13 ` Shawn Guo
2012-03-09 7:28 ` Shawn Guo
2012-03-09 12:12 ` Mark Brown
2012-03-09 11:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331225990-27308-11-git-send-email-shawn.guo@linaro.org \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).