linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/11] ASoC: core: missing set_fmt should not be complaint
Date: Fri,  9 Mar 2012 00:59:40 +0800	[thread overview]
Message-ID: <1331225990-27308-2-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <1331225990-27308-1-git-send-email-shawn.guo@linaro.org>

Not having a DAI link set_fmt operation is perfectly normal and
should not be complaint.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 sound/soc/soc-core.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 7978f6c..98b2635 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1531,14 +1531,14 @@ static void snd_soc_instantiate_card(struct snd_soc_card *card)
 		if (dai_link->dai_fmt) {
 			ret = snd_soc_dai_set_fmt(card->rtd[i].codec_dai,
 						  dai_link->dai_fmt);
-			if (ret != 0)
+			if (ret != 0 && ret != -ENOTSUPP)
 				dev_warn(card->rtd[i].codec_dai->dev,
 					 "Failed to set DAI format: %d\n",
 					 ret);
 
 			ret = snd_soc_dai_set_fmt(card->rtd[i].cpu_dai,
 						  dai_link->dai_fmt);
-			if (ret != 0)
+			if (ret != 0 && ret != -ENOTSUPP)
 				dev_warn(card->rtd[i].cpu_dai->dev,
 					 "Failed to set DAI format: %d\n",
 					 ret);
@@ -2971,10 +2971,11 @@ EXPORT_SYMBOL_GPL(snd_soc_codec_set_pll);
  */
 int snd_soc_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 {
-	if (dai->driver && dai->driver->ops->set_fmt)
-		return dai->driver->ops->set_fmt(dai, fmt);
-	else
+	if (dai->driver == NULL)
 		return -EINVAL;
+	if (dai->driver->ops->set_fmt == NULL)
+		return -ENOTSUPP;
+	return dai->driver->ops->set_fmt(dai, fmt);
 }
 EXPORT_SYMBOL_GPL(snd_soc_dai_set_fmt);
 
-- 
1.7.5.4

  reply	other threads:[~2012-03-08 16:59 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 16:59 [PATCH v3 00/11] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Shawn Guo
2012-03-08 16:59 ` Shawn Guo [this message]
2012-03-08 18:24   ` [PATCH v3 01/11] ASoC: core: missing set_fmt should not be complaint Mark Brown
2012-03-08 16:59 ` [PATCH v3 02/11] ASoC: fsl: separate SSI and DMA Kconfig options Shawn Guo
2012-03-08 16:59 ` [PATCH v3 03/11] ASoC: imx: merge sound/soc/imx into sound/soc/fsl Shawn Guo
2012-03-08 16:59 ` [PATCH v3 04/11] ASoC: fsl: rename imx-pcm Kconfig options and filename Shawn Guo
2012-03-08 16:59 ` [PATCH v3 05/11] ASoC: fsl: create fsl_utils to accommodate the common functions Shawn Guo
2012-03-08 16:59 ` [PATCH v3 06/11] ASoC: fsl: remove helper fsl_asoc_get_codec_dev_name Shawn Guo
2012-03-08 16:59 ` [PATCH v3 07/11] ASoC: fsl: check property 'compatible' for the machine name Shawn Guo
2012-03-08 20:50   ` Timur Tabi
2012-03-09 11:51   ` Mark Brown
2012-03-08 16:59 ` [PATCH v3 08/11] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX Shawn Guo
2012-03-08 20:13   ` Timur Tabi
2012-03-09  1:26     ` Shawn Guo
2012-03-09  2:09       ` Tabi Timur-B04825
2012-03-09  3:21         ` Shawn Guo
2012-03-09  4:03           ` Tabi Timur-B04825
2012-03-09 11:53           ` Mark Brown
2012-03-08 16:59 ` [PATCH v3 09/11] ASoC: fsl: remove the fatal error checking on codec-handle Shawn Guo
2012-03-08 20:50   ` Timur Tabi
2012-03-09  1:32     ` Shawn Guo
2012-03-13 23:23       ` Timur Tabi
2012-03-13 23:46         ` Mark Brown
2012-03-14  2:57           ` Tabi Timur-B04825
2012-03-14 12:27             ` Mark Brown
2012-03-14 23:00               ` Timur Tabi
2012-03-15 13:02                 ` Shawn Guo
2012-03-15 13:37                   ` Tabi Timur-B04825
2012-03-15 14:21                     ` Shawn Guo
2012-03-15 15:39                       ` [alsa-devel] " Trent Piepho
2012-03-15 15:57                         ` Trent Piepho
2012-03-15 16:24                           ` Mark Brown
2012-03-15 16:47                       ` Timur Tabi
2012-03-16  1:27                         ` Shawn Guo
2012-03-16  1:55                           ` Tabi Timur-B04825
2012-03-17 21:42                             ` Mark Brown
2012-03-15 14:27                 ` Mark Brown
2012-03-15 14:34                   ` Shawn Guo
2012-03-15 16:44                   ` Timur Tabi
2012-03-15 17:11                     ` Mark Brown
2012-03-16  2:01                     ` Shawn Guo
2012-03-16  2:07                       ` Tabi Timur-B04825
2012-03-16  2:23                         ` Shawn Guo
2012-03-16  3:44                           ` Tabi Timur-B04825
2012-03-16  3:53                             ` Shawn Guo
2012-03-16  4:08                               ` Tabi Timur-B04825
2012-03-16  4:14                                 ` Shawn Guo
2012-03-16  4:17                                   ` Tabi Timur-B04825
2012-03-16  2:52                         ` Shawn Guo
2012-03-16  3:53                           ` Tabi Timur-B04825
2012-03-16  4:05                             ` Shawn Guo
2012-03-16 19:18                             ` Mark Brown
2012-03-09 11:55     ` Mark Brown
2012-03-08 16:59 ` [PATCH v3 10/11] ASoC: fsl: let fsl_ssi work with imx pcm and machine drivers Shawn Guo
2012-03-08 19:15   ` Sascha Hauer
2012-03-09  1:51     ` Shawn Guo
2012-03-08 20:45   ` Timur Tabi
2012-03-09  3:19     ` Shawn Guo
2012-03-09  4:02       ` Tabi Timur-B04825
2012-03-09  5:00         ` Shawn Guo
2012-03-08 16:59 ` [PATCH v3 11/11] ASoC: fsl: add imx-sgtl5000 machine driver Shawn Guo
2012-03-08 20:05 ` [PATCH v3 00/11] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Timur Tabi
2012-03-09  1:19   ` Shawn Guo
2012-03-09  2:11     ` Tabi Timur-B04825
2012-03-09  7:13       ` Shawn Guo
2012-03-09  7:28         ` Shawn Guo
2012-03-09 12:12           ` Mark Brown
2012-03-09 11:59         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331225990-27308-2-git-send-email-shawn.guo@linaro.org \
    --to=shawn.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).