From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 06/10] ASoC: fsl: check property 'compatible' for the machine name
Date: Mon, 12 Mar 2012 19:58:53 +0800 [thread overview]
Message-ID: <1331553537-19789-7-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <1331553537-19789-1-git-send-email-shawn.guo@linaro.org>
Check /compatible rather than /model to determine the machine name.
The p1022ds older device trees get a different /model from the new
ones, while /compatible is consistent there, so checking /compatible
will save the bother of detecting older p1022ds device trees.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
sound/soc/fsl/fsl_ssi.c | 6 +++---
sound/soc/fsl/mpc8610_hpcd.c | 2 +-
sound/soc/fsl/p1022_ds.c | 32 +++++---------------------------
3 files changed, 9 insertions(+), 31 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 3e06696..2eb407f 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -716,12 +716,12 @@ static int __devinit fsl_ssi_probe(struct platform_device *pdev)
}
/* Trigger the machine driver's probe function. The platform driver
- * name of the machine driver is taken from the /model property of the
+ * name of the machine driver is taken from /compatible property of the
* device tree. We also pass the address of the CPU DAI driver
* structure.
*/
- sprop = of_get_property(of_find_node_by_path("/"), "model", NULL);
- /* Sometimes the model name has a "fsl," prefix, so we strip that. */
+ sprop = of_get_property(of_find_node_by_path("/"), "compatible", NULL);
+ /* Sometimes the compatible name has a "fsl," prefix, so we strip it. */
p = strrchr(sprop, ',');
if (p)
sprop = p + 1;
diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
index 354b753..8fdc430 100644
--- a/sound/soc/fsl/mpc8610_hpcd.c
+++ b/sound/soc/fsl/mpc8610_hpcd.c
@@ -402,7 +402,7 @@ static struct platform_driver mpc8610_hpcd_driver = {
.probe = mpc8610_hpcd_probe,
.remove = __devexit_p(mpc8610_hpcd_remove),
.driver = {
- /* The name must match the 'model' property in the device tree,
+ /* The name must match 'compatible' property in the device tree,
* in lowercase letters.
*/
.name = "snd-soc-mpc8610hpcd",
diff --git a/sound/soc/fsl/p1022_ds.c b/sound/soc/fsl/p1022_ds.c
index e87cb41..0f42f31 100644
--- a/sound/soc/fsl/p1022_ds.c
+++ b/sound/soc/fsl/p1022_ds.c
@@ -403,6 +403,11 @@ static struct platform_driver p1022_ds_driver = {
.probe = p1022_ds_probe,
.remove = __devexit_p(p1022_ds_remove),
.driver = {
+ /*
+ * The name must match 'compatible' property in the device tree,
+ * in lowercase letters.
+ */
+ .name = "snd-soc-p1022ds",
.owner = THIS_MODULE,
},
};
@@ -416,33 +421,6 @@ static int __init p1022_ds_init(void)
{
struct device_node *guts_np;
struct resource res;
- const char *sprop;
-
- /*
- * Check if we're actually running on a P1022DS. Older device trees
- * have a model of "fsl,P1022" and newer ones use "fsl,P1022DS", so we
- * need to support both. The SSI driver uses that property to link to
- * the machine driver, so have to match it.
- */
- sprop = of_get_property(of_find_node_by_path("/"), "model", NULL);
- if (!sprop) {
- pr_err("snd-soc-p1022ds: missing /model node");
- return -ENODEV;
- }
-
- pr_debug("snd-soc-p1022ds: board model name is %s\n", sprop);
-
- /*
- * The name of this board, taken from the device tree. Normally, this is a*
- * fixed string, but some P1022DS device trees have a /model property of
- * "fsl,P1022", and others have "fsl,P1022DS".
- */
- if (strcasecmp(sprop, "fsl,p1022ds") == 0)
- p1022_ds_driver.driver.name = "snd-soc-p1022ds";
- else if (strcasecmp(sprop, "fsl,p1022") == 0)
- p1022_ds_driver.driver.name = "snd-soc-p1022";
- else
- return -ENODEV;
/* Get the physical address of the global utilities registers */
guts_np = of_find_compatible_node(NULL, NULL, "fsl,p1022-guts");
--
1.7.5.4
next prev parent reply other threads:[~2012-03-12 11:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 11:58 [PATCH v4] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Shawn Guo
2012-03-12 11:58 ` [PATCH v4 01/10] ASoC: fsl: separate SSI and DMA Kconfig options Shawn Guo
2012-03-12 11:58 ` [PATCH v4 02/10] ASoC: imx: merge sound/soc/imx into sound/soc/fsl Shawn Guo
2012-03-12 11:58 ` [PATCH v4 03/10] ASoC: fsl: rename imx-pcm Kconfig options and filename Shawn Guo
2012-03-12 11:58 ` [PATCH v4 04/10] ASoC: fsl: create fsl_utils to accommodate the common functions Shawn Guo
2012-03-12 11:58 ` [PATCH v4 05/10] ASoC: fsl: remove helper fsl_asoc_get_codec_dev_name Shawn Guo
2012-03-12 11:58 ` Shawn Guo [this message]
2012-03-13 23:12 ` [PATCH v4 06/10] ASoC: fsl: check property 'compatible' for the machine name Timur Tabi
2012-03-13 23:15 ` Mark Brown
2012-03-13 23:21 ` Shawn Guo
2012-03-12 11:58 ` [PATCH v4 07/10] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX Shawn Guo
2012-03-12 11:58 ` [PATCH v4 08/10] ASoC: fsl: remove the fatal error checking on codec-handle Shawn Guo
2012-03-12 11:58 ` [PATCH v4 09/10] ASoC: fsl: let fsl_ssi work with imx pcm and machine drivers Shawn Guo
2012-03-12 11:58 ` [PATCH v4 10/10] ASoC: fsl: add imx-sgtl5000 machine driver Shawn Guo
2012-03-14 9:01 ` [PATCH v4] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Sascha Hauer
2012-03-14 11:33 ` Shawn Guo
2012-03-14 23:02 ` Timur Tabi
2012-03-15 9:52 ` [alsa-devel] " Sascha Hauer
2012-03-15 10:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331553537-19789-7-git-send-email-shawn.guo@linaro.org \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).