From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 08/10] ASoC: fsl: remove the fatal error checking on codec-handle
Date: Mon, 12 Mar 2012 19:58:55 +0800 [thread overview]
Message-ID: <1331553537-19789-9-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <1331553537-19789-1-git-send-email-shawn.guo@linaro.org>
As Documentation/devicetree/bindings/powerpc/fsl/ssi.txt documented,
codec-handle is an optional property, so missing it should not be a
fatal error.
More importantly, the imx machine drivers to be added working with
fsl_ssi will not have this property, as they use new ASoC machine
driver binding mechanism.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
sound/soc/fsl/fsl_ssi.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index db9a734..0192c02 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -642,12 +642,6 @@ static int __devinit fsl_ssi_probe(struct platform_device *pdev)
if (!of_device_is_available(np))
return -ENODEV;
- /* Check for a codec-handle property. */
- if (!of_get_property(np, "codec-handle", NULL)) {
- dev_err(&pdev->dev, "missing codec-handle property\n");
- return -ENODEV;
- }
-
/* We only support the SSI in "I2S Slave" mode */
sprop = of_get_property(np, "fsl,mode", NULL);
if (!sprop || strcmp(sprop, "i2s-slave")) {
--
1.7.5.4
next prev parent reply other threads:[~2012-03-12 11:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 11:58 [PATCH v4] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Shawn Guo
2012-03-12 11:58 ` [PATCH v4 01/10] ASoC: fsl: separate SSI and DMA Kconfig options Shawn Guo
2012-03-12 11:58 ` [PATCH v4 02/10] ASoC: imx: merge sound/soc/imx into sound/soc/fsl Shawn Guo
2012-03-12 11:58 ` [PATCH v4 03/10] ASoC: fsl: rename imx-pcm Kconfig options and filename Shawn Guo
2012-03-12 11:58 ` [PATCH v4 04/10] ASoC: fsl: create fsl_utils to accommodate the common functions Shawn Guo
2012-03-12 11:58 ` [PATCH v4 05/10] ASoC: fsl: remove helper fsl_asoc_get_codec_dev_name Shawn Guo
2012-03-12 11:58 ` [PATCH v4 06/10] ASoC: fsl: check property 'compatible' for the machine name Shawn Guo
2012-03-13 23:12 ` Timur Tabi
2012-03-13 23:15 ` Mark Brown
2012-03-13 23:21 ` Shawn Guo
2012-03-12 11:58 ` [PATCH v4 07/10] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX Shawn Guo
2012-03-12 11:58 ` Shawn Guo [this message]
2012-03-12 11:58 ` [PATCH v4 09/10] ASoC: fsl: let fsl_ssi work with imx pcm and machine drivers Shawn Guo
2012-03-12 11:58 ` [PATCH v4 10/10] ASoC: fsl: add imx-sgtl5000 machine driver Shawn Guo
2012-03-14 9:01 ` [PATCH v4] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Sascha Hauer
2012-03-14 11:33 ` Shawn Guo
2012-03-14 23:02 ` Timur Tabi
2012-03-15 9:52 ` [alsa-devel] " Sascha Hauer
2012-03-15 10:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331553537-19789-9-git-send-email-shawn.guo@linaro.org \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).