From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CDAFE776CB for ; Mon, 2 Oct 2023 23:25:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kHt1iSC7s81s0+TOdx+dQirqOi0ATDkaoc36die5+PI=; b=Yqd746S3zTnqbu xNxIhQHG7TJmPpvKnavFzXyFRGtlKQjNDywmzpIR26x2isspxprUi574KdjlVT5RRqdYBQbsOhRYz 3iCsxTjR7pKtGNtALx8xW3eNnUIBQ26KZeiwuIxrxsKCtdFvUMb3TUPWhNKp/K1/K2Va0Dap23P/p athneBXTNB5J98lj1hQas8G7HxTcMoW2/6XHHpLqP6so6lAduWW+gjXAuZijcLiG+bryybgO/2emm NlFY2Kj3ZfmdDN5ILDcjfjhlMccWlVB/Zk/lCTt6k4VYW0C9v0IN2e/73/74fjLKX7Mo2c+HQ2AxA u8ai9IyK5ITMqJcYQogQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnSHW-00DWpH-34; Mon, 02 Oct 2023 23:24:54 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnSHV-00DWoC-0U; Mon, 02 Oct 2023 23:24:54 +0000 Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-577fff1cae6so189807a12.1; Mon, 02 Oct 2023 16:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696289091; x=1696893891; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bRL3/7Khkbg2e6woqRlv5wpaZ7o8kFg/B18p22kS+Kc=; b=h4SA5O691e0cqXT103+XKztUpCQsFWP0HhD7wTtoF2Todsdam3FzBaTWZ/ZRivY595 Z3ym7WYiID5fkJDFwFaJnYdaTX/Saut9aPDeZJcXnVnlCdP4N01/A1OyucorM7y8sUlq iJOX/Scqvp/F0DnA9P1ViK6tQS9LLo3zULvMhqhDCqI1iREh5M62aYar0pBJ2fGZuYKh hw16GE49THUHwtai9y2QKz2wWvZ67jXqRyL2m2k9byo3h52KkN9HoUwIduRxy0Skg+tx RdxzlVB6bOwXmOrljQak8xs/IiWRxff+74wuATsw/nIJTKK0Io0oaYwZDfNDrPVZ4HaP ohnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696289091; x=1696893891; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bRL3/7Khkbg2e6woqRlv5wpaZ7o8kFg/B18p22kS+Kc=; b=reJy+cBdXasGI3HMQcxFadgjhkasBG/EG+7GPjmP62r76dbJOnpOR8RvXRIZeKwXCU 0k2C5O23JCXMnGSfGe/RUkgBmw2Nwm6env+aggGaxXIRkX8aTfeydE8DhQgc94TciZCO 5f21V5df10FXKc6SOGRqcUuViHdnXHVGH7ncoasNUphAynoGpYfHSgtw5BU9Cxf0dvpT 5CJfuOjyqay7T6ekKedqmDaMW1owZNzlNp9BsWIxD/MutrbxRzQ6J5z6fa8vjO1DNrtp DlsBRh5/FQmPq3arkx3TYUW9Olv/ZTJFkxhwYbS+LhU4Hp64OoxFDbhKnVaazNBXoaw3 yefg== X-Gm-Message-State: AOJu0Yw+fpB7VUiGfQ6hHkxd+22tuNXkAJTOEFUGuwKcMiPA5XZ+kPEj clzA9OasYxnYtEVDHPfg6Do= X-Google-Smtp-Source: AGHT+IGiRKnM19FETZdHmytSO7pAOV0MKx3juucoMJ4Hq570a6/MVewnuwoLdQCjx3N4PrrivmwRsA== X-Received: by 2002:a05:6a20:7d8c:b0:15d:4cf1:212e with SMTP id v12-20020a056a207d8c00b0015d4cf1212emr1678170pzj.4.1696289090943; Mon, 02 Oct 2023 16:24:50 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id p22-20020a637416000000b0056c2de1f32esm4140pgc.78.2023.10.02.16.24.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 16:24:50 -0700 (PDT) Message-ID: <1331726d-2cd4-03a1-6a15-ec145b197da5@gmail.com> Date: Mon, 2 Oct 2023 16:24:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH net-next] net: dsa: mt753x: remove mt753x_phylink_pcs_link_up() Content-Language: en-US To: "Russell King (Oracle)" , Andrew Lunn , Heiner Kallweit Cc: Ar__n__ __NAL , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: From: Florian Fainelli In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231002_162453_194584_84537800 X-CRM114-Status: GOOD ( 11.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/27/23 05:13, Russell King (Oracle) wrote: > Remove the mt753x_phylink_pcs_link_up() function for two reasons: > > 1) priv->pcs[i].pcs.neg_mode is set true, meaning it doesn't take a > MLO_AN_FIXED anymore, but one of PHYLINK_PCS_NEG_*. However, this > is inconsequential due to... > 2) priv->pcs[port].pcs.ops is always initialised to point at > mt7530_pcs_ops, which does not have a pcs_link_up() member. > > So, let's remove mt753x_phylink_pcs_link_up() entirely. > > Signed-off-by: Russell King (Oracle) Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel