linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: philipp.zabel@gmail.com (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH 0/4] pxa: attempt at switch to common clock framework
Date: Fri, 16 Mar 2012 18:35:43 +0100	[thread overview]
Message-ID: <1331919343.31118.19.camel@flow> (raw)

Hi,

I have made an attempt at an initial conversion of PXA clocks to the
common clock framework (http://lkml.org/lkml/2012/3/16/25), and I'd
like to know if somebody is already working on this, or if I am
heading in the general right direction.

Unfortunately, this set still hangs during boot on hx4700 (pxa270),
unless I also disable the calls to __clk_lookup in drivers/clk/clk.c
completely (or apply the patch below). I'll investigate once I get
access to my serial cable and hx4700 charger, but I'd be grateful if
somebody could spot any embarassingly obvious errors.
For pxa25x and pxa3xx, it's compile-tested only.

regards
Philipp

---
 drivers/clk/clk.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index c7c3bc5..79b46af 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -336,14 +336,15 @@ static struct clk *__clk_lookup_subtree(const char *name, struct clk *clk)
 	struct hlist_node *tmp;
 
 	if (!strcmp(clk->name, name))
-		return clk;
+		return NULL;
 
+#if 0
 	hlist_for_each_entry(child, tmp, &clk->children, child_node) {
 		ret = __clk_lookup_subtree(name, child);
 		if (ret)
 			return ret;
 	}
-
+#endif
 	return NULL;
 }
 
-- 
1.7.9.1

             reply	other threads:[~2012-03-16 17:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 17:35 Philipp Zabel [this message]
2012-03-16 22:07 ` [RFC/PATCH 0/4] pxa: attempt at switch to common clock framework Turquette, Mike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331919343.31118.19.camel@flow \
    --to=philipp.zabel@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).