From: rob.lee@linaro.org (Robert Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 6/8] ARM: omap: Consolidate OMAP4 time keeping and irq enable
Date: Tue, 20 Mar 2012 15:22:47 -0500 [thread overview]
Message-ID: <1332274969-15782-7-git-send-email-rob.lee@linaro.org> (raw)
In-Reply-To: <1332274969-15782-1-git-send-email-rob.lee@linaro.org>
Enable core cpuidle timekeeping and irq enabling and remove that
handling from this code.
Signed-off-by: Robert Lee <rob.lee@linaro.org>
Reviewed-by: Kevin Hilman <khilman@ti.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Jean Pihet<j-pihet@ti.com>
---
arch/arm/mach-omap2/cpuidle44xx.c | 21 +++------------------
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c
index 72e018b..f386cbe 100644
--- a/arch/arm/mach-omap2/cpuidle44xx.c
+++ b/arch/arm/mach-omap2/cpuidle44xx.c
@@ -62,15 +62,9 @@ static int omap4_enter_idle(struct cpuidle_device *dev,
{
struct omap4_idle_statedata *cx =
cpuidle_get_statedata(&dev->states_usage[index]);
- struct timespec ts_preidle, ts_postidle, ts_idle;
u32 cpu1_state;
- int idle_time;
int cpu_id = smp_processor_id();
- /* Used to keep track of the total time in idle */
- getnstimeofday(&ts_preidle);
-
- local_irq_disable();
local_fiq_disable();
/*
@@ -128,26 +122,17 @@ static int omap4_enter_idle(struct cpuidle_device *dev,
if (index > 0)
clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu_id);
- getnstimeofday(&ts_postidle);
- ts_idle = timespec_sub(ts_postidle, ts_preidle);
-
- local_irq_enable();
local_fiq_enable();
- idle_time = ts_idle.tv_nsec / NSEC_PER_USEC + ts_idle.tv_sec * \
- USEC_PER_SEC;
-
- /* Update cpuidle counters */
- dev->last_residency = idle_time;
-
return index;
}
DEFINE_PER_CPU(struct cpuidle_device, omap4_idle_dev);
struct cpuidle_driver omap4_idle_driver = {
- .name = "omap4_idle",
- .owner = THIS_MODULE,
+ .name = "omap4_idle",
+ .owner = THIS_MODULE,
+ .en_core_tk_irqen = 1,
};
static inline void _fill_cstate(struct cpuidle_driver *drv,
--
1.7.9.4
next prev parent reply other threads:[~2012-03-20 20:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 20:22 [PATCH v8 0/8] Consolidate cpuidle functionality Robert Lee
2012-03-20 20:22 ` [PATCH v8 1/8] cpuidle: Add common time keeping and irq enabling Robert Lee
2012-03-20 20:22 ` [PATCH v8 2/8] ARM: at91: Consolidate time keeping and irq enable Robert Lee
2012-03-20 20:22 ` [PATCH v8 3/8] ARM: kirkwood: " Robert Lee
2012-03-20 20:22 ` [PATCH v8 4/8] ARM: davinci: " Robert Lee
2012-03-21 14:28 ` Rob Lee
2012-03-21 14:36 ` Rob Lee
2012-03-21 14:36 ` Amit Kucheria
2012-03-21 15:37 ` Nori, Sekhar
2012-03-21 15:33 ` Nori, Sekhar
2012-03-20 20:22 ` [PATCH v8 5/8] ARM: omap: Consolidate OMAP3 " Robert Lee
2012-03-20 20:22 ` Robert Lee [this message]
2012-03-20 20:22 ` [PATCH v8 7/8] ARM: shmobile: Consolidate " Robert Lee
2012-03-20 20:22 ` [PATCH v8 8/8] SH: " Robert Lee
2012-03-20 21:58 ` [PATCH v8 0/8] Consolidate cpuidle functionality Arnd Bergmann
2012-03-20 22:48 ` Kevin Hilman
2012-03-20 23:05 ` Arnd Bergmann
2012-03-20 23:56 ` Kevin Hilman
2012-03-20 23:06 ` Amit Kucheria
2012-03-21 0:01 ` Rafael J. Wysocki
2012-03-21 2:38 ` Deepthi Dharwar
2012-03-21 4:53 ` Len Brown
2012-03-21 2:23 ` Nicolas Pitre
2012-03-21 0:10 ` Kevin Hilman
2012-03-21 1:45 ` Nicolas Pitre
2012-03-21 4:45 ` Rob Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332274969-15782-7-git-send-email-rob.lee@linaro.org \
--to=rob.lee@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).