From: rob.lee@linaro.org (Robert Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 7/8] ARM: shmobile: Consolidate time keeping and irq enable
Date: Tue, 20 Mar 2012 15:22:48 -0500 [thread overview]
Message-ID: <1332274969-15782-8-git-send-email-rob.lee@linaro.org> (raw)
In-Reply-To: <1332274969-15782-1-git-send-email-rob.lee@linaro.org>
Enable core cpuidle timekeeping and irq enabling and remove that
handling from this code.
Signed-off-by: Robert Lee <rob.lee@linaro.org>
Reviewed-by: Kevin Hilman <khilman@ti.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Jean Pihet<j-pihet@ti.com>
---
arch/arm/mach-shmobile/cpuidle.c | 31 +++++++------------------------
1 file changed, 7 insertions(+), 24 deletions(-)
diff --git a/arch/arm/mach-shmobile/cpuidle.c b/arch/arm/mach-shmobile/cpuidle.c
index 1b23342..ca23b20 100644
--- a/arch/arm/mach-shmobile/cpuidle.c
+++ b/arch/arm/mach-shmobile/cpuidle.c
@@ -14,6 +14,7 @@
#include <linux/module.h>
#include <linux/err.h>
#include <asm/system.h>
+#include <asm/cpuidle.h>
#include <asm/io.h>
static void shmobile_enter_wfi(void)
@@ -29,37 +30,19 @@ static int shmobile_cpuidle_enter(struct cpuidle_device *dev,
struct cpuidle_driver *drv,
int index)
{
- ktime_t before, after;
-
- before = ktime_get();
-
- local_irq_disable();
- local_fiq_disable();
-
shmobile_cpuidle_modes[index]();
- local_irq_enable();
- local_fiq_enable();
-
- after = ktime_get();
- dev->last_residency = ktime_to_ns(ktime_sub(after, before)) >> 10;
-
return index;
}
static struct cpuidle_device shmobile_cpuidle_dev;
static struct cpuidle_driver shmobile_cpuidle_driver = {
- .name = "shmobile_cpuidle",
- .owner = THIS_MODULE,
- .states[0] = {
- .name = "C1",
- .desc = "WFI",
- .exit_latency = 1,
- .target_residency = 1 * 2,
- .flags = CPUIDLE_FLAG_TIME_VALID,
- },
- .safe_state_index = 0, /* C1 */
- .state_count = 1,
+ .name = "shmobile_cpuidle",
+ .owner = THIS_MODULE,
+ .en_core_tk_irqen = 1,
+ .states[0] = ARM_CPUIDLE_WFI_STATE,
+ .safe_state_index = 0, /* C1 */
+ .state_count = 1,
};
void (*shmobile_cpuidle_setup)(struct cpuidle_driver *drv);
--
1.7.9.4
next prev parent reply other threads:[~2012-03-20 20:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 20:22 [PATCH v8 0/8] Consolidate cpuidle functionality Robert Lee
2012-03-20 20:22 ` [PATCH v8 1/8] cpuidle: Add common time keeping and irq enabling Robert Lee
2012-03-20 20:22 ` [PATCH v8 2/8] ARM: at91: Consolidate time keeping and irq enable Robert Lee
2012-03-20 20:22 ` [PATCH v8 3/8] ARM: kirkwood: " Robert Lee
2012-03-20 20:22 ` [PATCH v8 4/8] ARM: davinci: " Robert Lee
2012-03-21 14:28 ` Rob Lee
2012-03-21 14:36 ` Rob Lee
2012-03-21 14:36 ` Amit Kucheria
2012-03-21 15:37 ` Nori, Sekhar
2012-03-21 15:33 ` Nori, Sekhar
2012-03-20 20:22 ` [PATCH v8 5/8] ARM: omap: Consolidate OMAP3 " Robert Lee
2012-03-20 20:22 ` [PATCH v8 6/8] ARM: omap: Consolidate OMAP4 " Robert Lee
2012-03-20 20:22 ` Robert Lee [this message]
2012-03-20 20:22 ` [PATCH v8 8/8] SH: shmobile: Consolidate " Robert Lee
2012-03-20 21:58 ` [PATCH v8 0/8] Consolidate cpuidle functionality Arnd Bergmann
2012-03-20 22:48 ` Kevin Hilman
2012-03-20 23:05 ` Arnd Bergmann
2012-03-20 23:56 ` Kevin Hilman
2012-03-20 23:06 ` Amit Kucheria
2012-03-21 0:01 ` Rafael J. Wysocki
2012-03-21 2:38 ` Deepthi Dharwar
2012-03-21 4:53 ` Len Brown
2012-03-21 2:23 ` Nicolas Pitre
2012-03-21 0:10 ` Kevin Hilman
2012-03-21 1:45 ` Nicolas Pitre
2012-03-21 4:45 ` Rob Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332274969-15782-8-git-send-email-rob.lee@linaro.org \
--to=rob.lee@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).