From: alexgershgorin@gmail.com (Alex Gershgorin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: i.MX35-PDK Add regulator support
Date: Fri, 23 Mar 2012 20:11:07 +0200 [thread overview]
Message-ID: <1332526267-3236-1-git-send-email-alexg@meprolight.com> (raw)
From: Alex <alexg@meprolight.com>
Hi Marc,
Thanks for the patches.
v4 3/4 not directly applicable to Linux version 3.3,
I installed it manually, you could check it out?
> > I'm not very experienced with the regulator driver, but noticed a couple of
> > minor things with your patch...
I think that my experience in the regulator driver a little less than you :-)
> static struct resource mx35pdk_flash_resource = {
> .start = MX35_CS0_BASE_ADDR,
> - .end = MX35_CS0_BASE_ADDR + SZ_64M - 1,
> + .end = MX35_CS0_BASE_ADDR + SZ_64M - 1,
> > did you mean to change this?
No, I will correct this.
> +static struct regulator_init_data vsd_init = {
> + .constraints = {
> + .name = "VSD",
> + .min_uV = 1800000,
> + .max_uV = 3150000,
> + .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE,
> + }
> +};
> > I think this is on at power up too (for imx35)
Maybe you're right, but in this case, the i.MX35 PDK
Do not use PMIC "VSD" regulator, but instead it is used
a different power source.
I think it can be removed from here :-)
Regards,
Alex Gershgorin
next reply other threads:[~2012-03-23 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 18:11 Alex Gershgorin [this message]
2012-03-23 22:43 ` [PATCH] regulator: i.MX35-PDK Add regulator support Marc Reilly
-- strict thread matches above, loose matches on Subject: below --
2012-03-22 23:52 Alex
2012-03-23 1:23 ` Marc Reilly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332526267-3236-1-git-send-email-alexg@meprolight.com \
--to=alexgershgorin@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).