From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: sa1100: make sa1100_register_uart_fns a function
Date: Thu, 25 Feb 2016 15:34:37 +0100 [thread overview]
Message-ID: <133317017.7Cfvjc5WMX@wuerfel> (raw)
In-Reply-To: <CACRpkdbJpYD2Ke-f2QP+-fy_LcxhiV99OEH_D=CMtSvedEveVA@mail.gmail.com>
On Thursday 25 February 2016 14:18:44 Linus Walleij wrote:
> On Tue, Feb 23, 2016 at 3:34 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> > Calling sa1100_register_uart_fns() leaves the port structure
> > unused when CONFIG_SERIAL_SA1100 is disabled, and we get a
> > compiler warning about that:
> >
> > arch/arm/mach-sa1100/badge4.c:317:31: warning: 'badge4_port_fns' defined but not used [-Wunused-variable]
> > static struct sa1100_port_fns badge4_port_fns __initdata = {
> >
> > This turns the two empty macros into empty inline functions,
> > which has the same effect, but lets the compiler know that the
> > variables are intentionally unused.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> > include/linux/platform_data/sa11x0-serial.h | 8 ++++++--
>
> It looks like you should send this to Greg?
Yes, good point.
The file was traditionally under arch/arm (or include/asm-arm before
that), but considering it as part of the driver makes slightly
more sense now.
Sent out with a modified subject and your Ack to Greg now.
Arnd
prev parent reply other threads:[~2016-02-25 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:34 [PATCH] ARM: sa1100: make sa1100_register_uart_fns a function Arnd Bergmann
2016-02-25 13:18 ` Linus Walleij
2016-02-25 14:34 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=133317017.7Cfvjc5WMX@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox