linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mach-exynos: fix ISO C90 warning.
@ 2012-04-02 11:55 Il Han
  2012-04-02 18:57 ` Kukjin Kim
  0 siblings, 1 reply; 2+ messages in thread
From: Il Han @ 2012-04-02 11:55 UTC (permalink / raw)
  To: linux-arm-kernel

ISO C90 forbids mixed declarations and code.
Fix it.

Signed-off-by: Il Han <corone.il.han@gmail.com>
---
 arch/arm/mach-exynos/common.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
index e6cc50e..8614aab 100644
--- a/arch/arm/mach-exynos/common.c
+++ b/arch/arm/mach-exynos/common.c
@@ -583,10 +583,11 @@ core_initcall(exynos_core_init);
 #ifdef CONFIG_CACHE_L2X0
 static int __init exynos4_l2x0_cache_init(void)
 {
+	int ret;
+
 	if (soc_is_exynos5250())
 		return 0;
 
-	int ret;
 	ret = l2x0_of_init(L2_AUX_VAL, L2_AUX_MASK);
 	if (!ret) {
 		l2x0_regs_phys = virt_to_phys(&l2x0_saved_regs);
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] mach-exynos: fix ISO C90 warning.
  2012-04-02 11:55 [PATCH] mach-exynos: fix ISO C90 warning Il Han
@ 2012-04-02 18:57 ` Kukjin Kim
  0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2012-04-02 18:57 UTC (permalink / raw)
  To: linux-arm-kernel

Il Han wrote:
> ISO C90 forbids mixed declarations and code.
> Fix it.
> 
> Signed-off-by: Il Han<corone.il.han@gmail.com>
> ---
>   arch/arm/mach-exynos/common.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index e6cc50e..8614aab 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -583,10 +583,11 @@ core_initcall(exynos_core_init);
>   #ifdef CONFIG_CACHE_L2X0
>   static int __init exynos4_l2x0_cache_init(void)
>   {
> +	int ret;
> +
>   	if (soc_is_exynos5250())
>   		return 0;
> 
> -	int ret;
>   	ret = l2x0_of_init(L2_AUX_VAL, L2_AUX_MASK);
>   	if (!ret) {
>   		l2x0_regs_phys = virt_to_phys(&l2x0_saved_regs);

Yeah, seems happened wehn merge confilcts resolved.

OK, will apply and if possible, please use following subject form in
next time like others. Every ARM platfomrs use that.

'ARM: EXYNOS: ...'

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-02 18:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-02 11:55 [PATCH] mach-exynos: fix ISO C90 warning Il Han
2012-04-02 18:57 ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).