From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/13] clk: Make clk_get_rate() return 0 on error
Date: Wed, 11 Apr 2012 18:02:47 -0700 [thread overview]
Message-ID: <1334192572-12499-10-git-send-email-mturquette@linaro.org> (raw)
In-Reply-To: <1334192572-12499-1-git-send-email-mturquette@linaro.org>
From: Rajendra Nayak <rnayak@ti.com>
Most users of clk_get_rate() actually assume a non zero
return value as a valid rate returned. Returing -EINVAL
might confuse such users, so make it instead return zero
on error.
Besides the return value of clk_get_rate seems to be
'unsigned long'.
Signed-off-by: Rajendra nayak <rnayak@ti.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
Cc: Arnd Bergman <arnd.bergmann@linaro.org>
Cc: Olof Johansson <olof@lixom.net>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawn.guo@freescale.com>
Cc: Richard Zhao <richard.zhao@linaro.org>
Cc: Saravana Kannan <skannan@codeaurora.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Viresh Kumar <viresh.kumar@st.com>
---
drivers/clk/clk.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 9924aec..a24b121 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -285,7 +285,7 @@ unsigned long __clk_get_rate(struct clk *clk)
unsigned long ret;
if (!clk) {
- ret = -EINVAL;
+ ret = 0;
goto out;
}
@@ -295,7 +295,7 @@ unsigned long __clk_get_rate(struct clk *clk)
goto out;
if (!clk->parent)
- ret = -ENODEV;
+ ret = 0;
out:
return ret;
@@ -560,7 +560,7 @@ EXPORT_SYMBOL_GPL(clk_enable);
* @clk: the clk whose rate is being returned
*
* Simply returns the cached rate of the clk. Does not query the hardware. If
- * clk is NULL then returns -EINVAL.
+ * clk is NULL then returns 0.
*/
unsigned long clk_get_rate(struct clk *clk)
{
--
1.7.5.4
next prev parent reply other threads:[~2012-04-12 1:02 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 1:02 [PATCH 00/13] common clk framework misc fixes Mike Turquette
2012-04-12 1:02 ` [PATCH 01/13] clk: core: correct clk_set_rate kerneldoc Mike Turquette
2012-04-12 4:28 ` Viresh Kumar
2012-04-13 22:23 ` Turquette, Mike
2012-04-12 7:24 ` Andrew Lunn
2012-04-12 7:38 ` Amit Kucheria
2012-04-12 1:02 ` [PATCH 02/13] clk: core: remove dead code paths Mike Turquette
2012-04-12 6:14 ` Viresh Kumar
2012-04-13 22:27 ` Turquette, Mike
2012-04-12 1:02 ` [PATCH 03/13] clk: core: clk_calc_new_rates handles NULL parents Mike Turquette
2012-04-12 1:02 ` [PATCH 04/13] clk: core: enforce clk_ops consistency Mike Turquette
2012-04-12 6:17 ` Viresh Kumar
2012-04-12 1:02 ` [PATCH 05/13] clk: use kzalloc in clk_register_mux Mike Turquette
2012-04-12 6:18 ` Viresh Kumar
2012-04-12 1:02 ` [PATCH 06/13] clk: remove unnecessary EXPORT_SYMBOL_GPL Mike Turquette
2012-04-12 6:18 ` Viresh Kumar
2012-04-12 1:02 ` [PATCH 07/13] clk: add "const" for clk_ops of basic clks Mike Turquette
2012-04-12 6:19 ` Viresh Kumar
2012-04-12 1:02 ` [PATCH 08/13] clk: declare clk_ops of basic clks in clk-provider.h Mike Turquette
2012-04-12 6:20 ` Viresh Kumar
2012-04-12 1:02 ` Mike Turquette [this message]
2012-04-12 6:21 ` [PATCH 09/13] clk: Make clk_get_rate() return 0 on error Viresh Kumar
2012-04-12 1:02 ` [PATCH 10/13] clk: Remove comment for end of CONFIG_COMMON_CLK section Mike Turquette
2012-04-12 1:02 ` [PATCH 11/13] clk: Constify parent name arrays Mike Turquette
2012-04-12 1:02 ` [PATCH 12/13] clk: core: copy parent_names & return error codes Mike Turquette
2012-04-16 20:30 ` Sascha Hauer
2012-04-16 21:35 ` Turquette, Mike
2012-04-12 1:02 ` [PATCH 13/13] clk: basic: improve parent_names & return errors Mike Turquette
2012-04-12 6:49 ` Shawn Guo
2012-04-16 23:10 ` Turquette, Mike
2012-04-17 1:46 ` Shawn Guo
2012-04-17 3:50 ` Turquette, Mike
2012-04-17 7:17 ` Shawn Guo
2012-04-20 20:01 ` Saravana Kannan
2012-04-26 6:00 ` Saravana Kannan
2012-04-16 20:52 ` Sascha Hauer
2012-04-16 23:11 ` Turquette, Mike
2012-04-12 8:56 ` [PATCH 00/13] common clk framework misc fixes Sascha Hauer
2012-04-12 11:14 ` Arnd Bergmann
2012-04-12 13:11 ` Shawn Guo
2012-04-12 12:50 ` [PATCH 1/3] clk: always pass parent_rate into .round_rate Shawn Guo
2012-04-12 12:50 ` [PATCH 2/3] clk: pass parent_rate into .set_rate Shawn Guo
2012-04-18 1:05 ` Turquette, Mike
2012-04-12 12:50 ` [PATCH 3/3] clk: propagate round_rate for CLK_SET_RATE_PARENT case Shawn Guo
2012-04-18 1:07 ` Turquette, Mike
2012-04-18 1:05 ` [PATCH 1/3] clk: always pass parent_rate into .round_rate Turquette, Mike
2012-05-02 9:51 ` Sascha Hauer
2012-05-06 23:41 ` Turquette, Mike
2012-04-13 9:21 ` [PATCH 00/13] common clk framework misc fixes Mark Brown
2012-04-13 22:20 ` Turquette, Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334192572-12499-10-git-send-email-mturquette@linaro.org \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).