linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: archit@ti.com (Archit Taneja)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP4: DSS hwmods: Add OCPIF_SWSUP_IDLE to all DSS L3 slave interfaces
Date: Fri, 13 Apr 2012 13:31:56 +0530	[thread overview]
Message-ID: <1334304116-18872-3-git-send-email-archit@ti.com> (raw)
In-Reply-To: <1334304116-18872-1-git-send-email-archit@ti.com>

The clock for all DSS L3 slave interfaces had been recently changed to
"dss_fck" from "l3_div_ck". "dss_fck" is an optional clock in DSS clock domain
which can't autoidle when enabled.

Add OCPIF_SWSUP_IDLE flag to all the L3 slave interfaces used by DSS hwmods so
that clock is explicitly enabled and disabled by software. Without this,
"dss_fck" would be left as enabled and the OMAP4 device won't idle even when
DSS is not in use.

Signed-off-by: Archit Taneja <archit@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index cc9bd10..f928347 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -1216,6 +1216,7 @@ static struct omap_hwmod_ocp_if omap44xx_l3_main_2__dss = {
 	.slave		= &omap44xx_dss_hwmod,
 	.clk		= "dss_fck",
 	.addr		= omap44xx_dss_dma_addrs,
+	.flags		= OCPIF_SWSUP_IDLE,
 	.user		= OCP_USER_SDMA,
 };
 
@@ -1319,6 +1320,7 @@ static struct omap_hwmod_ocp_if omap44xx_l3_main_2__dss_dispc = {
 	.slave		= &omap44xx_dss_dispc_hwmod,
 	.clk		= "dss_fck",
 	.addr		= omap44xx_dss_dispc_dma_addrs,
+	.flags		= OCPIF_SWSUP_IDLE,
 	.user		= OCP_USER_SDMA,
 };
 
@@ -1417,6 +1419,7 @@ static struct omap_hwmod_ocp_if omap44xx_l3_main_2__dss_dsi1 = {
 	.slave		= &omap44xx_dss_dsi1_hwmod,
 	.clk		= "dss_fck",
 	.addr		= omap44xx_dss_dsi1_dma_addrs,
+	.flags		= OCPIF_SWSUP_IDLE,
 	.user		= OCP_USER_SDMA,
 };
 
@@ -1494,6 +1497,7 @@ static struct omap_hwmod_ocp_if omap44xx_l3_main_2__dss_dsi2 = {
 	.slave		= &omap44xx_dss_dsi2_hwmod,
 	.clk		= "dss_fck",
 	.addr		= omap44xx_dss_dsi2_dma_addrs,
+	.flags		= OCPIF_SWSUP_IDLE,
 	.user		= OCP_USER_SDMA,
 };
 
@@ -1591,6 +1595,7 @@ static struct omap_hwmod_ocp_if omap44xx_l3_main_2__dss_hdmi = {
 	.slave		= &omap44xx_dss_hdmi_hwmod,
 	.clk		= "dss_fck",
 	.addr		= omap44xx_dss_hdmi_dma_addrs,
+	.flags		= OCPIF_SWSUP_IDLE,
 	.user		= OCP_USER_SDMA,
 };
 
@@ -1683,6 +1688,7 @@ static struct omap_hwmod_ocp_if omap44xx_l3_main_2__dss_rfbi = {
 	.slave		= &omap44xx_dss_rfbi_hwmod,
 	.clk		= "dss_fck",
 	.addr		= omap44xx_dss_rfbi_dma_addrs,
+	.flags		= OCPIF_SWSUP_IDLE,
 	.user		= OCP_USER_SDMA,
 };
 
@@ -1758,6 +1764,7 @@ static struct omap_hwmod_ocp_if omap44xx_l3_main_2__dss_venc = {
 	.slave		= &omap44xx_dss_venc_hwmod,
 	.clk		= "dss_fck",
 	.addr		= omap44xx_dss_venc_dma_addrs,
+	.flags		= OCPIF_SWSUP_IDLE,
 	.user		= OCP_USER_SDMA,
 };
 
-- 
1.7.5.4

  parent reply	other threads:[~2012-04-13  8:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13  8:01 [PATCH 0/2] ARM: OMAP2PLUS: DSS hwmod fixes Archit Taneja
2012-04-13  8:01 ` [PATCH 1/2] ARM: OMAP2/3: VENC hwmods: Remove OCPIF_SWSUP_IDLE flag from VENC slave interface Archit Taneja
2012-04-13 11:20   ` Paul Walmsley
2012-04-13 11:24     ` Paul Walmsley
2012-04-13 11:37       ` Archit Taneja
2012-04-13  8:01 ` Archit Taneja [this message]
2012-04-13  8:43   ` [PATCH 2/2] ARM: OMAP4: DSS hwmods: Add OCPIF_SWSUP_IDLE to all DSS L3 slave interfaces Cousson, Benoit
2012-04-13  8:51     ` Archit Taneja
2012-05-04  6:39       ` Paul Walmsley
2012-05-04  7:03         ` Archit Taneja
2012-05-04  8:51           ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334304116-18872-3-git-send-email-archit@ti.com \
    --to=archit@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).