From: ben@decadent.org.uk (Ben Hutchings)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] ARM: orion5x: Fix GPIO enable bits for MPP9
Date: Fri, 20 Apr 2012 01:57:00 +0100 [thread overview]
Message-ID: <1334883420.3209.230.camel@deadeye> (raw)
In-Reply-To: <1333858733.7150.115.camel@deadeye>
On Sun, 2012-04-08 at 05:18 +0100, Ben Hutchings wrote:
> Commit 554cdaefd1cf7bb54b209c4e68c7cec87ce442a9 ('ARM: orion5x: Refactor
> mpp code to use common orion platform mpp.') seems to have accidentally
> inverted the GPIO valid bits for MPP9 (only). For the mv2120 platform
> which uses MPP9 as a GPIO LED device, this results in the error:
>
> [ 12.711476] leds-gpio: probe of leds-gpio failed with error -22
>
> Reported-by: Henry von Tresckow <hvontres@gmail.com>
Tested-by: Hans Henry von Tresckow <hvontres@gmail.com>
(on the mv2120, and applied to Debian's 3.2 tree)
> References: http://bugs.debian.org/667446
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Cc: stable at vger.kernel.org [v3.0+]
> ---
> v2: Add subject of the earlier commit
>
> Ben.
>
> arch/arm/mach-orion5x/mpp.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-orion5x/mpp.h b/arch/arm/mach-orion5x/mpp.h
> index eac6897..db70e79 100644
> --- a/arch/arm/mach-orion5x/mpp.h
> +++ b/arch/arm/mach-orion5x/mpp.h
> @@ -65,8 +65,8 @@
> #define MPP8_GIGE MPP(8, 0x1, 0, 0, 1, 1, 1)
>
> #define MPP9_UNUSED MPP(9, 0x0, 0, 0, 1, 1, 1)
> -#define MPP9_GPIO MPP(9, 0x0, 0, 0, 1, 1, 1)
> -#define MPP9_GIGE MPP(9, 0x1, 1, 1, 1, 1, 1)
> +#define MPP9_GPIO MPP(9, 0x0, 1, 1, 1, 1, 1)
> +#define MPP9_GIGE MPP(9, 0x1, 0, 0, 1, 1, 1)
>
> #define MPP10_UNUSED MPP(10, 0x0, 0, 0, 1, 1, 1)
> #define MPP10_GPIO MPP(10, 0x0, 1, 1, 1, 1, 1)
--
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120420/945f26f1/attachment.sig>
next prev parent reply other threads:[~2012-04-20 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-08 4:18 [PATCHv2] ARM: orion5x: Fix GPIO enable bits for MPP9 Ben Hutchings
2012-04-11 1:29 ` Jason Cooper
2012-04-20 0:57 ` Ben Hutchings [this message]
2012-05-08 18:26 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334883420.3209.230.camel@deadeye \
--to=ben@decadent.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).