linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/18][V3] ARM: OMAP3: cpuidle - remove the 'valid' field
Date: Tue, 24 Apr 2012 16:05:32 +0200	[thread overview]
Message-ID: <1335276339-11135-12-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1335276339-11135-1-git-send-email-daniel.lezcano@linaro.org>

With the previous changes all the states are valid, except
the last state which can be handled by decreasing the number
of states.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Jean Pihet <j-pihet@ti.com>
---
 arch/arm/mach-omap2/cpuidle34xx.c |   11 ++---------
 1 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c
index f394ea6..29b4f87 100644
--- a/arch/arm/mach-omap2/cpuidle34xx.c
+++ b/arch/arm/mach-omap2/cpuidle34xx.c
@@ -67,7 +67,6 @@ static struct cpuidle_params cpuidle_params_table[] = {
 struct omap3_idle_statedata {
 	u32 mpu_state;
 	u32 core_state;
-	u8 valid;
 };
 struct omap3_idle_statedata omap3_idle_data[OMAP3_NUM_STATES];
 
@@ -191,8 +190,7 @@ static int next_valid_state(struct cpuidle_device *dev,
 	}
 
 	/* Check if current state is valid */
-	if ((cx->valid) &&
-	    (cx->mpu_state >= mpu_deepest_state) &&
+	if ((cx->mpu_state >= mpu_deepest_state) &&
 	    (cx->core_state >= core_deepest_state)) {
 		return index;
 	} else {
@@ -216,8 +214,7 @@ static int next_valid_state(struct cpuidle_device *dev,
 		idx--;
 		for (; idx >= 0; idx--) {
 			cx = cpuidle_get_statedata(&dev->states_usage[idx]);
-			if ((cx->valid) &&
-			    (cx->mpu_state >= mpu_deepest_state) &&
+			if ((cx->mpu_state >= mpu_deepest_state) &&
 			    (cx->core_state >= core_deepest_state)) {
 				next_index = idx;
 				break;
@@ -371,7 +368,6 @@ static inline struct omap3_idle_statedata *_fill_cstate_usage(
 	struct omap3_idle_statedata *cx = &omap3_idle_data[idx];
 	struct cpuidle_state_usage *state_usage = &dev->states_usage[idx];
 
-	cx->valid		= cpuidle_params_table[idx].valid;
 	cpuidle_set_statedata(state_usage, cx);
 
 	return cx;
@@ -386,7 +382,6 @@ static inline struct omap3_idle_statedata *_fill_cstate_usage(
 int __init omap3_idle_init(void)
 {
 	struct cpuidle_device *dev;
-	struct cpuidle_driver *drv = &omap3_idle_driver;
 	struct omap3_idle_statedata *cx;
 
 	mpu_pd = pwrdm_lookup("mpu_pwrdm");
@@ -399,7 +394,6 @@ int __init omap3_idle_init(void)
 
 	/* C1 . MPU WFI + Core active */
 	cx = _fill_cstate_usage(dev, 0);
-	cx->valid = 1;	/* C1 is always valid */
 	cx->mpu_state = PWRDM_POWER_ON;
 	cx->core_state = PWRDM_POWER_ON;
 
@@ -433,7 +427,6 @@ int __init omap3_idle_init(void)
 	cx->mpu_state = PWRDM_POWER_OFF;
 	cx->core_state = PWRDM_POWER_OFF;
 
-	drv->state_count = OMAP3_NUM_STATES;
 	cpuidle_register_driver(&omap3_idle_driver);
 
 	if (cpuidle_register_device(dev)) {
-- 
1.7.5.4

  parent reply	other threads:[~2012-04-24 14:05 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 14:05 [PATCH 00/18][V3] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups Daniel Lezcano
2012-04-24 14:05 ` [PATCH 01/18][V3] ARM: OMAP4: cpuidle - Remove unused valid field Daniel Lezcano
2012-04-24 14:05 ` [PATCH 02/18][V3] ARM: OMAP4: cpuidle - Declare the states with the driver declaration Daniel Lezcano
2012-04-24 14:05 ` [PATCH 03/18][V3] ARM: OMAP4: cpuidle - Remove the cpuidle_params_table table Daniel Lezcano
2012-04-24 14:05 ` [PATCH 04/18][V3] ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration Daniel Lezcano
2012-04-24 14:05 ` [PATCH 05/18][V3] ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time Daniel Lezcano
2012-04-24 14:05 ` [PATCH 06/18][V3] ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly Daniel Lezcano
2012-04-24 14:05 ` [PATCH 07/18][V3] ARM: OMAP4: cpuidle - remove omap4_idle_data initialization at boot time Daniel Lezcano
2012-04-24 14:05 ` [PATCH 08/18][V3] ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table Daniel Lezcano
2012-04-24 14:05 ` [PATCH 09/18][V3] ARM: OMAP3: define cpuidle statically Daniel Lezcano
2012-04-24 14:05 ` [PATCH 10/18][V3] ARM: OMAP3: cpuidle - remove errata check in the init function Daniel Lezcano
2012-04-24 14:05 ` Daniel Lezcano [this message]
2012-05-03 20:19   ` [PATCH 11/18][V3] ARM: OMAP3: cpuidle - remove the 'valid' field Kevin Hilman
2012-05-03 20:29     ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 12/18][V3] ARM: OMAP3: cpuidle - remove cpuidle_params_table Daniel Lezcano
2012-04-24 14:05 ` [PATCH 13/18][V3] ARM: OMAP3: define statically the omap3_idle_data Daniel Lezcano
2012-04-24 14:05 ` [PATCH 14/18][V3] ARM: OMAP3: cpuidle - use omap3_idle_data directly Daniel Lezcano
2012-04-24 14:05 ` [PATCH 15/18][V3] ARM: OMAP3: cpuidle - simplify next_valid_state Daniel Lezcano
2012-04-24 14:05 ` [PATCH 16/18][V3] ARM: OMAP3: set omap3_idle_data as static Daniel Lezcano
2012-04-24 14:05 ` [PATCH 17/18][V3] ARM: OMAP3/4: consolidate cpuidle Makefile Daniel Lezcano
2012-05-03 20:34   ` Kevin Hilman
2012-05-03 23:03     ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 18/18][V3] ARM: OMAP3: cpuidle - set global variables static Daniel Lezcano
2012-05-03 20:26   ` Kevin Hilman
2012-05-03 23:02     ` Daniel Lezcano
2012-04-25 22:00 ` [PATCH 00/18][V3] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups Daniel Lezcano
2012-04-30 22:58   ` Kevin Hilman
2012-05-01  8:16     ` Daniel Lezcano
2012-05-01  9:25       ` Amit Kucheria
     [not found]       ` <CAMQu2gzK=u1kkbv9nzRyO3xbqVhZkf0KP=ceCyNteSituBZPrg@mail.gmail.com>
2012-05-01 10:20         ` Daniel Lezcano
2012-05-02  6:20           ` Shilimkar, Santosh
2012-05-03 20:39 ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335276339-11135-12-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).