From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DAE1CE79A8 for ; Tue, 19 Sep 2023 17:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rBohY9n7E7mqcdh5O0X8Qy9SYwYcQ4M+3AgS+HXeS2Q=; b=Vp/fCL+Y5v7B36 2slMPet/08xEaGWYvHwTrIaSYctwQ4Qyoi7m8PNMMHVxwgRSzd3JLJTaxGAJXIuwIHKg517xm7St/ UpQx9eZIBbUiEd906F0+c17uiqynFXQ9YrKtjhmQ7IlD3a/fDtACGKvAbT/BUPby+X1TYUiNCfYlG O+sbcwBCGmYaAEv2XB9xWY3r0Va2lTvJL3X+2xWsejvUrVj65ESX6IYvAy2r+VrS7OMYn71Xu4K7g EH6gAwIqeXtKsN6z5cStx1MIqbKhaTZfAoA93A0cdBU4cAqCyIseEubkEBNRK8Gto1XbaSGHTBm4J wBOs8xTM69J8pxG9f0lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qieQQ-000vcQ-1d; Tue, 19 Sep 2023 17:22:14 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qieQO-000vbJ-1p for linux-arm-kernel@lists.infradead.org; Tue, 19 Sep 2023 17:22:13 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9ad8a822508so750250166b.0 for ; Tue, 19 Sep 2023 10:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695144125; x=1695748925; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R9KCoHYlrD8PBCS/9p9Xtjaer8cxRzRUbZnHNFMvu9U=; b=EGPOuT9tUAjLk6Jz+9z4cE/xGybpqBp1qzdX0dmMSFyJgW7Z0vuTc8HD4R41xC14+4 E98ESVb7Fv8kNRK0NkT+n8xcURLDrca+0i2pD4h3xkL3/Reojjz6LcvFrv7neErLipw8 NgdG89CpjaFvt+cdMS6zPxN2qESkfGH8cwEKgYxU9TB1+yR1IEz23oM7f3esix17X7yc MGU+q1V3AlwZb9+Pfj6bLchFKfupoeO4oAYMsefYtLPya5wWWA+I5vVeiQ3YoDMti8lI 17Xb7Cf8StjWp4xQPo31yamyyeli4aKI6SgmlZSC3miI9eeO+fwFGpI9gfehcm0Hz/St k2uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695144125; x=1695748925; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R9KCoHYlrD8PBCS/9p9Xtjaer8cxRzRUbZnHNFMvu9U=; b=ICAuz0/JdG3K9Gab2mAXahoer1MjtLX2YlI7xF/dbHttmEfmQPd59zDWsq5b/XZ9m6 39OOLaWbHiGmPnl1onwb2HLlBZqJsCSLIss0KT7FWgRbi7U+V0NyZt08VQiQqLDYGPBd SIE+pkhEIZ2yp82eGdOEL6aTDtWHPhOUauHPgUV5D1B5Wt5bZUiUZmLxnOSkSZiBry3h Lct4LbEB0A8RZ+0vCdRf4MFToULCUPMPDd5paVC/r5CF+9o9am+SV6y2fz5DZI2lXTBZ vvt8VS877PuzNHKBx8CYDMcDKOS3lE0IAdSXRp7XgdmZsJj7iIYgAA0Mz3yD/AeA/P4u lExQ== X-Gm-Message-State: AOJu0Yw808iZURiY/VtjUU7kLqDf5wwM1vYcQecuWVfN+Pbgqgzv3RX3 vN+lXxNNYtWaBTPFXc31d4k= X-Google-Smtp-Source: AGHT+IHHr2iqkML01TMfqpkarox1Q/kZnuOFnlxS2seZbLI5P48153e7+p997Xn/FXR+PMgsoy/vHQ== X-Received: by 2002:a17:906:1092:b0:9a2:295a:9bbb with SMTP id u18-20020a170906109200b009a2295a9bbbmr52892eju.25.1695144124887; Tue, 19 Sep 2023 10:22:04 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id w26-20020a17090633da00b00988be3c1d87sm7947280eja.116.2023.09.19.10.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 10:22:04 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Vinod Koul , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Chen-Yu Tsai , Samuel Holland , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 46/59] dma: sun6i-dma: Convert to platform remove callback returning void Date: Tue, 19 Sep 2023 19:22:03 +0200 Message-ID: <13354858.uLZWGnKmhe@jernej-laptop> In-Reply-To: <20230919133207.1400430-47-u.kleine-koenig@pengutronix.de> References: <20230919133207.1400430-1-u.kleine-koenig@pengutronix.de> <20230919133207.1400430-47-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230919_102212_606453_29784103 X-CRM114-Status: GOOD ( 22.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 19. september 2023 ob 15:31:54 CEST je Uwe Kleine-K=F6nig napisa= l(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() is renamed to .remove(). > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej > --- > drivers/dma/sun6i-dma.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c > index 2469efddf540..583bf49031cf 100644 > --- a/drivers/dma/sun6i-dma.c > +++ b/drivers/dma/sun6i-dma.c > @@ -1470,7 +1470,7 @@ static int sun6i_dma_probe(struct platform_device > *pdev) return ret; > } > = > -static int sun6i_dma_remove(struct platform_device *pdev) > +static void sun6i_dma_remove(struct platform_device *pdev) > { > struct sun6i_dma_dev *sdc =3D platform_get_drvdata(pdev); > = > @@ -1484,13 +1484,11 @@ static int sun6i_dma_remove(struct platform_device > *pdev) reset_control_assert(sdc->rstc); > = > sun6i_dma_free(sdc); > - > - return 0; > } > = > static struct platform_driver sun6i_dma_driver =3D { > .probe =3D sun6i_dma_probe, > - .remove =3D sun6i_dma_remove, > + .remove_new =3D sun6i_dma_remove, > .driver =3D { > .name =3D "sun6i-dma", > .of_match_table =3D sun6i_dma_match, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel