Re: [PATCH 57/59] dma: xilinx: xilinx_dma: Convert to platform remove callback returning void

Vinod Koul
2023-09-28T07:48:06Z

On 28-09-23, 09:27, Uwe Kleine-König wrote:
>
> Good catch, I should add that to my pre-send checks. I fixed it in my
> tree, so an eventual v2 will be good. I'll wait a bit before resending.
>
> @Vinod: If you pick up this series, feel free to skip this patch or
> fixup with
>
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 0c363a1ed853..e40696f6f864 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -3242,8 +3242,6 @@ static int xilinx_dma_probe(struct platform_device *pdev)
> /**
> * xilinx_dma_remove - Driver remove function
> * @pdev: Pointer to the platform_device structure
> - *
> - * Return: Always '0'
> */
> static void xilinx_dma_remove(struct platform_device *pdev)
> {
>
> or apply as is (in which case I will follow up with a separate patch to
> fix this).

Follow up patch is easier to handle

Thanks
--
~Vinod