Re: [PATCH 45/59] dma: sun4i-dma: Convert to platform remove callback returning void

Jernej Škrabec
2023-09-19T17:22:11Z

Dne torek, 19. september 2023 ob 15:31:53 CEST je Uwe Kleine-König napisal(a):
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
> drivers/dma/sun4i-dma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c
> index e86c8829513a..2e7f9b07fdd2 100644
> --- a/drivers/dma/sun4i-dma.c
> +++ b/drivers/dma/sun4i-dma.c
> @@ -1271,7 +1271,7 @@ static int sun4i_dma_probe(struct platform_device
> *pdev) return ret;
> }
>
> -static int sun4i_dma_remove(struct platform_device *pdev)
> +static void sun4i_dma_remove(struct platform_device *pdev)
> {
> struct sun4i_dma_dev *priv = platform_get_drvdata(pdev);
>
> @@ -1282,8 +1282,6 @@ static int sun4i_dma_remove(struct platform_device
> *pdev) dma_async_device_unregister(&priv->slave);
>
> clk_disable_unprepare(priv->clk);
> -
> - return 0;
> }
>
> static const struct of_device_id sun4i_dma_match[] = {
> @@ -1294,7 +1292,7 @@ MODULE_DEVICE_TABLE(of, sun4i_dma_match);
>
> static struct platform_driver sun4i_dma_driver = {
> .probe = sun4i_dma_probe,
> - .remove = sun4i_dma_remove,
> + .remove_new = sun4i_dma_remove,
> .driver = {
> .name = "sun4i-dma",
> .of_match_table = sun4i_dma_match,