From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx6q: make ksz9021rn_phy_fixup depends on config of FEC
Date: Tue, 08 May 2012 16:47:29 +0300 [thread overview]
Message-ID: <1336484849.23308.41.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1336483275-8610-1-git-send-email-richard.zhao@freescale.com>
On Tue, 2012-05-08 at 21:21 +0800, Richard Zhao wrote:
> Fix build error without choose fec driver.
>
> Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
Reported-by: Artem Bityutskiy <dedekind1@gmail.com>
> +#if defined(CONFIG_FEC) || defined(CONFIG_FEC_MODULE)
I think there is a nicer way of doing this, something like
#include <linux/kconfig.h>
if (IS_ENABLED(CONFIG_FEC)) {
}
and you do not need the #ifdef ugliness.
--
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120508/fa5b32e3/attachment-0001.sig>
next prev parent reply other threads:[~2012-05-08 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 12:02 compilation issue Artem Bityutskiy
2012-05-08 13:21 ` [PATCH] ARM: imx6q: make ksz9021rn_phy_fixup depends on config of FEC Richard Zhao
2012-05-08 13:47 ` Artem Bityutskiy [this message]
2012-05-08 13:46 ` [PATCH] ARM: imx6q: register phy fixup only when CONFIG_PHYLIB is enabled Shawn Guo
2012-05-09 0:25 ` Richard Zhao
2012-05-09 0:57 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336484849.23308.41.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).