* [PATCH] ARM: OMAP4: hwspinlocks_init() should be static
@ 2012-05-13 13:15 Ohad Ben-Cohen
2012-06-04 7:40 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Ohad Ben-Cohen @ 2012-05-13 13:15 UTC (permalink / raw)
To: linux-arm-kernel
Sparse found out that hwspinlocks_init() wasn't marked static,
and it should've been.
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
---
arch/arm/mach-omap2/hwspinlock.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/hwspinlock.c b/arch/arm/mach-omap2/hwspinlock.c
index 454dfce..8763c85 100644
--- a/arch/arm/mach-omap2/hwspinlock.c
+++ b/arch/arm/mach-omap2/hwspinlock.c
@@ -28,7 +28,7 @@ static struct hwspinlock_pdata omap_hwspinlock_pdata __initdata = {
.base_id = 0,
};
-int __init hwspinlocks_init(void)
+static int __init hwspinlocks_init(void)
{
int retval = 0;
struct omap_hwmod *oh;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: OMAP4: hwspinlocks_init() should be static
2012-05-13 13:15 [PATCH] ARM: OMAP4: hwspinlocks_init() should be static Ohad Ben-Cohen
@ 2012-06-04 7:40 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-06-04 7:40 UTC (permalink / raw)
To: linux-arm-kernel
* Ohad Ben-Cohen <ohad@wizery.com> [120513 06:19]:
> Sparse found out that hwspinlocks_init() wasn't marked static,
> and it should've been.
Looks like this already got fixed by Paul's commit 8c3d4534.
Regards,
Tony
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> ---
> arch/arm/mach-omap2/hwspinlock.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/hwspinlock.c b/arch/arm/mach-omap2/hwspinlock.c
> index 454dfce..8763c85 100644
> --- a/arch/arm/mach-omap2/hwspinlock.c
> +++ b/arch/arm/mach-omap2/hwspinlock.c
> @@ -28,7 +28,7 @@ static struct hwspinlock_pdata omap_hwspinlock_pdata __initdata = {
> .base_id = 0,
> };
>
> -int __init hwspinlocks_init(void)
> +static int __init hwspinlocks_init(void)
> {
> int retval = 0;
> struct omap_hwmod *oh;
> --
> 1.7.5.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-04 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-13 13:15 [PATCH] ARM: OMAP4: hwspinlocks_init() should be static Ohad Ben-Cohen
2012-06-04 7:40 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).