From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 0/3] Add PMECC support for at91 nand flash driver
Date: Wed, 16 May 2012 12:17:38 +0300 [thread overview]
Message-ID: <1337159858.24809.21.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1337093256-19117-1-git-send-email-josh.wu@atmel.com>
On Tue, 2012-05-15 at 22:47 +0800, Josh Wu wrote:
> Changes since v6,
> split into 3 patches.
> remove of_flat_dt_is_compatible() function. use additional dt parameter "has-pmecc".
> refine the error handling code.
> refine original atmel_nand_init_params() function.
>
> Changes since v5,
> add has_pmecc field to replace cpu_has_pmecc() function. Use compatible check in when proble.
> simplify the pmecc_get_ecc_bytes() function.
>
> Changes since v4,
> fix typo and checkpatch warnings.
> fix according to JC's suggestion. replace cpu_is_xxx() with DT
> modify dt binding atmel nand document to add pmecc support.
> tested in sam9263 without break hw ecc.
> add ecc.strength.
Hi,
Aiaiai identified the following issues with your patch-set - could you
please take a look?
--------------------------------------------------------------------------------
Successfully built configuration "arm-at91cap9_defconfig,arm,arm-unknown-linux-gnueabi-", results:
--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/nand/atmel_nand.c: In function 'atmel_pmecc_nand_init_params':
+drivers/mtd/nand/atmel_nand.c:910:29: warning: assignment from incompatible pointer type [enabled by default]
+drivers/mtd/nand/atmel_nand.c:910:50: warning: incorrect type in assignment (different argument counts) [sparse]
+drivers/mtd/nand/atmel_nand.c:910:50: expected int ( *read_page )( ... ) [sparse]
+drivers/mtd/nand/atmel_nand.c:910:50: got int ( static [toplevel] *<noident> )( ... ) [sparse]
+drivers/mtd/nand/atmel_nand.c:912:30: warning: assignment from incompatible pointer type [enabled by default]
+drivers/mtd/nand/atmel_nand.c:912:51: warning: incorrect type in assignment (different argument counts) [sparse]
+drivers/mtd/nand/atmel_nand.c:912:51: expected void ( *write_page )( ... ) [sparse]
+drivers/mtd/nand/atmel_nand.c:912:51: got void ( static [toplevel] *<noident> )( ... ) [sparse]
--------------------------------------------------------------------------------
checkpatch.pl has some complaints:
--------------------------------------------------------------------------------
checkpatch.pl results for patch "[PATCH 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller"
WARNING:LONG_LINE: line over 80 characters
#60: FILE: drivers/mtd/nand/atmel_nand.c:115:
+ int16_t smu[AT_NB_ERROR_MAX + 2][2 * AT_NB_ERROR_MAX + 1];
WARNING:LONG_LINE: line over 80 characters
#326: FILE: drivers/mtd/nand/atmel_nand.c:567:
+ a = readw_relaxed(alpha_to + tmp % host->cw_len);
WARNING:LONG_LINE: line over 80 characters
#348: FILE: drivers/mtd/nand/atmel_nand.c:589:
+ a = readw_relaxed(index_of + host->smu[i + 1][k]);
total: 0 errors, 3 warnings, 879 lines checked
--------------------------------------------------------------------------------
checkpatch.pl results for the entire squashed patch-set
WARNING:LONG_LINE: line over 80 characters
#376: FILE: drivers/mtd/nand/atmel_nand.c:115:
+ int16_t smu[AT_NB_ERROR_MAX + 2][2 * AT_NB_ERROR_MAX + 1];
WARNING:LONG_LINE: line over 80 characters
#642: FILE: drivers/mtd/nand/atmel_nand.c:567:
+ a = readw_relaxed(alpha_to + tmp % host->cw_len);
WARNING:LONG_LINE: line over 80 characters
#664: FILE: drivers/mtd/nand/atmel_nand.c:589:
+ a = readw_relaxed(index_of + host->smu[i + 1][k]);
total: 0 errors, 3 warnings, 1136 lines checked
--------------------------------------------------------------------------------
--
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120516/34eaf287/attachment.sig>
next prev parent reply other threads:[~2012-05-16 9:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 14:47 [PATCH v7 0/3] Add PMECC support for at91 nand flash driver Josh Wu
2012-05-15 14:47 ` [PATCH v7 1/3] MTD: at91: extract hw ecc initialization to one function Josh Wu
2012-05-15 14:47 ` [PATCH v7 2/3] MTD: add dt parameters for PMECC Josh Wu
2012-05-15 14:47 ` [PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller Josh Wu
2012-05-16 9:25 ` Artem Bityutskiy
2012-05-16 9:31 ` Lothar Waßmann
2012-05-16 9:40 ` Artem Bityutskiy
2012-05-17 6:36 ` Josh Wu
2012-05-17 11:43 ` Artem Bityutskiy
2012-05-17 12:55 ` Russell King - ARM Linux
2012-05-18 11:54 ` Artem Bityutskiy
2012-05-16 9:17 ` Artem Bityutskiy [this message]
2012-05-17 6:32 ` [PATCH v7 0/3] Add PMECC support for at91 nand flash driver Josh Wu
2012-05-17 11:42 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337159858.24809.21.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).