From: ming.lei@canonical.com (Ming Lei)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: fix gpmc request_irq
Date: Fri, 18 May 2012 12:43:03 +0800 [thread overview]
Message-ID: <1337316183-1203-1-git-send-email-ming.lei@canonical.com> (raw)
The IRQ52 on OMAP2+ is not a shared interrupt line. If IRQF_SHARED
is passed to request_irq and dev_id is set as NULL, request_irq will
return -EINVAL.
This patch just removes the flag of IRQF_SHARED to make the irq
registration successful.
Cc: Kevin Hilman <khilman@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
arch/arm/mach-omap2/gpmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 2286410..e45d31b 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -769,7 +769,7 @@ static int __init gpmc_init(void)
irq++;
}
- ret = request_irq(gpmc_irq, gpmc_handle_irq, IRQF_SHARED, "gpmc", NULL);
+ ret = request_irq(gpmc_irq, gpmc_handle_irq, 0, "gpmc", NULL);
if (ret)
pr_err("gpmc: irq-%d could not claim: err %d\n",
gpmc_irq, ret);
--
1.7.9.5
next reply other threads:[~2012-05-18 4:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 4:43 Ming Lei [this message]
2012-05-18 7:03 ` [PATCH] ARM: OMAP2+: fix gpmc request_irq Shilimkar, Santosh
2012-05-18 7:16 ` Mohammed, Afzal
2012-05-18 7:19 ` Shilimkar, Santosh
2012-05-18 7:40 ` Ming Lei
2012-05-18 7:43 ` Shilimkar, Santosh
2012-05-18 9:04 ` Ming Lei
2012-05-18 10:13 ` Shilimkar, Santosh
2012-05-18 10:51 ` Mohammed, Afzal
2012-05-18 10:59 ` Shilimkar, Santosh
2012-05-18 11:47 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337316183-1203-1-git-send-email-ming.lei@canonical.com \
--to=ming.lei@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).