linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/16] ARM: ux500: Only initialise STE's UIBs on boards which support them
Date: Fri, 18 May 2012 09:39:03 +0100	[thread overview]
Message-ID: <1337330355-17747-5-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1337330355-17747-1-git-send-email-lee.jones@linaro.org>

ST-Ericsson uses User Interface Boards to extend functionality of
some of their development boards. However, these aren't compatible
with all the supported boards found in Mainline (Snowball for
instance). This patch ensures that the UIBs are only probed on
boards which can actually support them. This in turn saves lots of
unnecessary error messages normally found in Snowball's boot log.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/mach-ux500/board-mop500-uib.c |    4 +---
 arch/arm/mach-ux500/board-mop500.c     |    8 ++++++++
 arch/arm/mach-ux500/board-mop500.h     |    1 +
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-ux500/board-mop500-uib.c b/arch/arm/mach-ux500/board-mop500-uib.c
index b29a788..1f47d96 100644
--- a/arch/arm/mach-ux500/board-mop500-uib.c
+++ b/arch/arm/mach-ux500/board-mop500-uib.c
@@ -96,7 +96,7 @@ static void __init __mop500_uib_init(struct uib *uib, const char *why)
 /*
  * Detect the UIB attached based on the presence or absence of i2c devices.
  */
-static int __init mop500_uib_init(void)
+int __init mop500_uib_init(void)
 {
 	struct uib *uib = mop500_uib;
 	struct i2c_adapter *i2c0;
@@ -131,5 +131,3 @@ static int __init mop500_uib_init(void)
 
 	return 0;
 }
-
-module_init(mop500_uib_init);
diff --git a/arch/arm/mach-ux500/board-mop500.c b/arch/arm/mach-ux500/board-mop500.c
index 8845286..faa46b1 100644
--- a/arch/arm/mach-ux500/board-mop500.c
+++ b/arch/arm/mach-ux500/board-mop500.c
@@ -635,6 +635,8 @@ static void __init mop500_init_machine(void)
 
 	/* This board has full regulator constraints */
 	regulator_has_full_constraints();
+
+	mop500_uib_init();
 }
 
 static void __init snowball_init_machine(void)
@@ -699,6 +701,8 @@ static void __init hrefv60_init_machine(void)
 
 	/* This board has full regulator constraints */
 	regulator_has_full_constraints();
+
+	mop500_uib_init();
 }
 
 MACHINE_START(U8500, "ST-Ericsson MOP500 platform")
@@ -809,6 +813,8 @@ static void __init u8500_init_machine(void)
 		i2c_register_board_info(2, mop500_i2c2_devices,
 					ARRAY_SIZE(mop500_i2c2_devices));
 
+		mop500_uib_init();
+
 	} else if (of_machine_is_compatible("calaosystems,snowball-a9500")) {
 		//snowball_pins_init();
 
@@ -842,6 +848,8 @@ static void __init u8500_init_machine(void)
 		i2c_register_board_info(0, mop500_i2c0_devices, i2c0_devs);
 		i2c_register_board_info(2, mop500_i2c2_devices,
 					ARRAY_SIZE(mop500_i2c2_devices));
+
+		mop500_uib_init();
 	}
 
 	/* This board has full regulator constraints */
diff --git a/arch/arm/mach-ux500/board-mop500.h b/arch/arm/mach-ux500/board-mop500.h
index 44ab4bd..b5bfc1a 100644
--- a/arch/arm/mach-ux500/board-mop500.h
+++ b/arch/arm/mach-ux500/board-mop500.h
@@ -92,6 +92,7 @@ void __init mop500_pinmaps_init(void);
 void __init snowball_pinmaps_init(void);
 void __init hrefv60_pinmaps_init(void);
 
+int __init mop500_uib_init(void);
 void mop500_uib_i2c_add(int busnum, struct i2c_board_info *info,
 		unsigned n);
 
-- 
1.7.9.5

  parent reply	other threads:[~2012-05-18  8:39 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18  8:38 [PATCH 00/16] The last large installment of DT for Snowball Lee Jones
2012-05-18  8:39 ` [PATCH 01/16] Input: Add Device Tree support to the ab8500-ponkey driver Lee Jones
2012-05-21 21:32   ` Linus Walleij
2012-06-12  7:22     ` Dmitry Torokhov
2012-05-18  8:39 ` [PATCH 02/16] ARM: ux500: Enable LED heartbeat functionality on Snowball Lee Jones
2012-05-21 21:33   ` Linus Walleij
2012-05-22  7:38     ` Lee Jones
2012-05-18  8:39 ` [PATCH 03/16] ARM: ux500: Enable LED heartbeat functionality on Snowbal via DT Lee Jones
2012-05-21 21:34   ` Linus Walleij
2012-05-18  8:39 ` Lee Jones [this message]
2012-05-21 21:36   ` [PATCH 04/16] ARM: ux500: Only initialise STE's UIBs on boards which support them Linus Walleij
2012-05-22  7:39     ` Lee Jones
2012-05-18  8:39 ` [PATCH 05/16] regulator: db8500-prcmu: Separate regulator registration from probe Lee Jones
2012-05-18 15:36   ` Mark Brown
2012-05-21  6:58   ` Linus Walleij
2012-05-18  8:39 ` [PATCH 06/16] ARM: ux500: Apply db8500-prcmu regulator information to db8500 Device Tree Lee Jones
2012-05-21 21:37   ` Linus Walleij
2012-05-22  7:41     ` Lee Jones
2012-05-29  1:51   ` Linus Walleij
2012-05-18  8:39 ` [PATCH 07/16] regulator: Enable Device Tree for the db8500-prcmu regulator driver Lee Jones
2012-05-18 15:36   ` Mark Brown
2012-05-21  6:59   ` Linus Walleij
2012-05-18  8:39 ` [PATCH 08/16] ARM: ux500: Allow PRCMU regulator to be probed during a DT enabled boot Lee Jones
2012-05-21 21:37   ` Linus Walleij
2012-05-18  8:39 ` [PATCH 09/16] ARM: ux500: Provide regulator support for SMSC911x via Device Tree Lee Jones
2012-05-21 21:42   ` Linus Walleij
2012-05-22  6:44     ` Arnd Bergmann
2012-05-22  7:46     ` Lee Jones
2012-05-18  8:39 ` [PATCH 10/16] ARM: ux500: Add db8500 Device Tree node for ab8500-sysctrl Lee Jones
2012-05-21 21:43   ` Linus Walleij
2012-05-18  8:39 ` [PATCH 11/16] mfd: Enable Device Tree support in the ab8500-sysctrl driver Lee Jones
2012-05-19 15:35   ` Samuel Ortiz
2012-05-18  8:39 ` [PATCH 12/16] ARM: ux500: Add db8500 Device Tree node for misc/ab8500-pwm Lee Jones
2012-05-21 21:43   ` Linus Walleij
2012-05-18  8:39 ` [PATCH 13/16] mfd: Enable Device Tree support in the ab8500-pwm driver Lee Jones
2012-05-19 15:35   ` Samuel Ortiz
2012-05-18  8:39 ` [PATCH 14/16] ARM: ux500: Add a ab8500-usb Device Tree node for db8500 based devices Lee Jones
2012-05-21 21:44   ` Linus Walleij
2012-05-18  8:39 ` [PATCH 15/16] ARM: ux500: Add regulator support for nomadik-i2c into the db8500 Device Tree Lee Jones
2012-05-21 21:45   ` Linus Walleij
2012-05-22  8:00     ` Lee Jones
2012-05-29  1:53       ` Linus Walleij
2012-05-29  4:50         ` Lee Jones
2012-05-30  0:09           ` Linus Walleij
2012-05-30  0:33             ` Lee Jones
2012-05-30  2:51               ` Linus Walleij
2012-05-18  8:39 ` [PATCH 16/16] ARM: ux500: Re-enable SMSC911x platform code registration during non-DT boots Lee Jones
2012-05-21 21:46   ` Linus Walleij
2012-05-22  8:01     ` Lee Jones
2012-05-29  1:54       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337330355-17747-5-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).