From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB19C433FF for ; Wed, 31 Jul 2019 16:40:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7F65206A2 for ; Wed, 31 Jul 2019 16:40:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Prrjm0Gf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7F65206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G4RYntUNfB/ZuLj8HMjHWhE7UqP7g1QXN8zuNYgs+ZU=; b=Prrjm0GfwXjaeh OOcGyrRTOBX8irHYiIOa0yzP7Ckrk997fmuSsjMDlhIQBIr0pHnynIwZX8JRX/vk39Bn11nHLMl5h tg7xPCUsMIAwyhWUhyyW5jX8i4zsfaUtA5auHCsv3M/2BShH0y2M2bAr6bgSAZiWb9fxW5nXccFgD Kc0whQt6fTa8MY+wTC0TrA2Fo5cdYiAh931MIAQ9G9Pb+SEo9hgIdWcQlFbv2Wkb2ik/4iYuA+igk MLksw0SHkQY2xkfoBLbYSRo5OctznX49kvaSZXmJJ7D7tCk4kGpiYCCEVSFcq3ZPBgEEVIk1zouUY 6z0sIgfSfPq/lrryyO1A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsreK-0005T3-6l; Wed, 31 Jul 2019 16:40:24 +0000 Received: from mailoutvs15.siol.net ([185.57.226.206] helo=mail.siol.net) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsreG-0005Rl-M7 for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2019 16:40:22 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTP id 7B0A05209AE; Wed, 31 Jul 2019 18:40:08 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta12.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta12.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id fXh7Bj71aPKg; Wed, 31 Jul 2019 18:40:08 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTPS id 84F755233C1; Wed, 31 Jul 2019 18:40:07 +0200 (CEST) Received: from jernej-laptop.localnet (cpe-194-152-11-237.cable.triera.net [194.152.11.237]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Zimbra) with ESMTPA id 488405209AE; Wed, 31 Jul 2019 18:40:04 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Fabio Estevam Subject: Re: [PATCH 3/3] drm/bridge: Add NWL MIPI DSI host controller support Date: Wed, 31 Jul 2019 18:40:03 +0200 Message-ID: <13373313.BzCyiC4ED7@jernej-laptop> In-Reply-To: References: <20190731143532.GA1935@bogon.m.sigxcpu.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190731_094020_888449_CE219245 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Pengutronix Kernel Team , Neil Armstrong , David Airlie , Lee Jones , Guido =?ISO-8859-1?Q?G=FCnther?= , Jonas Karlman , linux-kernel , DRI mailing list , Andrzej Hajda , Rob Herring , NXP Linux Team , Daniel Vetter , Robert Chiras , Chris Healy , Shawn Guo , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Laurent Pinchart Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! Dne sreda, 31. julij 2019 ob 16:43:47 CEST je Fabio Estevam napisal(a): > Hi Guido, > = > On Wed, Jul 31, 2019 at 11:35 AM Guido G=FCnther wrote: > > The idea is to have > > = > > "%sabling platform clocks", enable ? "en" : "dis"); > > = > > depending whether clocks are enabled/disabled. > = > Yes, I understood the idea, but this would print: > = > ensabling or dissabling :-) No, it wouldn't. That extra "s" is part of "%s", e.g. part of format specif= ier. Best regards, Jernej > = > > > Same here. Please return 'int' instead. > > = > > This is from drm_bridge_funcs so the prototype is fixed. I'm not sure > > how what's the best way to bubble up fatal errors through the drm layer? > = > Ok, so let's not change this one. > = > > I went for DRM_DEV_ERROR() since that what i used in the rest of the > > driver and these ones were omission. Hope that's o.k. > = > No strong preferences here. I just think dev_err() easier to type and > shorter. > = > Thanks for this work! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel