From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller
Date: Fri, 18 May 2012 14:54:23 +0300 [thread overview]
Message-ID: <1337342063.2483.37.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20120517125544.GJ9571@n2100.arm.linux.org.uk>
On Thu, 2012-05-17 at 13:55 +0100, Russell King - ARM Linux wrote:
> > You can just remove the backslashes. I think your lines splitting is
> > fine otherwise.
>
> It's also preferred _not_ to wrap error messages as that makes them
> harder to grep for. Linus has mentioned this several times on LKML
> and has corrected error messages that he encounters that he can't
> find via grep.
OK, thanks for the info.
One could argue that it probably only makes sense to avoid splitting up
to the first %d or another printk placeholder. Beyond the placeholder
grepping is not more difficult.
Well, anyway, I would not like to force people to split or not split
strings. I'd also say that it is more important to follow the style of
the driver/subsystem and be consistent.
--
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120518/3d47ab6c/attachment.sig>
next prev parent reply other threads:[~2012-05-18 11:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 14:47 [PATCH v7 0/3] Add PMECC support for at91 nand flash driver Josh Wu
2012-05-15 14:47 ` [PATCH v7 1/3] MTD: at91: extract hw ecc initialization to one function Josh Wu
2012-05-15 14:47 ` [PATCH v7 2/3] MTD: add dt parameters for PMECC Josh Wu
2012-05-15 14:47 ` [PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller Josh Wu
2012-05-16 9:25 ` Artem Bityutskiy
2012-05-16 9:31 ` Lothar Waßmann
2012-05-16 9:40 ` Artem Bityutskiy
2012-05-17 6:36 ` Josh Wu
2012-05-17 11:43 ` Artem Bityutskiy
2012-05-17 12:55 ` Russell King - ARM Linux
2012-05-18 11:54 ` Artem Bityutskiy [this message]
2012-05-16 9:17 ` [PATCH v7 0/3] Add PMECC support for at91 nand flash driver Artem Bityutskiy
2012-05-17 6:32 ` Josh Wu
2012-05-17 11:42 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337342063.2483.37.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).