From: hs@denx.de (Heiko Schocher)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/7] ARM: davinci, intc: Add OF support for TI interrupt controller
Date: Tue, 22 May 2012 15:55:15 +0200 [thread overview]
Message-ID: <1337694920-8925-3-git-send-email-hs@denx.de> (raw)
In-Reply-To: <1337694920-8925-1-git-send-email-hs@denx.de>
Add a function to initialize the Common Platform Interrupt Controller
(cp_intc) from TI used on OMAP-L1x SoCs using a device tree node.
Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: davinci-linux-open-source at linux.davincidsp.com
Cc: linux-arm-kernel at lists.infradead.org
Cc: devicetree-discuss at lists.ozlabs.org
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>
---
- changes for v4
- split patch in 2 patches, one for irq_domain adaption
one for DT enhancement, as Nori Sekhar suggested.
- add comment from Grant Likely for the DT part:
remove if/else clause, not needed.
Make use of DT runtime configurable
.../devicetree/bindings/arm/davinci/intc.txt | 27 ++++++++++++++++++++
arch/arm/mach-davinci/cp_intc.c | 26 ++++++++++++++++---
2 files changed, 49 insertions(+), 4 deletions(-)
create mode 100644 Documentation/devicetree/bindings/arm/davinci/intc.txt
diff --git a/Documentation/devicetree/bindings/arm/davinci/intc.txt b/Documentation/devicetree/bindings/arm/davinci/intc.txt
new file mode 100644
index 0000000..dfd6a560
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/davinci/intc.txt
@@ -0,0 +1,27 @@
+* TI Common Platform Interrupt Controller
+
+Common Platform Interrupt Controller (cp_intc) is used on
+OMAP-L1x SoCs and can support several configurable number
+of interrupts.
+
+Main node required properties:
+
+- compatible : should be:
+ "ti,cp_intc"
+- interrupt-controller : Identifies the node as an interrupt controller
+- #interrupt-cells : Specifies the number of cells needed to encode an
+ interrupt source. The type shall be a <u32> and the value shall be 1.
+
+ The cell contains the interrupt number in the range [0-128].
+- ti,intc-size: Number of interrupts handled by the interrupt controller.
+- reg: physical base address and size of the intc registers map.
+
+Example:
+
+ intc: interrupt-controller at 1 {
+ compatible = "ti,cp_intc";
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ ti,intc-size = <101>;
+ reg = <0xfffee000 0x2000>;
+ };
diff --git a/arch/arm/mach-davinci/cp_intc.c b/arch/arm/mach-davinci/cp_intc.c
index bb52807..f9ad14e 100644
--- a/arch/arm/mach-davinci/cp_intc.c
+++ b/arch/arm/mach-davinci/cp_intc.c
@@ -14,6 +14,9 @@
#include <linux/irq.h>
#include <linux/irqdomain.h>
#include <linux/io.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
#include <mach/common.h>
#include <mach/cp_intc.h>
@@ -119,7 +122,7 @@ static const struct irq_domain_ops cp_intc_host_ops = {
.xlate = irq_domain_xlate_onetwocell,
};
-int __init __cp_intc_init(struct device_node *node)
+int __init __cp_intc_init(struct device_node *node, struct device_node *parent)
{
u32 num_irq = davinci_soc_info.intc_irq_num;
u8 *irq_prio = davinci_soc_info.intc_irq_prios;
@@ -128,8 +131,15 @@ int __init __cp_intc_init(struct device_node *node)
int i, irq_base;
davinci_intc_type = DAVINCI_INTC_TYPE_CP_INTC;
- davinci_intc_base = ioremap(davinci_soc_info.intc_base, SZ_8K);
-
+ if (node) {
+ davinci_intc_base = of_iomap(node, 0);
+ if (of_property_read_u32(node, "ti,intc-size", &num_irq))
+ pr_warn("unable to get intc-size, default to %d\n",
+ num_irq);
+ } else {
+ davinci_intc_base = ioremap(davinci_soc_info.intc_base,
+ SZ_8K);
+ }
if (WARN_ON(!davinci_intc_base))
return -EINVAL;
@@ -207,7 +217,15 @@ int __init __cp_intc_init(struct device_node *node)
return 0;
}
+static struct of_device_id irq_match[] __initdata = {
+ { .compatible = "ti,cp_intc", .data = __cp_intc_init, },
+ { }
+};
+
void __init cp_intc_init(void)
{
- __cp_intc_init(NULL);
+ if (!of_find_compatible_node(NULL, NULL, "ti,cp_intc"))
+ __cp_intc_init(NULL, NULL);
+ else
+ of_irq_init(irq_match);
}
--
1.7.7.6
next prev parent reply other threads:[~2012-05-22 13:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 13:55 [PATCH v4 0/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 1/7] ARM: davinci, intc: Add irq domain support Heiko Schocher
2012-05-22 15:51 ` Sergei Shtylyov
2012-05-26 6:03 ` Grant Likely
2012-05-29 13:11 ` Heiko Schocher
2012-05-22 13:55 ` Heiko Schocher [this message]
2012-05-22 13:55 ` [PATCH v4 3/7] ARM: davinci: configure davinci aemif chipselects through OF Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 4/7] ARM: davinci: net: davinci_emac: add OF support Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 5/7] ARM: davinci: i2c: " Heiko Schocher
2012-05-26 6:08 ` Grant Likely
2012-05-29 13:28 ` Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 6/7] ARM: mtd: nand: davinci: add OF support for davinci nand controller Heiko Schocher
2012-05-22 13:55 ` [PATCH v4 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337694920-8925-3-git-send-email-hs@denx.de \
--to=hs@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).