* [PATCH] Avoid needing export of include/asm-generic/kvm_para.h
@ 2012-05-29 14:45 William Cohen
2012-05-29 14:45 ` William Cohen
0 siblings, 1 reply; 2+ messages in thread
From: William Cohen @ 2012-05-29 14:45 UTC (permalink / raw)
To: linux-arm-kernel
The kernel build checks (header_checks.pl) to verify that installed include
files do not include uninstalled files. When attempting to build the mainline
kernel from the git repository the build would fail on ARM machines
because these checks would determine that the ARM's version of kvm_para.h
was including asm-generic/kvm_para.h which is not installed.
The asm-generic/kvm_para.h didn't seem to have anything that really should
be visible outside, so made arm use a generated head file instead.
It looks like similiar patches may be be needed for other architectures due
to commit 3b5d56b9317fa7b5407dff1aa7b115bf6cdbd494 (kvmclock: Add functions
to check if the host has stopped the vm)
William Cohen (1):
Avoid needing export of include/asm-generic/kvm_para.h
arch/arm/include/asm/Kbuild | 1 +
arch/arm/include/asm/kvm_para.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
delete mode 100644 arch/arm/include/asm/kvm_para.h
--
1.7.10.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] Avoid needing export of include/asm-generic/kvm_para.h
2012-05-29 14:45 [PATCH] Avoid needing export of include/asm-generic/kvm_para.h William Cohen
@ 2012-05-29 14:45 ` William Cohen
0 siblings, 0 replies; 2+ messages in thread
From: William Cohen @ 2012-05-29 14:45 UTC (permalink / raw)
To: linux-arm-kernel
The include/asm-generic/kvm_para.h is not normally an exported file.
If it is used in $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h,
later checks will flag that as an error because the
asm-generic/kvm_para.h head is not installed. The
asm-generic/kvm_para.h has information that is only used during the
build of the kernel and should not be exported. The
arch/arm/include/asm/kvm_para.h should be a generic generated file
instead.
Signed-off-by: William Cohen <wcohen@redhat.com>
---
arch/arm/include/asm/Kbuild | 1 +
arch/arm/include/asm/kvm_para.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
delete mode 100644 arch/arm/include/asm/kvm_para.h
diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild
index 960abce..3f45eb9 100644
--- a/arch/arm/include/asm/Kbuild
+++ b/arch/arm/include/asm/Kbuild
@@ -10,6 +10,7 @@ generic-y += errno.h
generic-y += ioctl.h
generic-y += irq_regs.h
generic-y += kdebug.h
+generic-y += kvm_para.h
generic-y += local.h
generic-y += local64.h
generic-y += percpu.h
diff --git a/arch/arm/include/asm/kvm_para.h b/arch/arm/include/asm/kvm_para.h
deleted file mode 100644
index 14fab8f..0000000
--- a/arch/arm/include/asm/kvm_para.h
+++ /dev/null
@@ -1 +0,0 @@
-#include <asm-generic/kvm_para.h>
--
1.7.10.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-29 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-29 14:45 [PATCH] Avoid needing export of include/asm-generic/kvm_para.h William Cohen
2012-05-29 14:45 ` William Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).