linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/22] ARM: ux500: Only initialise STE's UIBs on boards which support them
Date: Wed, 30 May 2012 12:47:29 +0800	[thread overview]
Message-ID: <1338353260-10097-12-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1338353260-10097-1-git-send-email-lee.jones@linaro.org>

ST-Ericsson uses User Interface Boards to extend functionality of
some of their development boards. However, these aren't compatible
with all the supported boards found in Mainline (Snowball for
instance). This patch ensures that the UIBs are only probed on
boards which can actually support them. This in turn saves lots of
unnecessary error messages normally found in Snowball's boot log.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/mach-ux500/board-mop500-uib.c |    4 +---
 arch/arm/mach-ux500/board-mop500.c     |    8 ++++++++
 arch/arm/mach-ux500/board-mop500.h     |    1 +
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-ux500/board-mop500-uib.c b/arch/arm/mach-ux500/board-mop500-uib.c
index b29a788..1f47d96 100644
--- a/arch/arm/mach-ux500/board-mop500-uib.c
+++ b/arch/arm/mach-ux500/board-mop500-uib.c
@@ -96,7 +96,7 @@ static void __init __mop500_uib_init(struct uib *uib, const char *why)
 /*
  * Detect the UIB attached based on the presence or absence of i2c devices.
  */
-static int __init mop500_uib_init(void)
+int __init mop500_uib_init(void)
 {
 	struct uib *uib = mop500_uib;
 	struct i2c_adapter *i2c0;
@@ -131,5 +131,3 @@ static int __init mop500_uib_init(void)
 
 	return 0;
 }
-
-module_init(mop500_uib_init);
diff --git a/arch/arm/mach-ux500/board-mop500.c b/arch/arm/mach-ux500/board-mop500.c
index ea6082a..6b3fef5 100644
--- a/arch/arm/mach-ux500/board-mop500.c
+++ b/arch/arm/mach-ux500/board-mop500.c
@@ -716,6 +716,8 @@ static void __init mop500_init_machine(void)
 
 	/* This board has full regulator constraints */
 	regulator_has_full_constraints();
+
+	mop500_uib_init();
 }
 
 static void __init snowball_init_machine(void)
@@ -780,6 +782,8 @@ static void __init hrefv60_init_machine(void)
 
 	/* This board has full regulator constraints */
 	regulator_has_full_constraints();
+
+	mop500_uib_init();
 }
 
 MACHINE_START(U8500, "ST-Ericsson MOP500 platform")
@@ -883,6 +887,8 @@ static void __init u8500_init_machine(void)
 		i2c_register_board_info(2, mop500_i2c2_devices,
 					ARRAY_SIZE(mop500_i2c2_devices));
 
+		mop500_uib_init();
+
 	} else if (of_machine_is_compatible("calaosystems,snowball-a9500")) {
 		/*
 		 * Devices to be DT:ed:
@@ -913,6 +919,8 @@ static void __init u8500_init_machine(void)
 		i2c_register_board_info(0, mop500_i2c0_devices, i2c0_devs);
 		i2c_register_board_info(2, mop500_i2c2_devices,
 					ARRAY_SIZE(mop500_i2c2_devices));
+
+		mop500_uib_init();
 	}
 	mop500_i2c_init(parent);
 
diff --git a/arch/arm/mach-ux500/board-mop500.h b/arch/arm/mach-ux500/board-mop500.h
index 3be0cb8..2f87b25 100644
--- a/arch/arm/mach-ux500/board-mop500.h
+++ b/arch/arm/mach-ux500/board-mop500.h
@@ -89,6 +89,7 @@ void __init mop500_pinmaps_init(void);
 void __init snowball_pinmaps_init(void);
 void __init hrefv60_pinmaps_init(void);
 
+int __init mop500_uib_init(void);
 void mop500_uib_i2c_add(int busnum, struct i2c_board_info *info,
 		unsigned n);
 
-- 
1.7.9.5

  parent reply	other threads:[~2012-05-30  4:47 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30  4:47 [PATCH 01/22] Fixes and clean-ups for Device Tree on Snowball Lee Jones
2012-05-30  4:47 ` [PATCH 01/22] ARM: ux500: New DT:ed snowball_platform_devs for one-by-one device enablement Lee Jones
2012-05-30  4:47 ` [PATCH 02/22] ARM: ux500: New DT:ed u8500_init_devices " Lee Jones
2012-05-30  4:47 ` [PATCH 03/22] ARM: ux500: Disable SMSC911x platform code registration when DT is enabled Lee Jones
2012-05-30  4:47 ` [PATCH 04/22] ARM: ux500: Remove DB8500 PRCMU platform " Lee Jones
2012-05-30  6:48   ` Linus Walleij
2012-05-30  4:47 ` [PATCH 05/22] ARM: ux500: PRCMU related configuration and layout corrections for Device Tree Lee Jones
2012-05-30  4:47 ` [PATCH 06/22] ARM: ux500: Re-enable SMSC911x platform code registration during non-DT boots Lee Jones
2012-05-30  4:47 ` [PATCH 07/22] ARM: ux500: Use correct format for dynamic IRQ assignment Lee Jones
2012-05-30  4:47 ` [PATCH 08/22] regulator: Change ab8500 match names to reflect Device Tree Lee Jones
2012-05-30  6:58   ` Linus Walleij
2012-05-30 10:03     ` Mark Brown
2012-05-30 11:40       ` Lee Jones
2012-05-30 12:15         ` Mark Brown
2012-05-30 15:01           ` Lee Jones
2012-05-30 15:11             ` Mark Brown
2012-05-30 15:22               ` Lee Jones
2012-05-30 16:41                 ` Mark Brown
2012-05-31  0:42                   ` Lee Jones
2012-06-01  4:36                   ` Lee Jones
2012-06-01  8:48                     ` Mark Brown
2012-06-05 10:31                       ` Lee Jones
2012-06-05 10:38                         ` Mark Brown
2012-06-11 10:27                           ` Lee Jones
2012-06-11 10:36                             ` Mark Brown
2012-06-11 11:28                               ` Lee Jones
2012-06-11 11:42                                 ` Mark Brown
2012-05-31  1:40     ` Linus Walleij
2012-06-01 14:32   ` Mark Brown
2012-05-30  4:47 ` [PATCH 09/22] regulator: Change db8500-prcmu " Lee Jones
2012-05-30  7:00   ` Linus Walleij
2012-06-05 10:24   ` Lee Jones
2012-06-05 10:29     ` Mark Brown
2012-06-05 10:34       ` Lee Jones
2012-06-05 10:42         ` Mark Brown
2012-06-06  8:17           ` Lee Jones
2012-06-11 11:21           ` Lee Jones
2012-06-11 12:08             ` Mark Brown
2012-06-11 13:34               ` Lee Jones
2012-06-11 14:07                 ` Lee Jones
2012-06-11 14:27                   ` Mark Brown
2012-06-11 14:50                     ` Lee Jones
2012-06-11 15:15                       ` Mark Brown
2012-06-11 15:18                         ` Lee Jones
2012-06-11 15:39                           ` Mark Brown
2012-06-11 15:59                             ` Lee Jones
2012-06-11 16:09                               ` Mark Brown
2012-05-30  4:47 ` [PATCH 10/22] ARM: ux500: Disable platform setup of the ab8500 when DT is enabled Lee Jones
2012-05-30  4:47 ` Lee Jones [this message]
2012-05-30  4:47 ` [PATCH 12/22] ARM: ux500: Apply db8500-prcmu regulator information to db8500 Device Tree Lee Jones
2012-05-30  4:47 ` [PATCH 13/22] ARM: ux500: Allow PRCMU regulator to be probed during a DT enabled boot Lee Jones
2012-05-30  4:47 ` [PATCH 14/22] ARM: ux500: Provide regulator support for SMSC911x via Device Tree Lee Jones
2012-05-30  7:05   ` Linus Walleij
2012-05-30  4:47 ` [PATCH 15/22] ARM: ux500: Add support for ab8500 regulators into the " Lee Jones
2012-05-30  4:47 ` [PATCH 16/22] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a threaded IRQ Lee Jones
2012-05-30  7:10   ` Linus Walleij
2012-06-29 13:21   ` Samuel Ortiz
2012-05-30  4:47 ` [PATCH 17/22] rtc: ab8500-rtc: " Lee Jones
2012-05-30  7:11   ` [rtc-linux] " Linus Walleij
2012-05-30  4:47 ` [PATCH 18/22] mfd: Remove redundant Kconfig entry Lee Jones
2012-05-30  7:15   ` Linus Walleij
2012-05-30  7:37     ` Lee Jones
2012-05-30  7:43       ` Linus Walleij
2012-06-29 13:24   ` Samuel Ortiz
2012-05-30  4:47 ` [PATCH 19/22] net/smsc911x: Repair broken failure paths Lee Jones
2012-05-30  7:16   ` Linus Walleij
2012-05-30 21:52     ` David Miller
2012-05-30  4:47 ` [PATCH 20/22] pinctrl-nomadik: Allow Device Tree driver probing Lee Jones
2012-05-30  7:18   ` Linus Walleij
2012-05-30  4:47 ` [PATCH 21/22] ARM: ux500: Enable probing of pinctrl through Device Tree Lee Jones
2012-05-30  7:18   ` Linus Walleij
2012-05-30  4:47 ` [PATCH 22/22] mfd: Enable DT probing of the DB8500 PRCMU Lee Jones
2012-05-30  7:19   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338353260-10097-12-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).