linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 8/9] ARM: OMAP3: prevent per_clkdm from attempting manual domain transitions
Date: Thu, 31 May 2012 16:29:01 +0300	[thread overview]
Message-ID: <1338470942-20185-9-git-send-email-t-kristo@ti.com> (raw)
In-Reply-To: <1338470942-20185-1-git-send-email-t-kristo@ti.com>

Previously, PER clock domain was always enabled, as the usecounts
for this domain incorrectly always showed positive value. On HW
level though, the domain enters idle as it is set in HW supervised
mode. Now, when the usecounts reflect real values, PER domain will
attempt to enter software supervised idle, which is not supported by the
hardware/kernel that well, and causes multiple problems. First of all,
coming back from idle, PER domain remains idle as the wakedeps have
been disabled for the domain, and this causes a crash with the GPIO
code, as the resume code attempts to access domain which is not active.
Just enabling the interface clocks for the GPIO does not help, as they
are autoidled and don't bring the domain out of idle. Secondly, there
are multiple erratas for omap3, which say that the wakedeps should be
enabled for the PER domain, see e.g. errata i582 for omap3630.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
 arch/arm/mach-omap2/clockdomains3xxx_data.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c
index 6038adb..0dae4c8 100644
--- a/arch/arm/mach-omap2/clockdomains3xxx_data.c
+++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c
@@ -282,7 +282,7 @@ static struct clockdomain usbhost_clkdm = {
 static struct clockdomain per_clkdm = {
 	.name		= "per_clkdm",
 	.pwrdm		= { .name = "per_pwrdm" },
-	.flags		= CLKDM_CAN_HWSUP_SWSUP,
+	.flags		= CLKDM_CAN_HWSUP_SWSUP | CLKDM_SKIP_MANUAL_TRANS,
 	.dep_bit	= OMAP3430_EN_PER_SHIFT,
 	.wkdep_srcs	= per_wkdeps,
 	.sleepdep_srcs	= per_sleepdeps,
-- 
1.7.4.1

  parent reply	other threads:[~2012-05-31 13:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-31 13:28 [PATCHv3 0/9] ARM: OMAP3+: pwrdm changes for usecounting Tero Kristo
2012-05-31 13:28 ` [PATCHv3 1/9] ARM: OMAP: clk: add support for omap_clk_for_each Tero Kristo
2012-05-31 13:28 ` [PATCHv3 2/9] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking Tero Kristo
2012-06-01 10:13   ` Menon, Nishanth
2012-06-01 10:27     ` Paul Walmsley
2012-06-04  9:38       ` Tero Kristo
2012-05-31 13:28 ` [PATCHv3 3/9] ARM: OMAP3+: voltage: add support for voltagedomain usecounts Tero Kristo
2012-05-31 13:28 ` [PATCHv3 4/9] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting Tero Kristo
2012-05-31 13:28 ` [PATCHv3 5/9] ARM: OMAP3: set autoidle flags for a few clocks Tero Kristo
2012-07-12  9:13   ` Rajendra Nayak
2012-07-12 15:32     ` Tero Kristo
2012-05-31 13:28 ` [PATCHv3 6/9] ARM: OMAP: pm-debug: enhanced usecount debug support Tero Kristo
2012-05-31 13:29 ` [PATCHv3 7/9] ARM: OMAP: clockdomain: add support for preventing domain transitions Tero Kristo
2012-05-31 13:29 ` Tero Kristo [this message]
2012-05-31 23:40   ` [PATCHv3 8/9] ARM: OMAP3: prevent per_clkdm from attempting manual " Jon Hunter
2012-06-01  8:06     ` Tero Kristo
2012-07-12  9:41   ` Rajendra Nayak
2012-07-12 15:35     ` Tero Kristo
2012-05-31 13:29 ` [PATCHv3 9/9] TEMP: ARM: OMAP3: prevent dpll4 manual enable / disable + prevent core clkdm idle Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338470942-20185-9-git-send-email-t-kristo@ti.com \
    --to=t-kristo@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).