Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: mach-shmobile: set i2c_board_info.type once
Date: Tue, 05 Jun 2012 12:16:29 +0200	[thread overview]
Message-ID: <1338891389.4971.45.camel@x61.thuisdomein> (raw)

tsc_device (of struct i2cboard_info) has its "type" member set to
"tsc2007" twice. First through the I2C_BOARD_INFO macro and then
directly. Drop the superfluous second instance.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) v1 was called "Drop superfluous setting of i2c_board_info.type". v2
drops the mach-imx bits. Those were already fixed with a patch called
"ARM: imx: only specify i2c device type once" by Uwe Kleine-K?nig.
Sascha Hauer has committed that patch to some unknown to me branch.
Rebased onto v3.5-rc1.

1) Still entirely untested. I'm unsure what toolchain is needed to
compile this and I'm certain that I don't have the hardware.

 arch/arm/mach-shmobile/board-ap4evb.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-ap4evb.c b/arch/arm/mach-shmobile/board-ap4evb.c
index ace6024..b9f3122 100644
--- a/arch/arm/mach-shmobile/board-ap4evb.c
+++ b/arch/arm/mach-shmobile/board-ap4evb.c
@@ -1197,7 +1197,6 @@ static struct tsc2007_platform_data tsc2007_info = {
 
 static struct i2c_board_info tsc_device = {
 	I2C_BOARD_INFO("tsc2007", 0x48),
-	.type		= "tsc2007",
 	.platform_data	= &tsc2007_info,
 	/*.irq is selected on ap4evb_init */
 };
-- 
1.7.7.6

                 reply	other threads:[~2012-06-05 10:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338891389.4971.45.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox