* [PATCH] clkdev: Fix leak in devm_clk_put()
@ 2012-06-05 10:44 Mark Brown
0 siblings, 0 replies; only message in thread
From: Mark Brown @ 2012-06-05 10:44 UTC (permalink / raw)
To: linux-arm-kernel
Surprisingly devres_destroy() doesn't call the destructor for the resource
it is destroying, causing devm_clk_put() to be ineffectual.
Use the newly added devres_release() instead to fix this.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/clk/clkdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index c535cf8..c7a4eee 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -133,7 +133,7 @@ void devm_clk_put(struct device *dev, struct clk *clk)
{
int ret;
- ret = devres_destroy(dev, devm_clk_release, devm_clk_match, clk);
+ ret = devres_release(dev, devm_clk_release, devm_clk_match, clk);
WARN_ON(ret);
}
--
1.7.10
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-06-05 10:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-05 10:44 [PATCH] clkdev: Fix leak in devm_clk_put() Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).