From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Tue, 05 Jun 2012 19:06:05 -0700 Subject: [PATCH 0/8] Rework KERN_ In-Reply-To: References: <20120605142826.d92316a0.akpm@linux-foundation.org> <1338934303.5780.8.camel@joe2Laptop> <20120605151754.a794ac7c.akpm@linux-foundation.org> <1338936572.5780.29.camel@joe2Laptop> <20120605162910.caccb0d4.akpm@linux-foundation.org> <1338939316.11962.3.camel@joe2Laptop> <1338939792.11962.4.camel@joe2Laptop> <1338940345.11962.9.camel@joe2Laptop> <20120605165808.cd255b93.akpm@linux-foundation.org> <1338941247.11962.16.camel@joe2Laptop> <1338941971.11962.20.camel@joe2Laptop> <20120605173751.65a2e1ee.akpm@linux-foundation.org> <1338943205.11962.28.camel@joe2Laptop> <20120605174638.69bcfa31.akpm@linux-foundation.org> Message-ID: <1338948365.11962.32.camel@joe2Laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2012-06-06 at 03:10 +0200, Kay Sievers wrote: > On Wed, Jun 6, 2012 at 2:46 AM, Andrew Morton wrote: > > On Tue, 05 Jun 2012 17:40:05 -0700 Joe Perches wrote: > > > >> On Tue, 2012-06-05 at 17:37 -0700, Andrew Morton wrote: > >> > On Tue, 05 Jun 2012 17:07:27 -0700 Joe Perches wrote: > >> > > >> > > On Tue, 2012-06-05 at 16:58 -0700, Andrew Morton wrote: > >> > > > echo "\0014Hello Joe" > /dev/kmsg > >> > > > >> > > # echo -e "\x014Hello Me" > /dev/kmsg > >> > > gives: > >> > > 12,778,4057982669;Hello Me > >> > > >> > That's changed behavior. > >> > >> Which is an improvement too. > > > > No it isn't. It exposes internal kernel implementation details in > > random weird inexplicable ways. It doesn't seem at all important > > though. > > > >> I very much doubt a single app will change > >> because of this. > > > > I doubt it as well. > > Yeah, the value of injecting such binary data is kind of questionable. :) > > Joe, maybe you can change printk_emit() to skip the prefix > detection/stripping if a prefix is already passed to the function? Sure, it's pretty trivial. Perhaps all binary data data should be elided. Maybe print . for all non-printable ascii chars.