* [PATCH 0/6] drivers: randconfig patches for kernel 3.5
@ 2012-06-08 22:24 mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 1/6] drivers/video: use correct __devexit_p annotation mathieu.poirier at linaro.org
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: mathieu.poirier at linaro.org @ 2012-06-08 22:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Mathieu Poirier <mathieu.poirier@linaro.org>
These patches fix miscellaneous problems when working
with make randconfig. They were discovered on kernel
3.1-rc4 and sent out during the 3.4 cycle but were not
ack'ed.
Sending out again for completeness.
Arnd Bergmann (6):
drivers/video: use correct __devexit_p annotation
mg_disk: use readb/writeb instead of inb/outb
video/ili9320: do not mark exported functions __devexit
video/console: automatically select a font
drivers/savagefb: use mdelay instead of udelay
drivers/tosa: driver needs I2C and SPI to compile
drivers/block/mg_disk.c | 78 ++++++++++++++++----------------
drivers/video/backlight/Kconfig | 2 +-
drivers/video/backlight/ili9320.c | 2 +-
drivers/video/broadsheetfb.c | 2 +-
drivers/video/console/Kconfig | 14 ++++++
drivers/video/mbx/mbxfb.c | 2 +-
drivers/video/savage/savagefb_driver.c | 10 ++--
7 files changed, 62 insertions(+), 48 deletions(-)
--
1.7.5.4
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH RESEND 1/6] drivers/video: use correct __devexit_p annotation
2012-06-08 22:24 [PATCH 0/6] drivers: randconfig patches for kernel 3.5 mathieu.poirier at linaro.org
@ 2012-06-08 22:24 ` mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 2/6] mg_disk: use readb/writeb instead of inb/outb mathieu.poirier at linaro.org
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: mathieu.poirier at linaro.org @ 2012-06-08 22:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
__devexit functions are discarded when CONFIG_HOTPLUG
is not set, so the symbol needs to be referenced carefully.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/video/broadsheetfb.c | 2 +-
drivers/video/mbx/mbxfb.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/broadsheetfb.c b/drivers/video/broadsheetfb.c
index 377dde3..c95b417 100644
--- a/drivers/video/broadsheetfb.c
+++ b/drivers/video/broadsheetfb.c
@@ -1211,7 +1211,7 @@ static int __devexit broadsheetfb_remove(struct platform_device *dev)
static struct platform_driver broadsheetfb_driver = {
.probe = broadsheetfb_probe,
- .remove = broadsheetfb_remove,
+ .remove = __devexit_p(broadsheetfb_remove),
.driver = {
.owner = THIS_MODULE,
.name = "broadsheetfb",
diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c
index ab0a8e5..85e4f44 100644
--- a/drivers/video/mbx/mbxfb.c
+++ b/drivers/video/mbx/mbxfb.c
@@ -1045,7 +1045,7 @@ static int __devexit mbxfb_remove(struct platform_device *dev)
static struct platform_driver mbxfb_driver = {
.probe = mbxfb_probe,
- .remove = mbxfb_remove,
+ .remove = __devexit_p(mbxfb_remove),
.suspend = mbxfb_suspend,
.resume = mbxfb_resume,
.driver = {
--
1.7.5.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RESEND 2/6] mg_disk: use readb/writeb instead of inb/outb
2012-06-08 22:24 [PATCH 0/6] drivers: randconfig patches for kernel 3.5 mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 1/6] drivers/video: use correct __devexit_p annotation mathieu.poirier at linaro.org
@ 2012-06-08 22:24 ` mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 3/6] video/ili9320: do not mark exported functions __devexit mathieu.poirier at linaro.org
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: mathieu.poirier at linaro.org @ 2012-06-08 22:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
The inb/outb functions are meant for PC-style programmed I/O,
which uses port numbers, not __iomem pointers. This driver
relies on ioremap to map the MMIO registers into the kernel
address space, so it should use the appropriate accessors.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/block/mg_disk.c | 78 +++++++++++++++++++++++-----------------------
1 files changed, 39 insertions(+), 39 deletions(-)
diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c
index 76fa3de..7d94fb0 100644
--- a/drivers/block/mg_disk.c
+++ b/drivers/block/mg_disk.c
@@ -187,7 +187,7 @@ static void mg_dump_status(const char *msg, unsigned int stat,
if ((stat & ATA_ERR) == 0) {
host->error = 0;
} else {
- host->error = inb((unsigned long)host->dev_base + MG_REG_ERROR);
+ host->error = readb(host->dev_base + MG_REG_ERROR);
printk(KERN_ERR "%s: %s: error=0x%02x { ", name, msg,
host->error & 0xff);
if (host->error & ATA_BBK)
@@ -225,11 +225,11 @@ static unsigned int mg_wait(struct mg_host *host, u32 expect, u32 msec)
* busy wait, because mflash's PLL is machine dependent.
*/
if (prv_data->use_polling) {
- status = inb((unsigned long)host->dev_base + MG_REG_STATUS);
- status = inb((unsigned long)host->dev_base + MG_REG_STATUS);
+ status = readb(host->dev_base + MG_REG_STATUS);
+ status = readb(host->dev_base + MG_REG_STATUS);
}
- status = inb((unsigned long)host->dev_base + MG_REG_STATUS);
+ status = readb(host->dev_base + MG_REG_STATUS);
do {
cur_jiffies = jiffies;
@@ -256,7 +256,7 @@ static unsigned int mg_wait(struct mg_host *host, u32 expect, u32 msec)
return MG_ERR_INV_STAT;
}
- status = inb((unsigned long)host->dev_base + MG_REG_STATUS);
+ status = readb(host->dev_base + MG_REG_STATUS);
} while (time_before(cur_jiffies, expire));
if (time_after_eq(cur_jiffies, expire) && msec)
@@ -281,7 +281,7 @@ static unsigned int mg_wait_rstout(u32 rstout, u32 msec)
static void mg_unexpected_intr(struct mg_host *host)
{
- u32 status = inb((unsigned long)host->dev_base + MG_REG_STATUS);
+ u32 status = readb(host->dev_base + MG_REG_STATUS);
mg_dump_status("mg_unexpected_intr", status, host);
}
@@ -351,18 +351,18 @@ static int mg_get_disk_id(struct mg_host *host)
char serial[ATA_ID_SERNO_LEN + 1];
if (!prv_data->use_polling)
- outb(ATA_NIEN, (unsigned long)host->dev_base + MG_REG_DRV_CTRL);
+ writeb(ATA_NIEN, host->dev_base + MG_REG_DRV_CTRL);
- outb(MG_CMD_ID, (unsigned long)host->dev_base + MG_REG_COMMAND);
+ writeb(MG_CMD_ID, host->dev_base + MG_REG_COMMAND);
err = mg_wait(host, ATA_DRQ, MG_TMAX_WAIT_RD_DRQ);
if (err)
return err;
for (i = 0; i < (MG_SECTOR_SIZE >> 1); i++)
- host->id[i] = le16_to_cpu(inw((unsigned long)host->dev_base +
+ host->id[i] = le16_to_cpu(readw(host->dev_base +
MG_BUFF_OFFSET + i * 2));
- outb(MG_CMD_RD_CONF, (unsigned long)host->dev_base + MG_REG_COMMAND);
+ writeb(MG_CMD_RD_CONF, host->dev_base + MG_REG_COMMAND);
err = mg_wait(host, MG_STAT_READY, MG_TMAX_CONF_TO_CMD);
if (err)
return err;
@@ -394,7 +394,7 @@ static int mg_get_disk_id(struct mg_host *host)
host->n_sectors, host->nres_sectors);
if (!prv_data->use_polling)
- outb(0, (unsigned long)host->dev_base + MG_REG_DRV_CTRL);
+ writeb(0, host->dev_base + MG_REG_DRV_CTRL);
return err;
}
@@ -419,20 +419,20 @@ static int mg_disk_init(struct mg_host *host)
return err;
/* soft reset on */
- outb(ATA_SRST | (prv_data->use_polling ? ATA_NIEN : 0),
- (unsigned long)host->dev_base + MG_REG_DRV_CTRL);
+ writeb(ATA_SRST | (prv_data->use_polling ? ATA_NIEN : 0),
+ host->dev_base + MG_REG_DRV_CTRL);
err = mg_wait(host, ATA_BUSY, MG_TMAX_RST_TO_BUSY);
if (err)
return err;
/* soft reset off */
- outb(prv_data->use_polling ? ATA_NIEN : 0,
- (unsigned long)host->dev_base + MG_REG_DRV_CTRL);
+ writeb(prv_data->use_polling ? ATA_NIEN : 0,
+ host->dev_base + MG_REG_DRV_CTRL);
err = mg_wait(host, MG_STAT_READY, MG_TMAX_SWRST_TO_RDY);
if (err)
return err;
- init_status = inb((unsigned long)host->dev_base + MG_REG_STATUS) & 0xf;
+ init_status = readb(host->dev_base + MG_REG_STATUS) & 0xf;
if (init_status == 0xf)
return MG_ERR_INIT_STAT;
@@ -465,15 +465,15 @@ static unsigned int mg_out(struct mg_host *host,
}
if (MG_RES_SEC)
sect_num += MG_RES_SEC;
- outb((u8)sect_cnt, (unsigned long)host->dev_base + MG_REG_SECT_CNT);
- outb((u8)sect_num, (unsigned long)host->dev_base + MG_REG_SECT_NUM);
- outb((u8)(sect_num >> 8), (unsigned long)host->dev_base +
+ writeb((u8)sect_cnt, host->dev_base + MG_REG_SECT_CNT);
+ writeb((u8)sect_num, host->dev_base + MG_REG_SECT_NUM);
+ writeb((u8)(sect_num >> 8), host->dev_base +
MG_REG_CYL_LOW);
- outb((u8)(sect_num >> 16), (unsigned long)host->dev_base +
+ writeb((u8)(sect_num >> 16), host->dev_base +
MG_REG_CYL_HIGH);
- outb((u8)((sect_num >> 24) | ATA_LBA | ATA_DEVICE_OBS),
- (unsigned long)host->dev_base + MG_REG_DRV_HEAD);
- outb(cmd, (unsigned long)host->dev_base + MG_REG_COMMAND);
+ writeb((u8)((sect_num >> 24) | ATA_LBA | ATA_DEVICE_OBS),
+ host->dev_base + MG_REG_DRV_HEAD);
+ writeb(cmd, host->dev_base + MG_REG_COMMAND);
return MG_ERR_NONE;
}
@@ -483,7 +483,7 @@ static void mg_read_one(struct mg_host *host, struct request *req)
u32 i;
for (i = 0; i < MG_SECTOR_SIZE >> 1; i++)
- *buff++ = inw((unsigned long)host->dev_base + MG_BUFF_OFFSET +
+ *buff++ = readw(host->dev_base + MG_BUFF_OFFSET +
(i << 1));
}
@@ -507,7 +507,7 @@ static void mg_read(struct request *req)
mg_read_one(host, req);
- outb(MG_CMD_RD_CONF, (unsigned long)host->dev_base +
+ writeb(MG_CMD_RD_CONF, host->dev_base +
MG_REG_COMMAND);
} while (mg_end_request(host, 0, MG_SECTOR_SIZE));
}
@@ -518,7 +518,7 @@ static void mg_write_one(struct mg_host *host, struct request *req)
u32 i;
for (i = 0; i < MG_SECTOR_SIZE >> 1; i++)
- outw(*buff++, (unsigned long)host->dev_base + MG_BUFF_OFFSET +
+ writew(*buff++, host->dev_base + MG_BUFF_OFFSET +
(i << 1));
}
@@ -545,7 +545,7 @@ static void mg_write(struct request *req)
do {
mg_write_one(host, req);
- outb(MG_CMD_WR_CONF, (unsigned long)host->dev_base +
+ writeb(MG_CMD_WR_CONF, host->dev_base +
MG_REG_COMMAND);
rem--;
@@ -568,7 +568,7 @@ static void mg_read_intr(struct mg_host *host)
/* check status */
do {
- i = inb((unsigned long)host->dev_base + MG_REG_STATUS);
+ i = readb(host->dev_base + MG_REG_STATUS);
if (i & ATA_BUSY)
break;
if (!MG_READY_OK(i))
@@ -588,7 +588,7 @@ ok_to_read:
blk_rq_pos(req), blk_rq_sectors(req) - 1, req->buffer);
/* send read confirm */
- outb(MG_CMD_RD_CONF, (unsigned long)host->dev_base + MG_REG_COMMAND);
+ writeb(MG_CMD_RD_CONF, host->dev_base + MG_REG_COMMAND);
if (mg_end_request(host, 0, MG_SECTOR_SIZE)) {
/* set handler if read remains */
@@ -606,7 +606,7 @@ static void mg_write_intr(struct mg_host *host)
/* check status */
do {
- i = inb((unsigned long)host->dev_base + MG_REG_STATUS);
+ i = readb(host->dev_base + MG_REG_STATUS);
if (i & ATA_BUSY)
break;
if (!MG_READY_OK(i))
@@ -630,7 +630,7 @@ ok_to_write:
}
/* send write confirm */
- outb(MG_CMD_WR_CONF, (unsigned long)host->dev_base + MG_REG_COMMAND);
+ writeb(MG_CMD_WR_CONF, host->dev_base + MG_REG_COMMAND);
if (!rem)
mg_request(host->breq);
@@ -697,7 +697,7 @@ static unsigned int mg_issue_req(struct request *req,
break;
case WRITE:
/* TODO : handler */
- outb(ATA_NIEN, (unsigned long)host->dev_base + MG_REG_DRV_CTRL);
+ writeb(ATA_NIEN, host->dev_base + MG_REG_DRV_CTRL);
if (mg_out(host, sect_num, sect_cnt, MG_CMD_WR, &mg_write_intr)
!= MG_ERR_NONE) {
mg_bad_rw_intr(host);
@@ -705,14 +705,14 @@ static unsigned int mg_issue_req(struct request *req,
}
del_timer(&host->timer);
mg_wait(host, ATA_DRQ, MG_TMAX_WAIT_WR_DRQ);
- outb(0, (unsigned long)host->dev_base + MG_REG_DRV_CTRL);
+ writeb(0, host->dev_base + MG_REG_DRV_CTRL);
if (host->error) {
mg_bad_rw_intr(host);
return host->error;
}
mg_write_one(host, req);
mod_timer(&host->timer, jiffies + 3 * HZ);
- outb(MG_CMD_WR_CONF, (unsigned long)host->dev_base +
+ writeb(MG_CMD_WR_CONF, host->dev_base +
MG_REG_COMMAND);
break;
}
@@ -789,15 +789,15 @@ static int mg_suspend(struct platform_device *plat_dev, pm_message_t state)
return -EIO;
if (!prv_data->use_polling)
- outb(ATA_NIEN, (unsigned long)host->dev_base + MG_REG_DRV_CTRL);
+ writeb(ATA_NIEN, host->dev_base + MG_REG_DRV_CTRL);
- outb(MG_CMD_SLEEP, (unsigned long)host->dev_base + MG_REG_COMMAND);
+ writeb(MG_CMD_SLEEP, host->dev_base + MG_REG_COMMAND);
/* wait until mflash deep sleep */
msleep(1);
if (mg_wait(host, MG_STAT_READY, MG_TMAX_CONF_TO_CMD)) {
if (!prv_data->use_polling)
- outb(0, (unsigned long)host->dev_base + MG_REG_DRV_CTRL);
+ writeb(0, host->dev_base + MG_REG_DRV_CTRL);
return -EIO;
}
@@ -812,7 +812,7 @@ static int mg_resume(struct platform_device *plat_dev)
if (mg_wait(host, MG_STAT_READY, MG_TMAX_CONF_TO_CMD))
return -EIO;
- outb(MG_CMD_WAKEUP, (unsigned long)host->dev_base + MG_REG_COMMAND);
+ writeb(MG_CMD_WAKEUP, host->dev_base + MG_REG_COMMAND);
/* wait until mflash wakeup */
msleep(1);
@@ -820,7 +820,7 @@ static int mg_resume(struct platform_device *plat_dev)
return -EIO;
if (!prv_data->use_polling)
- outb(0, (unsigned long)host->dev_base + MG_REG_DRV_CTRL);
+ writeb(0, host->dev_base + MG_REG_DRV_CTRL);
return 0;
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RESEND 3/6] video/ili9320: do not mark exported functions __devexit
2012-06-08 22:24 [PATCH 0/6] drivers: randconfig patches for kernel 3.5 mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 1/6] drivers/video: use correct __devexit_p annotation mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 2/6] mg_disk: use readb/writeb instead of inb/outb mathieu.poirier at linaro.org
@ 2012-06-08 22:24 ` mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 4/6] video/console: automatically select a font mathieu.poirier at linaro.org
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: mathieu.poirier at linaro.org @ 2012-06-08 22:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
No symbol can be exported when the section is discarded - the only
solution I could think of is not to mark symbols as __devexit
when they are exported.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/video/backlight/ili9320.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/ili9320.c b/drivers/video/backlight/ili9320.c
index 6c93993..9327cd1 100644
--- a/drivers/video/backlight/ili9320.c
+++ b/drivers/video/backlight/ili9320.c
@@ -263,7 +263,7 @@ int __devinit ili9320_probe_spi(struct spi_device *spi,
EXPORT_SYMBOL_GPL(ili9320_probe_spi);
-int __devexit ili9320_remove(struct ili9320 *ili)
+int ili9320_remove(struct ili9320 *ili)
{
ili9320_power(ili, FB_BLANK_POWERDOWN);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RESEND 4/6] video/console: automatically select a font
2012-06-08 22:24 [PATCH 0/6] drivers: randconfig patches for kernel 3.5 mathieu.poirier at linaro.org
` (2 preceding siblings ...)
2012-06-08 22:24 ` [PATCH RESEND 3/6] video/ili9320: do not mark exported functions __devexit mathieu.poirier at linaro.org
@ 2012-06-08 22:24 ` mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 5/6] drivers/savagefb: use mdelay instead of udelay mathieu.poirier at linaro.org
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: mathieu.poirier at linaro.org @ 2012-06-08 22:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
The frame buffer console needs at least one font to be built into
the kernel, so add the necessary Kconfig magic to guarantee that
one of the available font is always on. If a user accidentally
disables all fonts manually, the 8x16 font will be selected
anyway.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/video/console/Kconfig | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
index c2d11fe..e2c96d0 100644
--- a/drivers/video/console/Kconfig
+++ b/drivers/video/console/Kconfig
@@ -224,5 +224,19 @@ config FONT_10x18
big letters. It fits between the sun 12x22 and the normal 8x16 font.
If other fonts are too big or too small for you, say Y, otherwise say N.
+config FONT_AUTOSELECT
+ def_bool y
+ depends on FRAMEBUFFER_CONSOLE || SGI_NEWPORT_CONSOLE || STI_CONSOLE || USB_SISUSBVGA_CON
+ depends on !FONT_8x8
+ depends on !FONT_6x11
+ depends on !FONT_7x14
+ depends on !FONT_PEARL_8x8
+ depends on !FONT_ACORN_8x8
+ depends on !FONT_MINI_4x6
+ depends on !FONT_SUN8x16
+ depends on !FONT_SUN12x22
+ depends on !FONT_10x18
+ select FONT_8x16
+
endmenu
--
1.7.5.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RESEND 5/6] drivers/savagefb: use mdelay instead of udelay
2012-06-08 22:24 [PATCH 0/6] drivers: randconfig patches for kernel 3.5 mathieu.poirier at linaro.org
` (3 preceding siblings ...)
2012-06-08 22:24 ` [PATCH RESEND 4/6] video/console: automatically select a font mathieu.poirier at linaro.org
@ 2012-06-08 22:24 ` mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 6/6] drivers/tosa: driver needs I2C and SPI to compile mathieu.poirier at linaro.org
2012-06-09 0:13 ` [PATCH 0/6] drivers: randconfig patches for kernel 3.5 Arnd Bergmann
6 siblings, 0 replies; 10+ messages in thread
From: mathieu.poirier at linaro.org @ 2012-06-08 22:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
Long delays need to use mdelay on architectures such as ARM
that cannot compute long timeouts in udelay.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/video/savage/savagefb_driver.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/savage/savagefb_driver.c b/drivers/video/savage/savagefb_driver.c
index cee7803..f3d3b9c 100644
--- a/drivers/video/savage/savagefb_driver.c
+++ b/drivers/video/savage/savagefb_driver.c
@@ -1351,7 +1351,7 @@ static void savagefb_set_par_int(struct savagefb_par *par, struct savage_reg *r
/* following part not present in X11 driver */
cr67 = vga_in8(0x3d5, par) & 0xf;
vga_out8(0x3d5, 0x50 | cr67, par);
- udelay(10000);
+ mdelay(10);
vga_out8(0x3d4, 0x67, par);
/* end of part */
vga_out8(0x3d5, reg->CR67 & ~0x0c, par);
@@ -1904,11 +1904,11 @@ static int savage_init_hw(struct savagefb_par *par)
vga_out8(0x3d4, 0x66, par);
cr66 = vga_in8(0x3d5, par);
vga_out8(0x3d5, cr66 | 0x02, par);
- udelay(10000);
+ mdelay(10);
vga_out8(0x3d4, 0x66, par);
vga_out8(0x3d5, cr66 & ~0x02, par); /* clear reset flag */
- udelay(10000);
+ mdelay(10);
/*
@@ -1918,11 +1918,11 @@ static int savage_init_hw(struct savagefb_par *par)
vga_out8(0x3d4, 0x3f, par);
cr3f = vga_in8(0x3d5, par);
vga_out8(0x3d5, cr3f | 0x08, par);
- udelay(10000);
+ mdelay(10);
vga_out8(0x3d4, 0x3f, par);
vga_out8(0x3d5, cr3f & ~0x08, par); /* clear reset flags */
- udelay(10000);
+ mdelay(10);
/* Savage ramdac speeds */
par->numClocks = 4;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH RESEND 6/6] drivers/tosa: driver needs I2C and SPI to compile
2012-06-08 22:24 [PATCH 0/6] drivers: randconfig patches for kernel 3.5 mathieu.poirier at linaro.org
` (4 preceding siblings ...)
2012-06-08 22:24 ` [PATCH RESEND 5/6] drivers/savagefb: use mdelay instead of udelay mathieu.poirier at linaro.org
@ 2012-06-08 22:24 ` mathieu.poirier at linaro.org
2012-06-09 0:13 ` [PATCH 0/6] drivers: randconfig patches for kernel 3.5 Arnd Bergmann
6 siblings, 0 replies; 10+ messages in thread
From: mathieu.poirier at linaro.org @ 2012-06-08 22:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
This driver requires both SPI and I2C to build.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/video/backlight/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index fa2b037..2979292 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -88,7 +88,7 @@ config LCD_PLATFORM
config LCD_TOSA
tristate "Sharp SL-6000 LCD Driver"
- depends on SPI && MACH_TOSA
+ depends on I2C && SPI && MACH_TOSA
help
If you have an Sharp SL-6000 Zaurus say Y to enable a driver
for its LCD.
--
1.7.5.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 0/6] drivers: randconfig patches for kernel 3.5
2012-06-08 22:24 [PATCH 0/6] drivers: randconfig patches for kernel 3.5 mathieu.poirier at linaro.org
` (5 preceding siblings ...)
2012-06-08 22:24 ` [PATCH RESEND 6/6] drivers/tosa: driver needs I2C and SPI to compile mathieu.poirier at linaro.org
@ 2012-06-09 0:13 ` Arnd Bergmann
2012-06-09 12:57 ` Florian Tobias Schandinat
6 siblings, 1 reply; 10+ messages in thread
From: Arnd Bergmann @ 2012-06-09 0:13 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 08 June 2012, mathieu.poirier at linaro.org wrote:
> From: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> These patches fix miscellaneous problems when working
> with make randconfig. They were discovered on kernel
> 3.1-rc4 and sent out during the 3.4 cycle but were not
> ack'ed.
>
> Sending out again for completeness.
Hi Mathieu,
I just realized that most of these are for the same subsystem
(framebuffer), so you should have kept the respective mailing list
and maintainer on Cc (added now).
The mg_disk driver is not listed in the MAINTAINERS file but
has an author email listed in the file itself.
I can take the mg_disk patch into the arm-soc tree as a fix,
but I'd prefer the other patches to go through the framebuffer
tree.
Arnd
> Arnd Bergmann (6):
> drivers/video: use correct __devexit_p annotation
> mg_disk: use readb/writeb instead of inb/outb
> video/ili9320: do not mark exported functions __devexit
> video/console: automatically select a font
> drivers/savagefb: use mdelay instead of udelay
> drivers/tosa: driver needs I2C and SPI to compile
>
> drivers/block/mg_disk.c | 78 ++++++++++++++++----------------
> drivers/video/backlight/Kconfig | 2 +-
> drivers/video/backlight/ili9320.c | 2 +-
> drivers/video/broadsheetfb.c | 2 +-
> drivers/video/console/Kconfig | 14 ++++++
> drivers/video/mbx/mbxfb.c | 2 +-
> drivers/video/savage/savagefb_driver.c | 10 ++--
> 7 files changed, 62 insertions(+), 48 deletions(-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/6] drivers: randconfig patches for kernel 3.5
2012-06-09 0:13 ` [PATCH 0/6] drivers: randconfig patches for kernel 3.5 Arnd Bergmann
@ 2012-06-09 12:57 ` Florian Tobias Schandinat
2012-06-09 21:28 ` Arnd Bergmann
0 siblings, 1 reply; 10+ messages in thread
From: Florian Tobias Schandinat @ 2012-06-09 12:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd, Mathieu,
On 06/09/2012 12:13 AM, Arnd Bergmann wrote:
> On Friday 08 June 2012, mathieu.poirier at linaro.org wrote:
>> From: Mathieu Poirier <mathieu.poirier@linaro.org>
>>
>> These patches fix miscellaneous problems when working
>> with make randconfig. They were discovered on kernel
>> 3.1-rc4 and sent out during the 3.4 cycle but were not
>> ack'ed.
>>
>> Sending out again for completeness.
>
> Hi Mathieu,
>
> I just realized that most of these are for the same subsystem
> (framebuffer), so you should have kept the respective mailing list
> and maintainer on Cc (added now).
>
> The mg_disk driver is not listed in the MAINTAINERS file but
> has an author email listed in the file itself.
>
> I can take the mg_disk patch into the arm-soc tree as a fix,
> but I'd prefer the other patches to go through the framebuffer
> tree.
Applied all (including the backlight patches which are usually handled
by Andrew Morton) but the mg_disk patch.
Thanks,
Florian Tobias Schandinat
>
> Arnd
>
>> Arnd Bergmann (6):
>> drivers/video: use correct __devexit_p annotation
>> mg_disk: use readb/writeb instead of inb/outb
>> video/ili9320: do not mark exported functions __devexit
>> video/console: automatically select a font
>> drivers/savagefb: use mdelay instead of udelay
>> drivers/tosa: driver needs I2C and SPI to compile
>>
>> drivers/block/mg_disk.c | 78 ++++++++++++++++----------------
>> drivers/video/backlight/Kconfig | 2 +-
>> drivers/video/backlight/ili9320.c | 2 +-
>> drivers/video/broadsheetfb.c | 2 +-
>> drivers/video/console/Kconfig | 14 ++++++
>> drivers/video/mbx/mbxfb.c | 2 +-
>> drivers/video/savage/savagefb_driver.c | 10 ++--
>> 7 files changed, 62 insertions(+), 48 deletions(-)
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/6] drivers: randconfig patches for kernel 3.5
2012-06-09 12:57 ` Florian Tobias Schandinat
@ 2012-06-09 21:28 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2012-06-09 21:28 UTC (permalink / raw)
To: linux-arm-kernel
On Saturday 09 June 2012, Florian Tobias Schandinat wrote:
> >
> > I just realized that most of these are for the same subsystem
> > (framebuffer), so you should have kept the respective mailing list
> > and maintainer on Cc (added now).
> >
> > The mg_disk driver is not listed in the MAINTAINERS file but
> > has an author email listed in the file itself.
> >
> > I can take the mg_disk patch into the arm-soc tree as a fix,
> > but I'd prefer the other patches to go through the framebuffer
> > tree.
>
> Applied all (including the backlight patches which are usually handled
> by Andrew Morton) but the mg_disk patch.
Ok, Thanks a lot!
Arnd
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-06-09 21:28 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-08 22:24 [PATCH 0/6] drivers: randconfig patches for kernel 3.5 mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 1/6] drivers/video: use correct __devexit_p annotation mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 2/6] mg_disk: use readb/writeb instead of inb/outb mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 3/6] video/ili9320: do not mark exported functions __devexit mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 4/6] video/console: automatically select a font mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 5/6] drivers/savagefb: use mdelay instead of udelay mathieu.poirier at linaro.org
2012-06-08 22:24 ` [PATCH RESEND 6/6] drivers/tosa: driver needs I2C and SPI to compile mathieu.poirier at linaro.org
2012-06-09 0:13 ` [PATCH 0/6] drivers: randconfig patches for kernel 3.5 Arnd Bergmann
2012-06-09 12:57 ` Florian Tobias Schandinat
2012-06-09 21:28 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).