linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tixy@yxit.co.uk (Tixy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kprobes: run t32_simulate_ldr_literal() without insn slot
Date: Tue, 12 Jun 2012 08:08:26 +0100	[thread overview]
Message-ID: <1339484906.2912.2.camel@computer2.home> (raw)
In-Reply-To: <1339402732-20849-1-git-send-email-rabin.vincent@stericsson.com>

On Mon, 2012-06-11 at 13:48 +0530, Rabin Vincent wrote:
> t32_simulate_ldr_literal() can be run without an instruction slot, so it
> should be using DECODE_SIMULATEX instead of DECODE_EMULATEX.
> 
> Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>

Acked-by: Jon Medhurst <tixy@yxit.co.uk>

> ---
>  arch/arm/kernel/kprobes-thumb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/kprobes-thumb.c b/arch/arm/kernel/kprobes-thumb.c
> index 8f96ec7..6123daf 100644
> --- a/arch/arm/kernel/kprobes-thumb.c
> +++ b/arch/arm/kernel/kprobes-thumb.c
> @@ -660,7 +660,7 @@ static const union decode_item t32_table_1111_100x[] = {
>  	/* LDRSB (literal)	1111 1001 x001 1111 xxxx xxxx xxxx xxxx */
>  	/* LDRH (literal)	1111 1000 x011 1111 xxxx xxxx xxxx xxxx */
>  	/* LDRSH (literal)	1111 1001 x011 1111 xxxx xxxx xxxx xxxx */
> -	DECODE_EMULATEX	(0xfe5f0000, 0xf81f0000, t32_simulate_ldr_literal,
> +	DECODE_SIMULATEX(0xfe5f0000, 0xf81f0000, t32_simulate_ldr_literal,
>  						 REGS(PC, NOSPPCX, 0, 0, 0)),
>  
>  	/* STRB (immediate)	1111 1000 0000 xxxx xxxx 1xxx xxxx xxxx */

      reply	other threads:[~2012-06-12  7:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11  8:18 [PATCH] ARM: kprobes: run t32_simulate_ldr_literal() without insn slot Rabin Vincent
2012-06-12  7:08 ` Tixy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339484906.2912.2.camel@computer2.home \
    --to=tixy@yxit.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).