linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: kprobes: run t32_simulate_ldr_literal() without insn slot
@ 2012-06-11  8:18 Rabin Vincent
  2012-06-12  7:08 ` Tixy
  0 siblings, 1 reply; 2+ messages in thread
From: Rabin Vincent @ 2012-06-11  8:18 UTC (permalink / raw)
  To: linux-arm-kernel

t32_simulate_ldr_literal() can be run without an instruction slot, so it
should be using DECODE_SIMULATEX instead of DECODE_EMULATEX.

Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
---
 arch/arm/kernel/kprobes-thumb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/kernel/kprobes-thumb.c b/arch/arm/kernel/kprobes-thumb.c
index 8f96ec7..6123daf 100644
--- a/arch/arm/kernel/kprobes-thumb.c
+++ b/arch/arm/kernel/kprobes-thumb.c
@@ -660,7 +660,7 @@ static const union decode_item t32_table_1111_100x[] = {
 	/* LDRSB (literal)	1111 1001 x001 1111 xxxx xxxx xxxx xxxx */
 	/* LDRH (literal)	1111 1000 x011 1111 xxxx xxxx xxxx xxxx */
 	/* LDRSH (literal)	1111 1001 x011 1111 xxxx xxxx xxxx xxxx */
-	DECODE_EMULATEX	(0xfe5f0000, 0xf81f0000, t32_simulate_ldr_literal,
+	DECODE_SIMULATEX(0xfe5f0000, 0xf81f0000, t32_simulate_ldr_literal,
 						 REGS(PC, NOSPPCX, 0, 0, 0)),
 
 	/* STRB (immediate)	1111 1000 0000 xxxx xxxx 1xxx xxxx xxxx */
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: kprobes: run t32_simulate_ldr_literal() without insn slot
  2012-06-11  8:18 [PATCH] ARM: kprobes: run t32_simulate_ldr_literal() without insn slot Rabin Vincent
@ 2012-06-12  7:08 ` Tixy
  0 siblings, 0 replies; 2+ messages in thread
From: Tixy @ 2012-06-12  7:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, 2012-06-11 at 13:48 +0530, Rabin Vincent wrote:
> t32_simulate_ldr_literal() can be run without an instruction slot, so it
> should be using DECODE_SIMULATEX instead of DECODE_EMULATEX.
> 
> Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>

Acked-by: Jon Medhurst <tixy@yxit.co.uk>

> ---
>  arch/arm/kernel/kprobes-thumb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/kprobes-thumb.c b/arch/arm/kernel/kprobes-thumb.c
> index 8f96ec7..6123daf 100644
> --- a/arch/arm/kernel/kprobes-thumb.c
> +++ b/arch/arm/kernel/kprobes-thumb.c
> @@ -660,7 +660,7 @@ static const union decode_item t32_table_1111_100x[] = {
>  	/* LDRSB (literal)	1111 1001 x001 1111 xxxx xxxx xxxx xxxx */
>  	/* LDRH (literal)	1111 1000 x011 1111 xxxx xxxx xxxx xxxx */
>  	/* LDRSH (literal)	1111 1001 x011 1111 xxxx xxxx xxxx xxxx */
> -	DECODE_EMULATEX	(0xfe5f0000, 0xf81f0000, t32_simulate_ldr_literal,
> +	DECODE_SIMULATEX(0xfe5f0000, 0xf81f0000, t32_simulate_ldr_literal,
>  						 REGS(PC, NOSPPCX, 0, 0, 0)),
>  
>  	/* STRB (immediate)	1111 1000 0000 xxxx xxxx 1xxx xxxx xxxx */

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-12  7:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-11  8:18 [PATCH] ARM: kprobes: run t32_simulate_ldr_literal() without insn slot Rabin Vincent
2012-06-12  7:08 ` Tixy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).