From mboxrd@z Thu Jan 1 00:00:00 1970 From: dedekind1@gmail.com (Artem Bityutskiy) Date: Tue, 12 Jun 2012 13:49:36 +0300 Subject: [RFC PATCH] MTD: nand: add return value for write_page() function in structure of nand_ecc_ctrl. In-Reply-To: <1339153855-3761-1-git-send-email-josh.wu@atmel.com> References: <1339153855-3761-1-git-send-email-josh.wu@atmel.com> Message-ID: <1339498176.2401.27.camel@sauron.fi.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2012-06-08 at 19:10 +0800, Josh Wu wrote: > /** > + * nand_write_page_none - [INTERN] raw page writen function with return value > + * @mtd: mtd info structure > + * @chip: nand chip info structure > + * @buf: data buffer > + * @oob_required: must write chip->oob_poi to OOB > + */ > +static inline int nand_write_page_none(struct mtd_info *mtd, > + struct nand_chip *chip, > + const uint8_t *buf, int oob_required) > +{ > + nand_write_page_raw(mtd, chip, buf, oob_required); > + > + return 0; > +} Thanks! Would you please also make the wrtite_page_raw call-back return an error code - it is just strange to change '->write_page' and avoid changing '->write_page_raw'... P.S. Not sure we still want these baroque header comments, but this is just a side note and separate issue. -- Best Regards, Artem Bityutskiy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part URL: