From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 14/16] tty: serial: imx: remove the use of MXC_INTERNAL_IRQS
Date: Thu, 14 Jun 2012 13:59:45 +0800 [thread overview]
Message-ID: <1339653587-4832-15-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <1339653587-4832-1-git-send-email-shawn.guo@linaro.org>
As the part of the effort to enable SPARE_IRQ for imx platform,
the macro MXC_INTERNAL_IRQS will be removed. The imx serial driver
has a references to it for a decision on flags of request_irq call
based on rtsirq is beyond MXC_INTERNAL_IRQS. However the searching
on imx platform code tells that rtsirq will never be beyond
MXC_INTERNAL_IRQS. That said, the check, consequently the reference
to MXC_INTERNAL_IRQS are not needed, so remove them.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-serial at vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/tty/serial/imx.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 4ef7473..d5c689d6 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -169,7 +169,6 @@
#define SERIAL_IMX_MAJOR 207
#define MINOR_START 16
#define DEV_NAME "ttymxc"
-#define MAX_INTERNAL_IRQ MXC_INTERNAL_IRQS
/*
* This determines how often we check the modem status signals
@@ -741,10 +740,7 @@ static int imx_startup(struct uart_port *port)
/* do not use RTS IRQ on IrDA */
if (!USE_IRDA(sport)) {
- retval = request_irq(sport->rtsirq, imx_rtsint,
- (sport->rtsirq < MAX_INTERNAL_IRQ) ? 0 :
- IRQF_TRIGGER_FALLING |
- IRQF_TRIGGER_RISING,
+ retval = request_irq(sport->rtsirq, imx_rtsint, 0,
DRIVER_NAME, sport);
if (retval)
goto error_out3;
--
1.7.5.4
next prev parent reply other threads:[~2012-06-14 5:59 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 5:59 [PATCH 00/16] Enable SPARSE_IRQ support for imx Shawn Guo
2012-06-14 5:59 ` [PATCH 01/16] ARM: imx: eliminate macro IMX_GPIO_TO_IRQ() Shawn Guo
2012-06-14 7:31 ` Dong Aisheng
2012-06-14 7:39 ` Shawn Guo
2012-06-14 8:04 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 02/16] ARM: imx: eliminate macro IOMUX_TO_IRQ() Shawn Guo
2012-06-14 7:59 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 03/16] ARM: imx: eliminate macro IRQ_GPIOx() Shawn Guo
2012-06-15 9:23 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 04/16] gpio/mxc: move irq_domain_add_legacy call into gpio driver Shawn Guo
2012-06-15 9:26 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 05/16] ARM: imx: move irq_domain_add_legacy call into tzic driver Shawn Guo
2012-06-15 9:29 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 06/16] ARM: imx: move irq_domain_add_legacy call into avic driver Shawn Guo
2012-06-14 7:13 ` Shawn Guo
2012-06-15 9:30 ` Dong Aisheng
2012-07-06 6:26 ` [PATCH] ARM: imx: select IRQ_DOMAIN Uwe Kleine-König
2012-07-06 7:05 ` Shawn Guo
2012-07-06 7:07 ` Uwe Kleine-König
2012-07-06 7:12 ` Sascha Hauer
2012-07-06 7:18 ` [PATCH] ARM: imx: select USE_OF Uwe Kleine-König
2012-07-06 7:31 ` Shawn Guo
2012-07-06 7:47 ` [PATCH v2] " Uwe Kleine-König
2012-07-06 8:04 ` Shawn Guo
2012-07-06 19:15 ` Arnd Bergmann
2012-06-14 5:59 ` [PATCH 07/16] dma: ipu: remove the use of ipu_platform_data Shawn Guo
2012-06-14 10:26 ` Vinod Koul
2012-06-15 9:37 ` Dong Aisheng
2012-06-16 3:01 ` Shawn Guo
2012-06-18 8:19 ` Dong Aisheng
2012-06-18 14:02 ` Shawn Guo
2012-06-19 5:51 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 08/16] ARM: imx: leave irq_base of wm8350_platform_data uninitialized Shawn Guo
2012-06-15 12:20 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 09/16] ARM: imx: pass gpio than irq number into mxc_expio_init Shawn Guo
2012-06-15 12:21 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 10/16] ARM: imx: add a legacy irqdomain for 3ds_debugboard Shawn Guo
2012-06-15 12:22 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 11/16] ARM: imx: add a legacy irqdomain for mx31ads Shawn Guo
2012-06-18 8:20 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 12/16] i2c: imx: remove unneeded mach/irqs.h inclusion Shawn Guo
2012-06-14 7:30 ` Wolfram Sang
2012-06-18 8:20 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 13/16] ARM: imx: remove unneeded mach/irq.h inclusion Shawn Guo
2012-06-18 8:21 ` Dong Aisheng
2012-06-14 5:59 ` Shawn Guo [this message]
2012-06-14 15:37 ` [PATCH 14/16] tty: serial: imx: remove the use of MXC_INTERNAL_IRQS Greg Kroah-Hartman
2012-06-18 8:22 ` Dong Aisheng
2012-06-14 5:59 ` [PATCH 15/16] ARM: fiq: save FIQ_START by passing absolute fiq number Shawn Guo
2012-06-18 8:39 ` Dong Aisheng
2012-06-18 14:31 ` Shawn Guo
2012-06-18 16:44 ` Russell King - ARM Linux
2012-06-19 5:26 ` Shawn Guo
2012-06-20 22:55 ` Russell King - ARM Linux
2012-06-20 23:40 ` Shawn Guo
2012-06-20 23:53 ` Shawn Guo
2012-06-21 7:37 ` Russell King - ARM Linux
2012-06-21 8:50 ` Shawn Guo
2012-06-25 16:10 ` Shawn Guo
2012-06-14 5:59 ` [PATCH 16/16] ARM: imx: enable SPARSE_IRQ for imx platform Shawn Guo
2012-06-14 7:40 ` Haojian Zhuang
2012-06-14 7:55 ` Shawn Guo
2012-06-18 8:48 ` Dong Aisheng
2012-06-18 15:04 ` Shawn Guo
2012-06-19 6:16 ` Dong Aisheng
2012-06-19 6:47 ` Shawn Guo
2012-06-19 7:21 ` Dong Aisheng
2012-06-19 7:43 ` Shawn Guo
2012-06-19 13:01 ` Dong Aisheng
2012-06-19 13:19 ` [RFC PATCH 1/1] ARM: imx: enable SPARSE_IRQ for imx Dong Aisheng
2012-06-19 14:06 ` Shawn Guo
2012-06-20 2:23 ` Dong Aisheng
2012-06-20 5:40 ` Shawn Guo
2012-06-20 6:40 ` Dong Aisheng
2012-06-20 12:57 ` Shawn Guo
2012-06-20 14:45 ` Dong Aisheng
2012-06-14 8:00 ` [PATCH 00/16] Enable SPARSE_IRQ support " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339653587-4832-15-git-send-email-shawn.guo@linaro.org \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).