linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mkl@blackshift.org (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment
Date: Mon, 18 Jun 2012 02:07:34 +0200	[thread overview]
Message-ID: <1339978054-8464-1-git-send-email-mkl@blackshift.org> (raw)

In commit:
    98d9986 ARM: Kirkwood: Replace clock gating
the kirkwood clock gating has been reworked. A custom variant of
clock gating, that calls a custom function before gating the clock
off, has been introduced. However in clk_register_gate_fn() this
custom function "fn" is never assigned.

This patch adds the missing fn assignment.

Signed-off-by: Marc Kleine-Budde <mkl@blackshift.org>
---
Hi Andrew,

just stumbled over this one. I'm not sure if I missed something in the code
(it's time to go to bed here). Neither the original version or the patch
has been tested on hardware.

regards, Marc

 arch/arm/mach-kirkwood/common.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-kirkwood/common.c b/arch/arm/mach-kirkwood/common.c
index 25fb3fd..855e37b 100644
--- a/arch/arm/mach-kirkwood/common.c
+++ b/arch/arm/mach-kirkwood/common.c
@@ -159,6 +159,7 @@ static struct clk __init *clk_register_gate_fn(struct device *dev,
 	gate_fn->gate.flags = clk_gate_flags;
 	gate_fn->gate.lock = lock;
 	gate_fn->gate.hw.init = &init;
+	gate_fn->fn = fn;
 
 	/* ops is the gate ops, but with our disable function */
 	if (clk_gate_fn_ops.disable != clk_gate_fn_disable) {
-- 
1.7.4.1

             reply	other threads:[~2012-06-18  0:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18  0:07 Marc Kleine-Budde [this message]
2012-06-18  7:42 ` RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment Andrew Lunn
2012-06-18  7:54   ` Marc Kleine-Budde
2012-06-18  8:04     ` Andrew Lunn
2012-06-18  8:28       ` Dove clock support (was: Re: RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment) Marc Kleine-Budde
2012-06-18  8:43         ` Andrew Lunn
2012-06-18  9:42           ` Dove clock support Sebastian Hesselbarh
2012-06-18  9:54             ` Marc Kleine-Budde
2012-06-18 10:01               ` Sebastian Hesselbarh
2012-06-18 10:11                 ` Andrew Lunn
2012-06-18 20:38                   ` Sebastian Hesselbarh
2012-06-19 19:25                     ` Andrew Lunn
2012-06-19 19:31                       ` Sebastian Hesselbarh
2012-06-19 19:35                         ` Andrew Lunn
2012-06-18 11:50                 ` Marc Kleine-Budde
2012-06-18 21:41           ` Dove clock support (was: Re: RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment) Simon Baatz
2012-06-18 22:10             ` Dove clock support Sebastian Hesselbarh
2012-06-19 19:32               ` Andrew Lunn
2012-06-19 20:42                 ` Simon Baatz
2012-06-19 20:43                   ` Marc Kleine-Budde
2012-06-19 20:55                   ` Sebastian Hesselbarh
2012-06-19 23:06                     ` Simon Baatz
2012-06-20  5:43                       ` Andrew Lunn
2012-06-20  5:51                   ` Andrew Lunn
2012-06-24 15:17                     ` Simon Baatz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339978054-8464-1-git-send-email-mkl@blackshift.org \
    --to=mkl@blackshift.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).