linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 3/4] MTD: nand: add return value for write_page()/write_page_raw() functions in structure of nand_ecc_ctrl.
Date: Wed, 27 Jun 2012 12:26:36 +0300	[thread overview]
Message-ID: <1340789196.29342.7.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1340618866-28776-4-git-send-email-josh.wu@atmel.com>

On Mon, 2012-06-25 at 18:07 +0800, Josh Wu wrote:
> There is an implemention of hardware ECC write page function which may return an
> error indication.
> For instance, using Atmel HW PMECC to write one page into a nand flash, the hardware
> engine will compute the BCH ecc code for this page. so we need read a the
> status register to theck whether the ecc code is generated.
> But we cannot assume the status register always can be ready, for example,
> incorrect hardware configuration or hardware issue, in such case we need
> write_page() to return a error code.
> 
> Since the definition of 'write_page' function in struct nand_ecc_ctrl is 'void'.
> So this patch will:
>   1. add return 'int' value for 'write_page' function.
>   2. to be consitent, add return 'int' value for 'write_page_raw' fuctions too.
>   3. add code to test the return value, and if negative, indicate an
>   error happend when write page with ECC.
>   4. fix the compile warning in all impacted nand flash driver.
> 
> Note: I couldn't compile-test all of these easily, as some had ARCH dependencies.
> 
> Signed-off-by: Josh Wu <josh.wu@atmel.com>

Pushed this patch to l2-mtd.git, thanks!

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120627/9ff84927/attachment.sig>

  reply	other threads:[~2012-06-27  9:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 10:07 [PATCH v11 0/4] MTD: at91: Add PMECC support for at91 nand flash driver Josh Wu
2012-06-25 10:07 ` [PATCH v11 1/4] MTD: at91: extract hw ecc initialization to one function Josh Wu
2012-06-27  9:26   ` Artem Bityutskiy
2012-06-25 10:07 ` [PATCH v11 2/4] MTD: at91: add dt parameters for Atmel PMECC Josh Wu
2012-06-25 10:35   ` Richard Genoud
2012-06-26  6:05     ` Josh Wu
2012-06-25 10:07 ` [PATCH v11 3/4] MTD: nand: add return value for write_page()/write_page_raw() functions in structure of nand_ecc_ctrl Josh Wu
2012-06-27  9:26   ` Artem Bityutskiy [this message]
2012-06-25 10:07 ` [PATCH v11 4/4] MTD: at91: atmel_nand: Update driver to support Programmable Multibit ECC controller Josh Wu
2012-06-25 10:27   ` Richard Genoud
2012-06-26  6:03     ` Josh Wu
2012-06-26 14:15   ` Richard Genoud
2012-06-26 14:37     ` [PATCH v11 4/4] MTD: at91: atmel_nand: Update driver to support Programmable Multibit ECC controller (REPORT SPAM) William F.
2012-06-27 11:22     ` [PATCH v11 4/4] MTD: at91: atmel_nand: Update driver to support Programmable Multibit ECC controller Josh Wu
2012-06-27  3:45 ` [PATCH v11 0/4] MTD: at91: Add PMECC support for at91 nand flash driver Artem Bityutskiy
2012-06-27  3:49 ` Artem Bityutskiy
2012-06-27  4:11   ` Josh Wu
2012-06-27  4:28     ` Artem Bityutskiy
2012-06-27  5:34       ` Josh Wu
2012-06-27  8:39       ` Nicolas Ferre
2012-06-27  9:14         ` Artem Bityutskiy
2012-06-27  9:28 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340789196.29342.7.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).