linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP2+: fix CONFIG_CPU_IDLE dependency on CONFIG_PM
@ 2012-06-28 16:45 Kevin Hilman
  2012-06-29 13:04 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Kevin Hilman @ 2012-06-28 16:45 UTC (permalink / raw)
  To: linux-arm-kernel

commit 164e0cbf60 (ARM: OMAP3/4: consolidate cpuidle Makefile) added
an OMAP-specific dependency from CPU_IDLE to CONFIG_PM.  This causes
some randconfig warnings when CONFIG_PM has unmet dependencies:

warning: (ARCH_OMAP3 && ARCH_OMAP4) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (ARCH_OMAP3 && ARCH_OMAP4) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (ARCH_OMAP3 && ARCH_OMAP4) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)

Fix this by making the dependency on CONFIG_PM_RUNTIME (which in turn
will enable CONFIG_PM.)

Reported-by: Tony Lindgren <tony@atomide.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Kevin Hilman <khilman@ti.com>
---
Tony, this fixes the randconfig problems you mentioned.  It applies on
top of your testing-board branch, where the commit that introduced this
problem is applied.

 arch/arm/mach-omap2/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index f83dd91..6b7e028 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -35,7 +35,7 @@ config ARCH_OMAP3
 	select CPU_V7
 	select USB_ARCH_HAS_EHCI if USB_SUPPORT
 	select ARCH_HAS_OPP
-	select PM if CPU_IDLE
+	select PM_RUNTIME if CPU_IDLE
 	select PM_OPP if PM
 	select ARM_CPU_SUSPEND if PM
 	select MULTI_IRQ_HANDLER
@@ -53,7 +53,7 @@ config ARCH_OMAP4
 	select PL310_ERRATA_727915
 	select ARM_ERRATA_720789
 	select ARCH_HAS_OPP
-	select PM if CPU_IDLE
+	select PM_RUNTIME if CPU_IDLE
 	select PM_OPP if PM
 	select USB_ARCH_HAS_EHCI if USB_SUPPORT
 	select ARM_CPU_SUSPEND if PM
-- 
1.7.9.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: OMAP2+: fix CONFIG_CPU_IDLE dependency on CONFIG_PM
  2012-06-28 16:45 [PATCH] ARM: OMAP2+: fix CONFIG_CPU_IDLE dependency on CONFIG_PM Kevin Hilman
@ 2012-06-29 13:04 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-06-29 13:04 UTC (permalink / raw)
  To: linux-arm-kernel

* Kevin Hilman <khilman@ti.com> [120628 09:49]:
> commit 164e0cbf60 (ARM: OMAP3/4: consolidate cpuidle Makefile) added
> an OMAP-specific dependency from CPU_IDLE to CONFIG_PM.  This causes
> some randconfig warnings when CONFIG_PM has unmet dependencies:
> 
> warning: (ARCH_OMAP3 && ARCH_OMAP4) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
> warning: (ARCH_OMAP3 && ARCH_OMAP4) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
> warning: (ARCH_OMAP3 && ARCH_OMAP4) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
> 
> Fix this by making the dependency on CONFIG_PM_RUNTIME (which in turn
> will enable CONFIG_PM.)
> 
> Reported-by: Tony Lindgren <tony@atomide.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
> Tony, this fixes the randconfig problems you mentioned.  It applies on
> top of your testing-board branch, where the commit that introduced this
> problem is applied.

Thanks applying into fixes-non-critical. The warning is there already in
fixes-non-critical, testing-board was just based on that.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-29 13:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-28 16:45 [PATCH] ARM: OMAP2+: fix CONFIG_CPU_IDLE dependency on CONFIG_PM Kevin Hilman
2012-06-29 13:04 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).