From: josh.wu@atmel.com (Josh Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v13 0/2] MTD: at91: Add PMECC support for at91 nand flash driver
Date: Fri, 29 Jun 2012 17:47:53 +0800 [thread overview]
Message-ID: <1340963275-32104-1-git-send-email-josh.wu@atmel.com> (raw)
Those patches is based on the l2-mtd.git three.
Changes
since v12,
fix compile warning.
fix compile error for sparse compiler:
drivers/mtd/nand/atmel_nand.c:480:32: error: bad constant expression [sparse]
drivers/mtd/nand/atmel_nand.c:488:35: error: bad constant expression [sparse]
drivers/mtd/nand/atmel_nand.c:633:32: error: bad constant expression [sparse]
drivers/mtd/nand/atmel_nand.c:635:35: error: bad constant expression [sparse]
the error is caused by the dynamic 2d array: smu[cap + 2][2 * cap + 1].
since the smu is allocated when driver is probed, and the length of the smu depend on PMECC correction capablity.
so when I declare the type of smu by following line: (cap is declared as const type)
int16_t (*smu)[2 * cap + 1];
Sparse compiler reports above errors.
for fixing this compile error, I use one dimention array instead of 2d array, for instance: all smu[i][j] changes to smu[i * num + j]. num equal to 2 * cap + 1.
I tested it in sparse 0.4.4
since v11,
add documentation for atmel nand reg parameter and one example for PMECC support.
fix the bug: no error reported when fail to get resoures of PMECC ERRLOC or ROM.
fix the bug: no correction when ecc data has bit flipped.
add clearer debug information for data correction.
Josh Wu (2):
MTD: at91: add dt parameters for Atmel PMECC
MTD: at91: atmel_nand: Update driver to support Programmable Multibit
ECC controller
.../devicetree/bindings/mtd/atmel-nand.txt | 40 +-
drivers/mtd/nand/atmel_nand.c | 799 +++++++++++++++++++-
drivers/mtd/nand/atmel_nand_ecc.h | 114 ++-
3 files changed, 949 insertions(+), 4 deletions(-)
--
1.7.9.5
next reply other threads:[~2012-06-29 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 9:47 Josh Wu [this message]
2012-06-29 9:47 ` [PATCH v13 1/2] MTD: at91: add dt parameters for Atmel PMECC Josh Wu
2012-06-29 9:47 ` [PATCH v13 2/2] MTD: at91: atmel_nand: Update driver to support Programmable Multibit ECC controller Josh Wu
2012-06-29 10:36 ` [PATCH v13 0/2] MTD: at91: Add PMECC support for at91 nand flash driver Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340963275-32104-1-git-send-email-josh.wu@atmel.com \
--to=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).